all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Kei Kebreau <kei@openmailbox.org>
Cc: 26316@debbugs.gnu.org
Subject: bug#26316: Enable threaded compression of source tarballs
Date: Fri, 31 Mar 2017 19:04:13 -0400	[thread overview]
Message-ID: <20170331230413.GB9642@jasmine> (raw)
In-Reply-To: <87efxd5n3r.fsf@openmailbox.org>

[-- Attachment #1: Type: text/plain, Size: 1357 bytes --]

On Fri, Mar 31, 2017 at 02:15:36PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo@famulari.name> writes:
> > Subject: [PATCH] packages: Enable threaded compression of source tarballs.

> > -                                      "cvfa" #$output
> > +                                      "cvf" #$output
> > +                                      ;; The bootstrap xz does not support
> > +                                      ;; threaded compression (introduced in
> > +                                      ;; 5.2.0), but it ignores the extra flag.
> > +                                      (string-append "--use-compress-program="
> > +                                                     #+xz "/bin/xz --threads=0")

One question I have is about the removal of 'cvfa'. Here is the relevant
documentation:

-a, --auto-compress
             Use archive suffix to determine the compression
	     program.

AFAICT, we only build XZ archives, so it's okay to remove 'a' and
hard-code the use of xz. Is that correct?

> >                                        ;; avoid non-determinism in the archive
> >                                        "--mtime=@0"
> >                                        "--owner=root:0"
> 
> LGTM.

Thanks! This does mean rebuilding the world, so we'd need to save it for
the next core-updates cycle.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-03-31 23:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-30 22:17 bug#26316: Enable threaded compression of source tarballs Leo Famulari
2017-03-31 18:15 ` Kei Kebreau
2017-03-31 23:04   ` Leo Famulari [this message]
2017-03-31 23:56     ` Kei Kebreau
2017-04-01  0:15       ` Leo Famulari
2017-04-15 22:35 ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170331230413.GB9642@jasmine \
    --to=leo@famulari.name \
    --cc=26316@debbugs.gnu.org \
    --cc=kei@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.