all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Kei Kebreau <kei@openmailbox.org>
Cc: efraim@flashner.co.il, 26225@debbugs.gnu.org
Subject: bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel.
Date: Fri, 31 Mar 2017 19:01:58 -0400	[thread overview]
Message-ID: <20170331230158.GA9642@jasmine> (raw)
In-Reply-To: <87h9295nze.fsf@openmailbox.org>

[-- Attachment #1: Type: text/plain, Size: 1191 bytes --]

On Fri, Mar 31, 2017 at 01:56:37PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > Efraim Flashner wrote:
> >> * guix/scripts/pack.scm (%compressors): Add flag '-T0' when calling "xz".
> >> * guix/utils.scm (decompressed-port, compressed-port,
> >> compressed-output-port): Same.
> >
> >> --- a/guix/utils.scm
> >> +++ b/guix/utils.scm
> >> @@ -154,7 +155,7 @@ a symbol such as 'xz."
> >>    (match compression
> >>      ((or #f 'none) (values input '()))
> >>      ('bzip2        (filtered-port `(,%bzip2 "-dc") input))
> >> -    ('xz           (filtered-port `(,%xz "-dc") input))
> >> +    ('xz           (filtered-port `(,%xz "-dc -T0") input))
> >>      ('gzip         (filtered-port `(,%gzip "-dc") input))
> >>      (else          (error "unsupported compression scheme" compression))))
> >
> > Parallel decompression isn't implemented yet, but the extra '-T0' option
> > doesn't seem to break anything.
> >
> > The changes LGTM.
> >
> > I sent a companion patch to <https://bugs.gnu.org/26316> that enables
> > threaded compression when building source tarballs.
> 
> LGTM as well.

AFAICT, this doesn't cause mass rebuilds.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-03-31 23:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <E1cr0d6-0004an-8g@eggs.gnu.org>
     [not found] ` <5vvaqyii1c.fsf@fencepost.gnu.org>
2017-03-30 22:22   ` bug#26225: [PATCH] guix: Compress and decompress xz archives in parallel Leo Famulari
2017-03-31 17:56     ` Kei Kebreau
2017-03-31 23:01       ` Leo Famulari [this message]
2017-04-01  6:52     ` Marius Bakke
2017-04-02 21:21       ` Leo Famulari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170331230158.GA9642@jasmine \
    --to=leo@famulari.name \
    --cc=26225@debbugs.gnu.org \
    --cc=efraim@flashner.co.il \
    --cc=kei@openmailbox.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.