From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 1/5] gnu: Add python-mando-0.3.1 Date: Mon, 27 Mar 2017 14:58:15 -0400 Message-ID: <20170327185815.GA14845@jasmine> References: <20170326095634.4644-1-fredmanglis@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yrj/dFKFPuw6o+aM" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:46816) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1csZqQ-0002I1-UF for guix-devel@gnu.org; Mon, 27 Mar 2017 14:58:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1csZqN-0003w5-0D for guix-devel@gnu.org; Mon, 27 Mar 2017 14:58:23 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47884) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1csZqM-0003vF-Ba for guix-devel@gnu.org; Mon, 27 Mar 2017 14:58:18 -0400 Content-Disposition: inline In-Reply-To: <20170326095634.4644-1-fredmanglis@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Muriithi Frederick Muriuki Cc: guix-devel@gnu.org, pjotr2017@thebird.nl --yrj/dFKFPuw6o+aM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Mar 26, 2017 at 12:56:30PM +0300, Muriithi Frederick Muriuki wrote: > * gnu/packages/python.scm (python-mando-0.3.1): New variable. Overall this patch series LGTM. Minor comments to follow... > +(define-public python-mando-0.3.1 Let's add a comment explaining why we have this older version. Something like "Foo requires version 0.3.1 of python-mando". --yrj/dFKFPuw6o+aM Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAljZYMcACgkQJkb6MLrK fwgXTRAA7EqVQK69+YjwlXw8o6duW5jYIWUgnczfntyGnwvn4BpPR5sQgQT/D8qB WF9aHHdLj3wtuBhuhfJ6CxYFpYXuMXkw1me0IQiqfIrI8k6NfzPyBUQqu671imsr d0Ridbn+zLG8N4bCbz3s3DJjseiqMTkXYMSzzyUzMvKdWZ4HQMnlC+Idge4G8VIS ZlXiV2kZ/diuTgZzo3MpvF5FIqohJnreHNGw3OHCApY4PZ9S/GPXNPKNBLyK1GLc vGNdzT/zZSXWMC8WJj7OacnvyW7in8D6JzG9grIagUDIT9/NvGEHBMZv/oLMqAi5 bgav+Xvow25lJlxP9gTjaSjasoDj4BriPC6+djPfIYKoZMK+tX1k7X3/4JOLcpo7 GmicCsDaC2f9ltqBkBrHq01NhDh0Ua3yibdi/jI050YZSy8fhRzFv3raxbQb+oMz QEV/d3VCNvoa9MiqXhdyMRN+h/joKQ0KO7NFJVBSDWeQWqsetZTY1uqlTv3yxJdQ CnXIs//bYpmx5ySO7oeTXKRzWvbqu92/vGUqdSyc/aRPttMIfdwQ26gD7lL4AABc doiumLhdtw8hnSFiPE0aM2FmD9dxyD64qL+7JKdxzvEo/qmwVLZhDQ7qoLpIwvNz GdhcTepZinL+W2971QACZrIx+9MRVgtUoRWTp2D+Lkac0Fr9ikg= =ylZB -----END PGP SIGNATURE----- --yrj/dFKFPuw6o+aM--