* Re: 01/02: gnu: Add itpp.
[not found] ` <20170318093208.C125820945@vcs0.savannah.gnu.org>
@ 2017-03-19 20:46 ` Mark H Weaver
2017-03-20 6:03 ` John Darrington
0 siblings, 1 reply; 6+ messages in thread
From: Mark H Weaver @ 2017-03-19 20:46 UTC (permalink / raw)
To: John Darrington; +Cc: guix-devel
john@darrington.wattle.id.au (John Darrington) writes:
> jmd pushed a commit to branch master
> in repository guix.
>
> commit a53d6719bc6b6b4afdc58e257ac712df316c8858
> Author: John Darrington <jmd@gnu.org>
> Date: Tue Mar 7 07:51:51 2017 +0100
>
> gnu: Add itpp.
>
> * gnu/packages/maths.scm (itpp): New variable.
> ---
> gnu/packages/maths.scm | 30 +++++++++++++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index adc8156..fe85983 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -1,7 +1,7 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright © 2013, 2014, 2015, 2016 Andreas Enge <andreas@enge.fr>
> ;;; Copyright © 2013 Nikita Karetnikov <nikita@karetnikov.org>
> -;;; Copyright © 2014, 2016 John Darrington <jmd@gnu.org>
> +;;; Copyright © 2014, 2016, 2017 John Darrington <jmd@gnu.org>
> ;;; Copyright © 2014, 2015, 2016 Eric Bavier <bavier@member.fsf.org>
> ;;; Copyright © 2014 Federico Beffa <beffa@fbengineering.ch>
> ;;; Copyright © 2014 Mathieu Lirzin <mathieu.lirzin@openmailbox.org>
> @@ -761,6 +761,34 @@ Swath).")
> HDF5 file is encoded according to the HDF File Format Specification.")
> (license (license:x11-style "file://COPYING"))))
>
> +(define-public itpp
> + (package
> + (name "itpp")
> + (version "4.3.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://sourceforge/itpp/itpp/"
> + version "/itpp-"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "14ddy2xnb6sgp4hiax9v5sv4pr4l4dd4ps76nfha3nrpr1ikhcqm"))))
Please be more careful with the indentation above.
Mark
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 01/02: gnu: Add itpp.
2017-03-19 20:46 ` 01/02: gnu: Add itpp Mark H Weaver
@ 2017-03-20 6:03 ` John Darrington
2017-03-20 6:18 ` Leo Famulari
0 siblings, 1 reply; 6+ messages in thread
From: John Darrington @ 2017-03-20 6:03 UTC (permalink / raw)
To: Mark H Weaver; +Cc: guix-devel, John Darrington
[-- Attachment #1: Type: text/plain, Size: 2848 bytes --]
On Sun, Mar 19, 2017 at 04:46:07PM -0400, Mark H Weaver wrote:
john@darrington.wattle.id.au (John Darrington) writes:
> jmd pushed a commit to branch master
> in repository guix.
>
> commit a53d6719bc6b6b4afdc58e257ac712df316c8858
> Author: John Darrington <jmd@gnu.org>
> Date: Tue Mar 7 07:51:51 2017 +0100
>
> gnu: Add itpp.
>
> * gnu/packages/maths.scm (itpp): New variable.
> ---
> gnu/packages/maths.scm | 30 +++++++++++++++++++++++++++++-
> 1 file changed, 29 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
> index adc8156..fe85983 100644
> --- a/gnu/packages/maths.scm
> +++ b/gnu/packages/maths.scm
> @@ -1,7 +1,7 @@
> ;;; GNU Guix --- Functional package management for GNU
> ;;; Copyright ?? 2013, 2014, 2015, 2016 Andreas Enge <andreas@enge.fr>
> ;;; Copyright ?? 2013 Nikita Karetnikov <nikita@karetnikov.org>
> -;;; Copyright ?? 2014, 2016 John Darrington <jmd@gnu.org>
> +;;; Copyright ?? 2014, 2016, 2017 John Darrington <jmd@gnu.org>
> ;;; Copyright ?? 2014, 2015, 2016 Eric Bavier <bavier@member.fsf.org>
> ;;; Copyright ?? 2014 Federico Beffa <beffa@fbengineering.ch>
> ;;; Copyright ?? 2014 Mathieu Lirzin <mathieu.lirzin@openmailbox.org>
> @@ -761,6 +761,34 @@ Swath).")
> HDF5 file is encoded according to the HDF File Format Specification.")
> (license (license:x11-style "file://COPYING"))))
>
> +(define-public itpp
> + (package
> + (name "itpp")
> + (version "4.3.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "mirror://sourceforge/itpp/itpp/"
> + version "/itpp-"
> + version ".tar.gz"))
> + (sha256
> + (base32
> + "14ddy2xnb6sgp4hiax9v5sv4pr4l4dd4ps76nfha3nrpr1ikhcqm"))))
Please be more careful with the indentation above.
Do you know - I've been looking carefully at the above for about a minute now, and
I cannot see anything wrong with the indentation. I'm not saying that there isn't
anything wrong - but I cannot see it despite close scrutiny. So I must ask myself:
can we not be a little less strict about indentation?
Anyway Rekado has made me aware of emacs-guix and of etc/indent-code.el so maybe I'll
set up a git hook to use that.
J'
--
Avoid eavesdropping. Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 01/02: gnu: Add itpp.
2017-03-20 6:03 ` John Darrington
@ 2017-03-20 6:18 ` Leo Famulari
2017-03-20 6:38 ` John Darrington
0 siblings, 1 reply; 6+ messages in thread
From: Leo Famulari @ 2017-03-20 6:18 UTC (permalink / raw)
To: John Darrington; +Cc: guix-devel, John Darrington
[-- Attachment #1: Type: text/plain, Size: 514 bytes --]
On Mon, Mar 20, 2017 at 07:03:03AM +0100, John Darrington wrote:
> > + (source (origin
> > + (method url-fetch)
> > + (uri (string-append "mirror://sourceforge/itpp/itpp/"
> > + version "/itpp-"
> > + version ".tar.gz"))
> > + (sha256
> > + (base32
> > + "14ddy2xnb6sgp4hiax9v5sv4pr4l4dd4ps76nfha3nrpr1ikhcqm"))))
(sha256) should be indented from (origin).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 01/02: gnu: Add itpp.
2017-03-20 6:18 ` Leo Famulari
@ 2017-03-20 6:38 ` John Darrington
2017-03-20 11:05 ` Alex Kost
0 siblings, 1 reply; 6+ messages in thread
From: John Darrington @ 2017-03-20 6:38 UTC (permalink / raw)
To: Leo Famulari; +Cc: guix-devel, John Darrington
[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]
On Mon, Mar 20, 2017 at 02:18:39AM -0400, Leo Famulari wrote:
On Mon, Mar 20, 2017 at 07:03:03AM +0100, John Darrington wrote:
> > + (source (origin
> > + (method url-fetch)
> > + (uri (string-append "mirror://sourceforge/itpp/itpp/"
> > + version "/itpp-"
> > + version ".tar.gz"))
> > + (sha256
> > + (base32
> > + "14ddy2xnb6sgp4hiax9v5sv4pr4l4dd4ps76nfha3nrpr1ikhcqm"))))
(sha256) should be indented from (origin).
Ahh. You are right (of course). Emacs must have missed that one - perhaps it'll
do a better job now I have the plugin installed.
J'
--
Avoid eavesdropping. Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 01/02: gnu: Add itpp.
2017-03-20 6:38 ` John Darrington
@ 2017-03-20 11:05 ` Alex Kost
2017-03-20 12:17 ` John Darrington
0 siblings, 1 reply; 6+ messages in thread
From: Alex Kost @ 2017-03-20 11:05 UTC (permalink / raw)
To: John Darrington; +Cc: guix-devel, John Darrington
John Darrington (2017-03-20 07:38 +0100) wrote:
> On Mon, Mar 20, 2017 at 02:18:39AM -0400, Leo Famulari wrote:
> On Mon, Mar 20, 2017 at 07:03:03AM +0100, John Darrington wrote:
> > > + (source (origin
> > > + (method url-fetch)
> > > + (uri (string-append "mirror://sourceforge/itpp/itpp/"
> > > + version "/itpp-"
> > > + version ".tar.gz"))
> > > + (sha256
> > > + (base32
> > > + "14ddy2xnb6sgp4hiax9v5sv4pr4l4dd4ps76nfha3nrpr1ikhcqm"))))
>
> (sha256) should be indented from (origin).
>
> Ahh. You are right (of course). Emacs must have missed that one - perhaps it'll
> do a better job now I have the plugin installed.
You don't need any additional "plugins" for this, as Emacs couldn't miss
it!
To check it, run "emacs -Q", paste this:
(source (origin
(method url-fetch)
(uri (string-append "mirror://sourceforge/itpp/itpp/"
version "/itpp-"
version ".tar.gz"))
(sha256
(base32
"14ddy2xnb6sgp4hiax9v5sv4pr4l4dd4ps76nfha3nrpr1ikhcqm"))))
to some buffer, run "M-x scheme-mode" there, move the point to the
beginning of this sexp and press "C-M-q" ("indent-sexp" command). And
you'll see that (sha256) is at the same column as (origin).
--
Alex
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: 01/02: gnu: Add itpp.
2017-03-20 11:05 ` Alex Kost
@ 2017-03-20 12:17 ` John Darrington
0 siblings, 0 replies; 6+ messages in thread
From: John Darrington @ 2017-03-20 12:17 UTC (permalink / raw)
To: Alex Kost; +Cc: guix-devel, John Darrington
[-- Attachment #1: Type: text/plain, Size: 1105 bytes --]
On Mon, Mar 20, 2017 at 02:05:11PM +0300, Alex Kost wrote:
You don't need any additional "plugins" for this, as Emacs couldn't miss
it!
To check it, run "emacs -Q", paste this:
(source (origin
(method url-fetch)
(uri (string-append "mirror://sourceforge/itpp/itpp/"
version "/itpp-"
version ".tar.gz"))
(sha256
(base32
"14ddy2xnb6sgp4hiax9v5sv4pr4l4dd4ps76nfha3nrpr1ikhcqm"))))
to some buffer, run "M-x scheme-mode" there, move the point to the
beginning of this sexp and press "C-M-q" ("indent-sexp" command). And
you'll see that (sha256) is at the same column as (origin).
I thought I did that. Possibly, I forgot to do it one last time, before I
committed.
J'
--
Avoid eavesdropping. Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3
fingerprint = 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-20 12:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170318093207.31474.12254@vcs0.savannah.gnu.org>
[not found] ` <20170318093208.C125820945@vcs0.savannah.gnu.org>
2017-03-19 20:46 ` 01/02: gnu: Add itpp Mark H Weaver
2017-03-20 6:03 ` John Darrington
2017-03-20 6:18 ` Leo Famulari
2017-03-20 6:38 ` John Darrington
2017-03-20 11:05 ` Alex Kost
2017-03-20 12:17 ` John Darrington
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.