From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: Could anyone help me to pack the shellcheck (haskell)
Date: Thu, 9 Mar 2017 19:34:41 +0100
Message-ID: <20170309193441.494c63b6@scratchpost.org>
References: <87innkkm2e.fsf@163.com> <20170308220438.74ffa36c@scratchpost.org>
	<87mvcun0go.fsf@163.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43653)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cm2ts-0000hU-JI
	for guix-devel@gnu.org; Thu, 09 Mar 2017 13:35:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cm2tn-0001C4-C7
	for guix-devel@gnu.org; Thu, 09 Mar 2017 13:34:56 -0500
Received: from dd1012.kasserver.com ([85.13.128.8]:40190)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <dannym@scratchpost.org>)
	id 1cm2tn-0001Bu-4l
	for guix-devel@gnu.org; Thu, 09 Mar 2017 13:34:51 -0500
In-Reply-To: <87mvcun0go.fsf@163.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: "Huang, Ying" <huang_ying_caritas@163.com>
Cc: guix-devel <guix-devel@gnu.org>

Hi,

On Thu, 09 Mar 2017 19:39:19 +0800
"Huang\, Ying" <huang_ying_caritas@163.com> wrote:

> Danny Milosavljevic <dannym@scratchpost.org> writes:
> 
> > Hi,
> >
> > On Wed, 08 Mar 2017 20:08:41 +0800
> > "Huang\, Ying" <huang_ying_caritas@163.com> wrote:
> >  
> >> I know very little about Haskell, but I use shellcheck
> >> (https://github.com/koalaman/shellcheck) to check my shell scripts.  I
> >> tried myself, but found it is hard for me.  Could anyone help me on
> >> that?  
> 
> Great!  It works! 

Nice. Good to know that it works for you as-is.

>Thanks a lot!  Now I can use shellcheck.  Could you
> make it merged by Guix?

Eventually, but it has to go through the normal review process in any case.

Could you give some details for the description? I'm not a user of shellcheck so I have no idea what else to put there.

Also, could you do a license review (check the shellcheck source files for header comments which say what license to use) and make sure it's actually gpl3 or later ?

Then I'll post an updated patch to guix-patches (to be merged eventually after review) if you want.