From mboxrd@z Thu Jan  1 00:00:00 1970
From: ng0 <contact.ng0@cryptolab.net>
Subject: Re: [PATCH 4/4] services: openssh: Add 'subsystems' option.
Date: Sun, 5 Mar 2017 14:50:26 +0000
Message-ID: <20170305145026.zgoayn46kvpz5ksy@abyayala>
References: <20170219185431.zgn53ndcbpedrgo7@wasp>
	<20170220235355.29115-1-clement@lassieur.org>
	<20170220235355.29115-5-clement@lassieur.org>
	<20170302084448.2ff6ce96@scratchpost.org>
	<87fuivxukg.fsf@lassieur.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51620)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <contact.ng0@cryptolab.net>) id 1ckWQ1-0008Oz-MU
	for guix-devel@gnu.org; Sun, 05 Mar 2017 08:41:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <contact.ng0@cryptolab.net>) id 1ckWPy-0006HT-JC
	for guix-devel@gnu.org; Sun, 05 Mar 2017 08:41:49 -0500
Received: from fragranza.investici.org ([2a00:1dc0:2479::19]:55404)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <contact.ng0@cryptolab.net>)
	id 1ckWPy-0006Bv-8M
	for guix-devel@gnu.org; Sun, 05 Mar 2017 08:41:46 -0500
Content-Disposition: inline
In-Reply-To: <87fuivxukg.fsf@lassieur.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: =?utf-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
Cc: guix-devel@gnu.org

On 17-03-02 22:00:47, Cl=C3=A9ment Lassieur wrote:
> Hi Danny,
>=20
> Danny Milosavljevic <dannym@scratchpost.org> writes:
>=20
> > Hi,
> >
> > On Tue, 21 Feb 2017 00:53:55 +0100
> > Cl=C3=A9ment Lassieur <clement@lassieur.org> wrote:
> >> +This is a list of two-element tuples,=20
> >
> > list of pairs.
> >
> >>where each tuple contains the
> >
> > each pair
> >
> >> +subsystem name and a command (with optional arguments) to execute u=
pon
> >> +subsystem request.
> >> +
> >> +The command @command{sftp-server} implements the SFTP file transfer
> >> +subsystem.
> >> +@example
> >> +'(("sftp" "/usr/libexec/sftp-server"))
> >
> > Hmm, that is a list in there, not a two-element tuple:
> >
> > scheme@(guile-user)> (car '(("A" "B")))
> > $1 =3D ("A" "B")
> > scheme@(guile-user)> (car (car '(("A" "B"))))
> > $3 =3D "A"
> > scheme@(guile-user)> (cdr (car '(("A" "B"))))
> > $2 =3D ("B")  <---- should be "B" without the parens for tuples
> >
> > So I suggest either fix the example to be a pair ("sftp" . "/usr/libe=
xec/sftp-server") or fix the docs.
>=20
> Ok.  I'll correct this later, for now I don't want to push this patch,
> I'm waiting for a confirmation from ng0.
>=20
> Thanks for the review!
>=20

Okay, I've tried to figure out what the correct patches are but now that
I know the fact that subsystems was left out later (or my tree view is
wrong) is strange.

What I take from the discussion is, all is good to go except for
subsystems. I'm okay with reviewing subsystems as an individual patch
later on. For me this works. Push the 3 patches, and send the subsystems
one later as a new discussion-bug.