From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: bug#25917: operating-system file-system with (check? #t) but
	(needed-for-boot #f) pauses boot until user interaction
Date: Wed, 1 Mar 2017 17:38:38 +0100
Message-ID: <20170301173838.797d5dbc@scratchpost.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60843)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cj7HO-0007p3-Df
	for bug-guix@gnu.org; Wed, 01 Mar 2017 11:39:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cj7HK-0000Lz-Ak
	for bug-guix@gnu.org; Wed, 01 Mar 2017 11:39:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:36441)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1cj7HK-0000Ls-6u
	for bug-guix@gnu.org; Wed, 01 Mar 2017 11:39:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1cj7HK-00046m-0D
	for bug-guix@gnu.org; Wed, 01 Mar 2017 11:39:02 -0500
Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org>
Resent-Message-ID: <handler.25917.B.148838633715780@debbugs.gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60637)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cj7H6-0007oS-QE
	for bug-guix@gnu.org; Wed, 01 Mar 2017 11:38:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cj7H2-0000Df-Oq
	for bug-guix@gnu.org; Wed, 01 Mar 2017 11:38:48 -0500
Received: from dd1012.kasserver.com ([85.13.128.8]:55652)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <dannym@scratchpost.org>)
	id 1cj7H2-0000Cx-Hw
	for bug-guix@gnu.org; Wed, 01 Mar 2017 11:38:44 -0500
Received: from localhost (77.118.20.175.wireless.dyn.drei.com [77.118.20.175])
	by dd1012.kasserver.com (Postfix) with ESMTPSA id AC2E41CA080C
	for <bug-guix@gnu.org>; Wed,  1 Mar 2017 17:38:42 +0100 (CET)
List-Id: Bug reports for GNU Guix <bug-guix.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/bug-guix/>
List-Post: <mailto:bug-guix@gnu.org>
List-Help: <mailto:bug-guix-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-guix>,
	<mailto:bug-guix-request@gnu.org?subject=subscribe>
Errors-To: bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org
Sender: "bug-Guix" <bug-guix-bounces+gcggb-bug-guix=m.gmane.org@gnu.org>
To: 25917@debbugs.gnu.org

If one has a operating-system file-system with (check? #t) but (needed-for-boot #f), the next boot after reconfiguring will boot into a Guile REPL because the initrd doesn't contain the fsck tool for that file system (because all the file-systems with (needed-for-boot #f) have been filtered out). Therefore, the normal boot process breaks.

Possible fixes:
- If (check? #t) but (needed-for-boot? #f), include the tool anyway, XOR
- If (check? #t) but (needed-for-boot? #f), don't check anyway

This can be reproduced for example by connecting an USB flash storage stick with a filesystem with a type on it that's not used in any other file-system declaration.

NB: If (check? #t) and (needed-for-boot? #t), everything works fine.

For all these, (mount? #t) (the default).

This is on Guix master from a few minutes ago.