all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Clément Lassieur" <clement@lassieur.org>
To: guix-devel@gnu.org
Cc: jmd@gnu.org
Subject: [PATCH 0/2] Services configuration syntaxes patches.
Date: Tue, 28 Feb 2017 23:50:42 +0100	[thread overview]
Message-ID: <20170228225044.25315-1-clement@lassieur.org> (raw)

There was a bug in the dovecot service introduced by a refactoring of syntaxes
functions.  I don't think those functions should be put in a common file,
because syntaxes are often specific to services, as I explained in one of the
commit messages.

Therefore I did two commits.  The first fixes the bug.  The other removes
functions that should not be abstracted from configuration.scm, and put them
back into their specific services.

The second commit should not have any actual effect, but I checked that
services depending on configuration.scm were still working and:
  - Dovecot works (because of the first commit).
  - Prosody works (no changes).
  - Cups works.
  - I don't know how to test Kerberos, but its configuration file didn't move.
  - OpenVPN does not build when put in config.scm, because of a tls issue, so
    I could not check (but I didn't need to modify it).

WDYT?

Clément Lassieur (2):
  services: dovecot: Reimplement proper configuration functions.
  services: Move configuration functions that shouldn't be factorized.

 gnu/services/configuration.scm | 40 ----------------------------------------
 gnu/services/cups.scm          | 32 ++++++++++++++++++++++++++++++++
 gnu/services/kerberos.scm      | 15 +++++++++++++++
 gnu/services/mail.scm          | 30 ++++++++++++++++++++++++++++++
 4 files changed, 77 insertions(+), 40 deletions(-)

-- 
2.12.0

             reply	other threads:[~2017-02-28 22:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-28 22:50 Clément Lassieur [this message]
2017-02-28 22:50 ` [PATCH 1/2] services: dovecot: Reimplement proper configuration functions Clément Lassieur
2017-02-28 22:50 ` [PATCH 2/2] services: Move configuration functions that shouldn't be factorized Clément Lassieur
2017-03-01  9:53 ` [PATCH 0/2] Services configuration syntaxes patches Andy Wingo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170228225044.25315-1-clement@lassieur.org \
    --to=clement@lassieur.org \
    --cc=guix-devel@gnu.org \
    --cc=jmd@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.