From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 3/3] gnu: Add jacal. Date: Mon, 27 Feb 2017 19:31:11 -0500 Message-ID: <20170228003111.GB14214@jasmine> References: <1488138148-24017-1-git-send-email-jmd@gnu.org> <1488138148-24017-3-git-send-email-jmd@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:38117) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ciVhH-0001Cr-1m for guix-devel@gnu.org; Mon, 27 Feb 2017 19:31:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ciVhC-0003NI-5s for guix-devel@gnu.org; Mon, 27 Feb 2017 19:31:19 -0500 Content-Disposition: inline In-Reply-To: <1488138148-24017-3-git-send-email-jmd@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: John Darrington Cc: guix-devel@gnu.org On Sun, Feb 26, 2017 at 08:42:28PM +0100, John Darrington wrote: > * gnu/packages/maths.scm (jacal): New variable. > * gnu/packages/patches/jacal.texi.patch: New file. Can you rename the patch jacal-texi.patch (for consistency with the majority of the patches) and add a comment in the patch file explaining what it does? > + (replace 'configure > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (zero? (system* "./configure" > + (string-append "--prefix=" > + (assoc-ref outputs "out"))))))))) This can be done in #:configure-flags, right?