Re: 01/01: updated pioneers to latest version.

Re: 01/01: updated pioneers to latest version.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1043 bytes --]

On Sat, Feb 18, 2017 at 01:59:34PM -0500, Kei Kebreau wrote:
> kkebreau pushed a commit to branch master
> in repository guix.
> 
> commit 2f7eccc048de6526ef3f4c2de1c67ea0455ccb0c
> Author: Rodger Fox <thylakoid@openmailbox.org>
> Date:   Fri Feb 17 20:01:37 2017 -0800
> 
>     updated pioneers to latest version.
>     
>     Signed-off-by: Kei Kebreau <kei@openmailbox.org>

Thanks for the contribution Rodger!

For future patches, please note the section of the manual called
Submitting Patches. It briefly explains that we have a standard format
for commit messages, which this commit does not follow.

https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html#Submitting-Patches

For an example of how this commit message should have been written, see
this recent commit updating webkitgtk:

    gnu: webkitgtk: Update to 2.14.5.
    
    * gnu/packages/webkit.scm (webkitgtk): Update to 2.14.5.

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=42e721a13d6f47397e585f5909d140c4bafb4ad0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: 01/01: updated pioneers to latest version.

[Kei Kebreau]

[-- Attachment #1: Type: text/plain, Size: 1244 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Sat, Feb 18, 2017 at 01:59:34PM -0500, Kei Kebreau wrote:
>> kkebreau pushed a commit to branch master
>> in repository guix.
>> 
>> commit 2f7eccc048de6526ef3f4c2de1c67ea0455ccb0c
>> Author: Rodger Fox <thylakoid@openmailbox.org>
>> Date:   Fri Feb 17 20:01:37 2017 -0800
>> 
>>     updated pioneers to latest version.
>>     
>>     Signed-off-by: Kei Kebreau <kei@openmailbox.org>

For the record, I reverted this commit and pushed a correctly written one.
I don't know how much that matters.

>
> Thanks for the contribution Rodger!
>
> For future patches, please note the section of the manual called
> Submitting Patches. It briefly explains that we have a standard format
> for commit messages, which this commit does not follow.
>
> https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html#Submitting-Patches
>
> For an example of how this commit message should have been written, see
> this recent commit updating webkitgtk:
>
>     gnu: webkitgtk: Update to 2.14.5.
>     
>     * gnu/packages/webkit.scm (webkitgtk): Update to 2.14.5.
>
> https://git.savannah.gnu.org/cgit/guix.git/commit/?id=42e721a13d6f47397e585f5909d140c4bafb4ad0

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]