From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Lepiller Subject: Re: Icecat crash Date: Wed, 15 Feb 2017 23:12:45 +0100 Message-ID: <20170215231245.6ddf40c9@lepiller.eu> References: <20161226003450.24dcd472@scratchpost.org> <87tw9r796y.fsf@gmail.com> <20161226021519.GA30967@jasmine> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/rin4Z_pUyOK+cGYcsazAyyQ"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:48235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ce7pH-0001mr-HW for guix-devel@gnu.org; Wed, 15 Feb 2017 17:13:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ce7pD-0006ca-7o for guix-devel@gnu.org; Wed, 15 Feb 2017 17:13:27 -0500 Received: from dau94-h03-89-91-205-84.dsl.sta.abo.bbox.fr ([89.91.205.84]:43587 helo=skaro.lepiller.eu) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ce7pC-0006bV-L8 for guix-devel@gnu.org; Wed, 15 Feb 2017 17:13:23 -0500 Received: from localhost (localhost [127.0.0.1]) by skaro.lepiller.eu (Postfix) with ESMTP id 3676E7F8D1 for ; Wed, 15 Feb 2017 23:13:19 +0100 (CET) Received: from skaro.lepiller.eu ([127.0.0.1]) by localhost (lepiller.eu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3RvBXrZsIzUz for ; Wed, 15 Feb 2017 23:13:13 +0100 (CET) Received: from localhost (89-93-157-164.hfc.dyn.abo.bbox.fr [89.93.157.164]) by skaro.lepiller.eu (Postfix) with ESMTPSA id AC85E7FAE0 for ; Wed, 15 Feb 2017 23:13:12 +0100 (CET) In-Reply-To: <20161226021519.GA30967@jasmine> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: guix-devel@gnu.org --Sig_/rin4Z_pUyOK+cGYcsazAyyQ Content-Type: multipart/mixed; boundary="MP_/BxRYppB2cVgLmrPtAfoRt=P" --MP_/BxRYppB2cVgLmrPtAfoRt=P Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sun, 25 Dec 2016 21:15:19 -0500 Leo Famulari wrote: > On Sun, Dec 25, 2016 at 05:47:33PM -0800, Chris Marusich wrote: > > Danny Milosavljevic writes: =20 > > > so I've finally found a 100% reproducible way to crash icecat. > > > Previously it has been sporadic and not reproducible. > > > > > > Try going to this site in a new icecat (guix master) instance: > > > > > > http://arstechnica.com/security/2016/12/this-low-cost-device-may-be-t= he-worlds-best-hope-against-account-takeovers/ > > > > > > Scroll down. It will crash. Every time. =20 > >=20 > > This doesn't crash for me. Note that I have applied the "fix" for > > the previously observed "crashiness", as described here - perhaps > > that is why it doesn't crash for me: > >=20 > > https://lists.gnu.org/archive/html/help-guix/2016-11/msg00008.html =20 >=20 > Unfortunately for debugging purposes, this doesn't crash Icecat for me > either. I'm still using the Cairo rendering backend. >=20 > It's difficult to use a site like this as a reproducer, since every > user will get totally different content via the advertisements. >=20 > For the record, it also does not crash my Debian Firefox 45.5.1, which > uses uBlock Origin and Privacy Badger to block 1 and 9 domains, > respectively. >=20 > If you can still reproduce the crash, I think it's worth it to save > the entire web page, ads included, and share that if you're satisfied > there's no sensitive data included. Hey, I'm also experiencing crashes with icecat since a few months. It just seems to happen randomly. I've found a note about that on the LFS website on the firefox page that says that using system cairo is causing a crash when it tries to do background rendering. So I've changed our icecat recipe to use the bundled version of cairo, and I don't get any crash anymore. Would something like this patch be acceptable? --MP_/BxRYppB2cVgLmrPtAfoRt=P Content-Type: text/x-patch Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=0001-gnu-icecat-Fix-random-crashes.patch =46rom 89a121bab987caef7f0fbe0f5e24085c3ccae42d Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Tue, 14 Feb 2017 20:59:15 +0100 Subject: [PATCH] gnu: icecat: Fix random crashes. gnu/packages/gnuzilla.scm (icecat): Remove cairo dependency to fix crashes. --- gnu/packages/gnuzilla.scm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm index 9279c46b5..90655fd76 100644 --- a/gnu/packages/gnuzilla.scm +++ b/gnu/packages/gnuzilla.scm @@ -404,6 +404,8 @@ standards.") ;; ;; ;; TODO: Use system graphite2. + ;; TODO: Use system cairo. This currently causes ran= dom + ;; crash when icecat does background rendering. ;; "modules/freetype2" "modules/zlib" @@ -412,7 +414,6 @@ standards.") "media/libjpeg" "media/libvpx" "security/nss" - "gfx/cairo" "js/src/ctypes/libffi" "db/sqlite3")) ;; Delete .pyc files, typically present in icecat source tarballs @@ -426,7 +427,6 @@ standards.") (inputs `(("alsa-lib" ,alsa-lib) ("bzip2" ,bzip2) - ("cairo" ,cairo) ("cups" ,cups) ("dbus-glib" ,dbus-glib) ("gdk-pixbuf" ,gdk-pixbuf) @@ -511,7 +511,6 @@ standards.") "--with-system-nspr" "--with-system-nss" "--enable-system-pixman" - "--enable-system-cairo" "--enable-system-ffi" "--enable-system-hunspell" "--enable-system-sqlite" --=20 2.11.1 --MP_/BxRYppB2cVgLmrPtAfoRt=P-- --Sig_/rin4Z_pUyOK+cGYcsazAyyQ Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEtfrmKFtBNyiyoPrtQxEfRSAIagwFAlik0l0ACgkQQxEfRSAI agyEqg//dK+Ujz2FLY9p+Dop4ST9ZNYaKglx2hHNkjR03z0qeXWgu16YsJ+/D6d6 RFqh9xSpZsA4Gxn6qZ10l6FWEeMFf6tvjnC/+OQClwiwHIYuo8LL4+F45PF7fZN9 V7FPgq5pjP9rB1kInJ+8TE78Rrx7alt5LmCySyEEZ310nvRmqJVlB9xHt7Qyf2Eg 6AikXMhE3T4GTBn3LvgfoypLAbZ+1EZ+ay/fWfWriZcKiS2W7bMD9WoIvuywDkkq ZONAqWHcxh+9sxtd86iZvVcyeA3TCiEY0rERImBwe+PjtZ6sowA9AY+DCoECiLuU WHwxF92eT89GHdrsWRxoAZRCBlGnr+xwITHVfGqbWnI3jNpDlMFuT1RzWT0BOHWy QK9OBJjXMz8/kNkmNFFb9rpctpAUuid/r6qKxChG0DEG3CJ8Qfi9uwFEPuoW3x8b E9YaZ+TIeMn56DmD3/opWQA2OTwoioS23c8hpBA2GrRXyoPbGQH+n9vfAXIAcDLu eY4lGo3Dy71T9Qggiudq6UYHIG3IDlUkDP5zM3SoIHqbsFlwymBtatsfvd5BP62u Gxscq+jtIhDppGtlMg4UUrjcKEYpLzrgnF3usvhwQjIuDnTGo1OpPkWjOroMWCQ9 Mh3/drs/ViiaTsPeR/tKBya+tHHJyHt0Sk0V0WmYJSgD1bS4qKw= =N8ma -----END PGP SIGNATURE----- --Sig_/rin4Z_pUyOK+cGYcsazAyyQ--