wrt git-exec-path patch

wrt git-exec-path patch

[ng0]

Why was this patch necessary? I only face troubles with it.

Fixed is now "git rebase" after someone in IRC told me to unset
GIT_EXEC_PATH, but git send-email is now "not a git command".

This is on GuixSD.


commit 82de2655a16dcc7a8e3b992b4afd34ec32c244a6
Author: David Craven <david@craven.ch>
Date:   Fri Feb 10 12:21:08 2017 +0100

    gnu: git: Add GIT_EXEC_PATH search-path-specification.
    
    Enables git plugins to be found when in they're in the system profile.
    
    * gnu/packages/version-control.scm (git)[native-search-paths]: Add
      GIT_EXEC_PATH.  Remove git wrapper and outdated comment.



-- 
ng0 -- https://www.inventati.org/patternsinthechaos/

Re: wrt git-exec-path patch

[ng0]

On 17-02-15 22:26:48, ng0 wrote:
> Why was this patch necessary? I only face troubles with it.
> 
> Fixed is now "git rebase" after someone in IRC told me to unset
> GIT_EXEC_PATH, but git send-email is now "not a git command".
> 
> This is on GuixSD.
> 
> 
> commit 82de2655a16dcc7a8e3b992b4afd34ec32c244a6
> Author: David Craven <david@craven.ch>
> Date:   Fri Feb 10 12:21:08 2017 +0100
> 
>     gnu: git: Add GIT_EXEC_PATH search-path-specification.
>     
>     Enables git plugins to be found when in they're in the system profile.
>     
>     * gnu/packages/version-control.scm (git)[native-search-paths]: Add
>       GIT_EXEC_PATH.  Remove git wrapper and outdated comment.
> 

The recommendation was to export this:

export GIT_EXEC_PATH="/home/ng0/.guix-profile/libexec/git-core${GIT_EXEC_PATH:+:}$GIT_EXEC_PATH"

Afterwards, this is what leads to my error:

ng0@wasp ~> cd src/guix/guix/
ng0@wasp ~/s/g/guix> torify git pull upstream master --rebase
From git://git.savannah.gnu.org/guix
 * branch                master     -> FETCH_HEAD
/home/ng0/.guix-profile/libexec/git-core/git-sh-setup: line 46: /home/ng0/.guix-profile/libexec/git-core:/gnu/store/bbirr7a14463ahl3m378rwv5px4h2lk0-profile/libexec/git-core:/home/ng0/.guix-profile/libexec/git-core:/gnu/store/bbirr7a14463ahl3m378rwv5px4h2lk0-profile/libexec/git-core:/home/ng0/.guix-profile/libexec/git-core/git-sh-i18n: No such file or directory



And when I unset GIT_EXEC_PATH, I can at least use --rebase, but I can't
use git send-email.

If there's no solution or explanation, my advice is to revert this.

Re: wrt git-exec-path patch

[Leo Famulari]

On Mon, Feb 20, 2017 at 08:59:23PM +0000, ng0 wrote:
> export GIT_EXEC_PATH="/home/ng0/.guix-profile/libexec/git-core${GIT_EXEC_PATH:+:}$GIT_EXEC_PATH"

GIT_EXEC_PATH is not really a search path. Instead, it must point to a
single path.

This works for me:
/home/leo/.guix-profile/libexec/git-core

> If there's no solution or explanation, my advice is to revert this.

Perhaps, or we should make the recommendation show the correct path. Or
patch this path internally while building Git, if possible.

Re: wrt git-exec-path patch

[ng0]

On 17-02-20 16:07:27, Leo Famulari wrote:
> On Mon, Feb 20, 2017 at 08:59:23PM +0000, ng0 wrote:
> > export GIT_EXEC_PATH="/home/ng0/.guix-profile/libexec/git-core${GIT_EXEC_PATH:+:}$GIT_EXEC_PATH"
> 
> GIT_EXEC_PATH is not really a search path. Instead, it must point to a
> single path.
> 
> This works for me:
> /home/leo/.guix-profile/libexec/git-core

Okay, this fixed it for me, thanks!

> > If there's no solution or explanation, my advice is to revert this.
> 
> Perhaps, or we should make the recommendation show the correct path. Or
> patch this path internally while building Git, if possible.
>