* [PATCH v2] build: dub-build-system: Don't use "dub run" at all.
@ 2017-02-13 16:29 Danny Milosavljevic
2017-02-14 8:53 ` Ludovic Courtès
0 siblings, 1 reply; 3+ messages in thread
From: Danny Milosavljevic @ 2017-02-13 16:29 UTC (permalink / raw)
To: guix-devel
It doesn't make sense to run non-test executables (which is what "dub run"
would do).
The "check" function already invokes "dub test" and that's enough.
* guix/build/dub-build-system.scm (build): Remove "dub run" invocation.
---
guix/build/dub-build-system.scm | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/guix/build/dub-build-system.scm b/guix/build/dub-build-system.scm
index 7c7cd8803..b2cb02e63 100644
--- a/guix/build/dub-build-system.scm
+++ b/guix/build/dub-build-system.scm
@@ -91,9 +91,7 @@
(grep* "sourceLibrary" "dub.sdl") ; note: format is different!
(grep* "sourceLibrary" "dub.json"))
#t
- (let ((status (zero? (apply system* `("dub" "build" ,@dub-build-flags)))))
- (system* "dub" "run") ; might fail for "targetType": "library"
- status)))
+ (zero? (apply system* `("dub" "build" ,@dub-build-flags)))))
(define* (check #:key tests? #:allow-other-keys)
(if tests?
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] build: dub-build-system: Don't use "dub run" at all.
2017-02-13 16:29 [PATCH v2] build: dub-build-system: Don't use "dub run" at all Danny Milosavljevic
@ 2017-02-14 8:53 ` Ludovic Courtès
2017-02-14 9:20 ` Danny Milosavljevic
0 siblings, 1 reply; 3+ messages in thread
From: Ludovic Courtès @ 2017-02-14 8:53 UTC (permalink / raw)
To: Danny Milosavljevic; +Cc: guix-devel
Danny Milosavljevic <dannym@scratchpost.org> skribis:
> It doesn't make sense to run non-test executables (which is what "dub run"
> would do).
>
> The "check" function already invokes "dub test" and that's enough.
>
> * guix/build/dub-build-system.scm (build): Remove "dub run" invocation.
Perfect, thank you!
Ludo’.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] build: dub-build-system: Don't use "dub run" at all.
2017-02-14 8:53 ` Ludovic Courtès
@ 2017-02-14 9:20 ` Danny Milosavljevic
0 siblings, 0 replies; 3+ messages in thread
From: Danny Milosavljevic @ 2017-02-14 9:20 UTC (permalink / raw)
To: guix-devel
Pushed to master, commit 80345600faae388f508822818adfc990b1ebac66.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-14 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-13 16:29 [PATCH v2] build: dub-build-system: Don't use "dub run" at all Danny Milosavljevic
2017-02-14 8:53 ` Ludovic Courtès
2017-02-14 9:20 ` Danny Milosavljevic
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.