Broken tests

Broken tests

[David Craven]

Hi!

> Revert "import: json: Explicitly ask for JSON data."
> This reverts commit 81e0bc1834490a1a8092c75a0733b15c2b407285.

I reverted this commit in my local repository for now, it breaks the
pypi, crate and some other test I can't recall (gem and/or cpan).

David

Re: Broken tests

[Federico Beffa]

On Sat, Feb 11, 2017 at 6:15 PM, David Craven <david@craven.ch> wrote:
> Hi!
>
>> Revert "import: json: Explicitly ask for JSON data."
>> This reverts commit 81e0bc1834490a1a8092c75a0733b15c2b407285.
>
> I reverted this commit in my local repository for now, it breaks the
> pypi, crate and some other test I can't recall (gem and/or cpan).

The importers seems to be working as before. I believe that the
problem is with the tests. They replace the function 'http-fetch', but
do not replicate the signature of the original function and instead
use a different one.

Re: Broken tests

[Ludovic Courtès]

Hello,

Federico Beffa <beffa@ieee.org> skribis:

> On Sat, Feb 11, 2017 at 6:15 PM, David Craven <david@craven.ch> wrote:
>> Hi!
>>
>>> Revert "import: json: Explicitly ask for JSON data."
>>> This reverts commit 81e0bc1834490a1a8092c75a0733b15c2b407285.
>>
>> I reverted this commit in my local repository for now, it breaks the
>> pypi, crate and some other test I can't recall (gem and/or cpan).
>
> The importers seems to be working as before. I believe that the
> problem is with the tests. They replace the function 'http-fetch', but
> do not replicate the signature of the original function and instead
> use a different one.

Indeed.  Fixed in ce8963c5b7a728257920aeceeb89e40d166d09f4.

Please make sure to run the test suite before changing non-package code.

In general, I think we can agree on reverting changes that break the
tests until a solution is proposed (and once the original author has
been notified, of course).  That sounds like reasonable policy to me.

Thoughts?

Ludo’.

Re: Broken tests

[Leo Famulari]

On Mon, Feb 13, 2017 at 04:08:00PM +0100, Ludovic Courtès wrote:
> In general, I think we can agree on reverting changes that break the
> tests until a solution is proposed (and once the original author has
> been notified, of course).  That sounds like reasonable policy to me.
> 
> Thoughts?

I agree.

Re: Broken tests

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

On Sat, Feb 11, 2017 at 06:15:08PM +0100, David Craven wrote:
     Hi!
     
     > Revert "import: json: Explicitly ask for JSON data."
     > This reverts commit 81e0bc1834490a1a8092c75a0733b15c2b407285.
     
     I reverted this commit in my local repository for now, it breaks the
     pypi, crate and some other test I can't recall (gem and/or cpan).
     
     David

Yes, I noticed the same problem and similarly had to revert locally.

J'

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]