[PATCH] gnu: Add tftp-hpa.

[PATCH] gnu: Add tftp-hpa.

[Boskovits, Gábor]

From: Boskovits,Gábor <boskovits@gmail.com>

---
 gnu/packages/tftp-hpa.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 gnu/packages/tftp-hpa.scm

diff --git a/gnu/packages/tftp-hpa.scm b/gnu/packages/tftp-hpa.scm
new file mode 100644
index 000000000..469123b67
--- /dev/null
+++ b/gnu/packages/tftp-hpa.scm
@@ -0,0 +1,27 @@
+(define-module (gnu packages tftp-hpa)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix licenses))
+
+(define-public tftp-hpa
+  (package
+    (name "tftp-hpa")
+    (version "5.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://www.kernel.org/pub/software/"
+                                  "network/tftp/tftp-hpa/tftp-hpa-" version
+                                  ".tar.xz"))
+              (sha256
+               (base32
+                "12vidchglhyc20znq5wdsbhi9mqg90jnl7qr9qs8hbvaz4fkdvmg"))))
+    (build-system gnu-build-system)
+    (arguments `(#:tests? #f)) ; no test target
+    (synopsis "HPA's tftp client")
+    (description
+     "This is a tftp client derived from OpenBSD tftp with some extra options
+added and bugs fixed.  The source includes readline support but it is not
+enabled due to licence conflicts between the BSD advertising clause and the GPL.")
+    (home-page "http://git.kernel.org/cgit/network/tftp/tftp-hpa.git/about/")
+    (license bsd-4)))
-- 
2.11.0

Re: [PATCH] gnu: Add tftp-hpa.

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 2028 bytes --]

Hello!

Sorry for my english!

This will be the my first contribution, so i hope all went well.

I would like to get some assistance in selecting a category for this
package.

Should it be networking, or something else?

I would be glad if someone could also verify if my licese selection is
correct.

2017-02-06 0:33 GMT+01:00 Boskovits, Gábor <boskovits@gmail.com>:

> From: Boskovits,Gábor <boskovits@gmail.com>
>
> ---
>  gnu/packages/tftp-hpa.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 gnu/packages/tftp-hpa.scm
>
> diff --git a/gnu/packages/tftp-hpa.scm b/gnu/packages/tftp-hpa.scm
> new file mode 100644
> index 000000000..469123b67
> --- /dev/null
> +++ b/gnu/packages/tftp-hpa.scm
> @@ -0,0 +1,27 @@
> +(define-module (gnu packages tftp-hpa)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix licenses))
> +
> +(define-public tftp-hpa
> +  (package
> +    (name "tftp-hpa")
> +    (version "5.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://www.kernel.org/pub/software/"
> +                                  "network/tftp/tftp-hpa/tftp-hpa-"
> version
> +                                  ".tar.xz"))
> +              (sha256
> +               (base32
> +                "12vidchglhyc20znq5wdsbhi9mqg90
> jnl7qr9qs8hbvaz4fkdvmg"))))
> +    (build-system gnu-build-system)
> +    (arguments `(#:tests? #f)) ; no test target
> +    (synopsis "HPA's tftp client")
> +    (description
> +     "This is a tftp client derived from OpenBSD tftp with some extra
> options
> +added and bugs fixed.  The source includes readline support but it is not
> +enabled due to licence conflicts between the BSD advertising clause and
> the GPL.")
> +    (home-page "http://git.kernel.org/cgit/network/tftp/tftp-hpa.git/
> about/")
> +    (license bsd-4)))
> --
> 2.11.0
>
>

[-- Attachment #2: Type: text/html, Size: 2984 bytes --]

Re: [PATCH] gnu: Add tftp-hpa.

[Thomas Danckaert]

From: Boskovits, Gábor <boskovits@gmail.com>
Subject: [PATCH] gnu: Add tftp-hpa.
Date: Mon,  6 Feb 2017 00:33:31 +0100

> ---
>  gnu/packages/tftp-hpa.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)

Hi!

I tested the patch and the package builds fine.

> +    (description
> +     "This is a tftp client derived from OpenBSD tftp with some 
> extra options
> +added and bugs fixed.  The source includes readline support but it 
> is not
> +enabled due to licence conflicts between the BSD advertising 
> clause and the GPL.")

“licence”->“license”

> [...]
> I would like to get some assistance in selecting a category for this
> package.

I'll let someone else comment on this :).

> Should it be networking, or something else?
>
> I would be glad if someone could also verify if my licese selection
> is correct.

Af for the license issues: I think bsd-4 is correct, but about the 
disabled GPL code: I think you can actually distribute a combined 
work of GPL and BSD as GPL, as long as you specify that the BSD parts 
of it are also BSD-licensed?  In the package's license field, you 
could say "(license (list gpl1 bsd-4))"

If you send an updated patch, you will also be asked to follow the 
gnu commit message guidelines (take a look at the log for 
inspiration).  Your commit title would be  something like “gnu: Add 
tftp-hpa.” and the body will mention the new variable.

cheers,

Thomas

[PATCH] gnu: Add tftp-hpa.

[Boskovits, Gábor]

* gnu/packages/tftp-hpa.scm: New file.
---
 gnu/packages/tftp-hpa.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 gnu/packages/tftp-hpa.scm

diff --git a/gnu/packages/tftp-hpa.scm b/gnu/packages/tftp-hpa.scm
new file mode 100644
index 000000000..44a008698
--- /dev/null
+++ b/gnu/packages/tftp-hpa.scm
@@ -0,0 +1,27 @@
+(define-module (gnu packages tftp-hpa)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix licenses))
+
+(define-public tftp-hpa
+  (package
+    (name "tftp-hpa")
+    (version "5.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://www.kernel.org/pub/software/"
+                                  "network/tftp/tftp-hpa/tftp-hpa-" version
+                                  ".tar.xz"))
+              (sha256
+               (base32
+                "12vidchglhyc20znq5wdsbhi9mqg90jnl7qr9qs8hbvaz4fkdvmg"))))
+    (build-system gnu-build-system)
+    (arguments `(#:tests? #f)) ; no test target
+    (synopsis "HPA's tftp client")
+    (description
+     "This is a tftp client derived from OpenBSD tftp with some extra options
+added and bugs fixed.  The source includes readline support but it is not
+enabled due to license conflicts between the BSD advertising clause and the GPL.")
+    (home-page "http://git.kernel.org/cgit/network/tftp/tftp-hpa.git/about/")
+    (license (list gpl1 bsd-4))))
-- 
2.11.0

Re: [PATCH] gnu: Add tftp-hpa.

[Gábor Boskovits]

[-- Attachment #1: Type: text/plain, Size: 2453 bytes --]

Hello!

#1 A post on the list cought my attention regarding security of packages
with both server and client. I think that should also apply to this package.
I am waiting for follow ups on that.
#2 I have discussed the licensing issues with Thomas Danckaert, but waiting
for confirmation wether the licence is correct now.
I will try to contact upstream, if they consider relicensing the
contribution under isc.
#3 I am still waiting for assistance regading the category of this package.
My candidtates: networking, ftp (but this is tftp),admin (because isc-dhcp
is there) or maybe something like network-infrastucture. I have seen
dnsmasq in dns, which also provides tftp, but I don't think this package
belongs to dns.

2017-02-06 23:58 GMT+01:00 Boskovits, Gábor <boskovits@gmail.com>:

> * gnu/packages/tftp-hpa.scm: New file.
> ---
>  gnu/packages/tftp-hpa.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 gnu/packages/tftp-hpa.scm
>
> diff --git a/gnu/packages/tftp-hpa.scm b/gnu/packages/tftp-hpa.scm
> new file mode 100644
> index 000000000..44a008698
> --- /dev/null
> +++ b/gnu/packages/tftp-hpa.scm
> @@ -0,0 +1,27 @@
> +(define-module (gnu packages tftp-hpa)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (guix licenses))
> +
> +(define-public tftp-hpa
> +  (package
> +    (name "tftp-hpa")
> +    (version "5.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://www.kernel.org/pub/software/"
> +                                  "network/tftp/tftp-hpa/tftp-hpa-"
> version
> +                                  ".tar.xz"))
> +              (sha256
> +               (base32
> +                "12vidchglhyc20znq5wdsbhi9mqg90
> jnl7qr9qs8hbvaz4fkdvmg"))))
> +    (build-system gnu-build-system)
> +    (arguments `(#:tests? #f)) ; no test target
> +    (synopsis "HPA's tftp client")
> +    (description
> +     "This is a tftp client derived from OpenBSD tftp with some extra
> options
> +added and bugs fixed.  The source includes readline support but it is not
> +enabled due to license conflicts between the BSD advertising clause and
> the GPL.")
> +    (home-page "http://git.kernel.org/cgit/network/tftp/tftp-hpa.git/
> about/")
> +    (license (list gpl1 bsd-4))))
> --
> 2.11.0
>
>

[-- Attachment #2: Type: text/html, Size: 3601 bytes --]

Re: [PATCH] gnu: Add tftp-hpa.

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1507 bytes --]

On Sun, Feb 12, 2017 at 03:05:20PM +0100, Gábor Boskovits wrote:
> Hello!

Hi, thanks for the contribution! Sorry for the sloooow reply.

I added the package in commit 5b5cf3c7659ee33bb981135708929c8f0a46aec8

> #1 A post on the list cought my attention regarding security of packages
> with both server and client. I think that should also apply to this package.
> I am waiting for follow ups on that.

For now, I committed the package with the client and server together.

> #2 I have discussed the licensing issues with Thomas Danckaert, but waiting
> for confirmation wether the licence is correct now.
> I will try to contact upstream, if they consider relicensing the
> contribution under isc.

Some of source files are 3-clause BSD, some are 4-clause BSD. You
mentioned that there is some readline functionality but that it's
disabled. The only files distributed under the GPL in this package are
the autotools build scripts, and we don't usually mention those in the
list of licenses. So, I put bsd-3 and bsd-4 in the license field. If
I've made a mistake, we'll correct it :)

> #3 I am still waiting for assistance regading the category of this package.
> My candidtates: networking, ftp (but this is tftp),admin (because isc-dhcp
> is there) or maybe something like network-infrastucture. I have seen
> dnsmasq in dns, which also provides tftp, but I don't think this package
> belongs to dns.

I put it in (gnu packages networking), which I think is good enough.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] gnu: Add tftp-hpa.

[Thomas Danckaert]

<20170206225825.23935-1-boskovits@gmail.com>
X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: base64

SGkgTGVvIGFuZCBHw6Fib3IsDQoNCkkganVzdCB0aG91Z2h0IG9mIHRoaXMgcGF0Y2ggYWdhaW4g
dG9kYXksIGJ1dCBMZW8gYmVhdCBtZSB0byBpdC4NCg0KSSd2ZSBsb29rZWQgaW50byB0aGUgbGlj
ZW5zaW5nIGEgYml0IG1vcmUuICBUaGUgQlNEIGFkdmVydGlzaW5nIGlzc3VlIA0Kc2VlbXMgdG8g
YmUgYSBtaXN1bmRlcnN0YW5kaW5nIG9uIHRoZSBwYXJ0IG9mIERlYmlhbiwgYXQgbGVhc3QgYXMg
ZmFyIA0KYXMgdGhlIGF1dGhvciBpcyBjb25jZXJuZWQ6DQpodHRwOi8vd3d3LnN5c2xpbnV4Lm9y
Zy9hcmNoaXZlcy8yMDAzLUphbnVhcnkvMDAxNDg0Lmh0bWwNCg0KU28sIHRoZXJlJ3Mgbm8gY2xl
YXIgbGljZW5zZSBzdGF0ZW1lbnQgaW5jbHVkZWQgaW4gdGhlIHBhY2thZ2UgDQpzb3VyY2UsIGJ1
dCB0aGUgYXV0aG9yJ3MgaW50ZW50aW9uIGlzIHRvIGRpc3RyaWJ1dGUgdGhlIGNvZGUgdW5kZXIg
YSANCnBlcm1pc3NpdmUgbGljZW5zZSwgd2l0aG91dCBhZHZlcnRpc2luZyBjbGF1c2UuICAgSSB0
aGluayB3ZSBjYW4gdXNlIA0KKGxpY2Vuc2Ugbm9uLWNvcHlsZWZ0KT8NCg0KV2l0aG91dCB0aGUg
QlNEIGFkdmVydGlzaW5nIGlzc3VlcywgbGlua2luZyB3aXRoIHJlYWRsaW5lIHNob3VsZCBub3Qg
DQpiZSBhIHByb2JsZW0gZWl0aGVyLCBzbyB3ZSBjYW4gaW5jbHVkZSByZWFkbGluZSBhcyBhbiBp
bnB1dCwgYW5kIA0KcmVtb3ZlIHN0YXRlbWVudHMgYWJvdXQgcmVhZGxpbmUgZnJvbSB0aGUgZGVz
Y3JpcHRpb24gKEkgdGhpbmsgdGhlIA0KZGVzY3JpcHRpb24gY29tZXMgZnJvbSB0aGUgRGViaWFu
L1VidW50dSBwYWNrYWdlIHJlcG9zaXRvcmllcz8pLiAgV2UgDQpjb3VsZCByZXVzZSB0aGUgZGVz
Y3JpcHRpb24gZnJvbSANCmh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9uZXR3b3JrL3Rm
dHAvdGZ0cC1ocGEuZ2l0L2Fib3V0LCANCnNvbWV0aGluZyBsaWtlOg0KDQogICAgICAidGZ0cC1o
cGEgaXMgYSBjb25nbG9tZXJhdGUgb2YgYSBudW1iZXIgb2YgdmVyc2lvbnMgb2YgdGhlIEJTRCAN
ClRGVFAgY29kZSwNCmNoYW5nZWQgYXJvdW5kIHRvIHBvcnQgdG8gYSB3aG9sZSBjb2xsZWN0aW9u
IG9mIG9wZXJhdGluZyBzeXN0ZW1zLiAgDQpUaGUgZ29hbA0KaXMgdG8gd29yayBvbiBhbnkgcmVh
c29uYWJseSBtb2Rlcm4gVW5peCB3aXRoIHNvY2tldHMuIg0KDQpXRFlUPw0KDQpUaG9tYXMNCg==

Re: [PATCH] gnu: Add tftp-hpa.

[Thomas Danckaert]

(sorry, something went wrong with my message there)

Hi Leo and Gábor,

I just thought of this patch again today, but Leo beat me to it.

I've looked into the licensing a bit more.  The BSD advertising
issue seems to be a misunderstanding on the part of Debian, at least
as far as the author is concerned:
http://www.syslinux.org/archives/2003-January/001484.html

So, there's no clear license statement included in the package
source, but the author's intention is to distribute the code under a
permissive license, without advertising clause.  I think we can use
(license non-copyleft)?

Without the BSD advertising issues, linking with readline should not
be a problem either, so we can include readline as an input, and
remove statements about readline from the description (I think the
description comes from the Debian/Ubuntu package repositories?).  We
could reuse the description from
https://git.kernel.org/pub/scm/network/tftp/tftp-hpa.git/about,
something like:

     "tftp-hpa is a conglomerate of a number of versions of the BSD
     TFTP code, changed around to port to a whole collection of
     operating systems.  The goal is to work on any reasonably modern
     Unix with sockets."

WDYT?

Thomas