[PATCH] gnu: new re2c package, version 0.16

[PATCH] gnu: new re2c package, version 0.16

[Sergei Trofimovich]

Tested on x86_64-linux and i686-linux.

* gnu/local.mk: add re2c.scm to dist
* gnu/packages/re2c.scm: new file

Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
---
 gnu/local.mk          |  1 +
 gnu/packages/re2c.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 gnu/packages/re2c.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 0948321c9..5c1634e02 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -318,6 +318,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/ratpoison.scm			\
   %D%/packages/rdesktop.scm			\
   %D%/packages/rdf.scm				\
+  %D%/packages/re2c.scm				\
   %D%/packages/readline.scm			\
   %D%/packages/regex.scm				\
   %D%/packages/rrdtool.scm			\
diff --git a/gnu/packages/re2c.scm b/gnu/packages/re2c.scm
new file mode 100644
index 000000000..7c5698a82
--- /dev/null
+++ b/gnu/packages/re2c.scm
@@ -0,0 +1,47 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2017 Sergei Trofimovich <slyfox@inbox.ru>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages re2c)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu))
+
+(define-public re2c
+  (package
+    (name "re2c")
+    (version "0.16")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "https://github.com/skvadrik/" name
+                                 "/releases/download/" version "/"
+                                 name "-" version ".tar.gz"))
+             (sha256
+              (base32
+               "114y0s4vmzip4hkf4cbz4yv8s498gzaylnphbzmwqhbn55j2bha8"))))
+    (build-system gnu-build-system)
+    (home-page "http://re2c.org/")
+    (synopsis "Lexer generator for C/C++")
+    (description
+     "re2c generates minimalistic hard-coded state machine (as opposed to
+full-featured table-based lexers).  Flexible API allows generated code to
+be wired into virtually any environment.  Instead of exposing traditional
+yylex() style API, re2c exposes its internals.  Be sure to take a look at
+examples, they cover a lot of real-world cases and shed some light on dark
+corners of re2c API.")
+    (license public-domain)))
-- 
2.11.1

Re: [PATCH] gnu: new re2c package, version 0.16

[ng0]

On 17-02-04 17:43:23, Sergei Trofimovich wrote:
> Tested on x86_64-linux and i686-linux.
> 
> * gnu/local.mk: add re2c.scm to dist
> * gnu/packages/re2c.scm: new file

Cool! I had the same package somewhere, thanks for publishing yours :)
I think there's already a module this could go into. If there isn't (I
will check tomorrow), what about a more generic name which could hold a
class of applications? Just an idea.

I haven't run the code, these are just my initial remarks. Overall it
looks good, so the only criticism is really in the (description).
 
> Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
> ---
>  gnu/local.mk          |  1 +
>  gnu/packages/re2c.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 gnu/packages/re2c.scm
> 
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 0948321c9..5c1634e02 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -318,6 +318,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/ratpoison.scm			\
>    %D%/packages/rdesktop.scm			\
>    %D%/packages/rdf.scm				\
> +  %D%/packages/re2c.scm				\
>    %D%/packages/readline.scm			\
>    %D%/packages/regex.scm				\
>    %D%/packages/rrdtool.scm			\
> diff --git a/gnu/packages/re2c.scm b/gnu/packages/re2c.scm
> new file mode 100644
> index 000000000..7c5698a82
> --- /dev/null
> +++ b/gnu/packages/re2c.scm
> @@ -0,0 +1,47 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2017 Sergei Trofimovich <slyfox@inbox.ru>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages re2c)
> +  #:use-module (guix licenses)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu))
> +
> +(define-public re2c
> +  (package
> +    (name "re2c")
> +    (version "0.16")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append "https://github.com/skvadrik/" name
> +                                 "/releases/download/" version "/"
> +                                 name "-" version ".tar.gz"))
> +             (sha256
> +              (base32
> +               "114y0s4vmzip4hkf4cbz4yv8s498gzaylnphbzmwqhbn55j2bha8"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://re2c.org/")
> +    (synopsis "Lexer generator for C/C++")
> +    (description
> +     "re2c generates minimalistic hard-coded state machine (as opposed to

I think the beginning should be "Re2c (...)" or "@code{re2c} (...)"

> +full-featured table-based lexers).  Flexible API allows generated code to
> +be wired into virtually any environment.  Instead of exposing traditional
> +yylex() style API, re2c exposes its internals.  Be sure to take a look at

I'm not sure, but I think the "yylex()" will have to be written as
@code{yylex()} or something similar.

> +examples, they cover a lot of real-world cases and shed some light on dark
> +corners of re2c API.")

I think "corners of the re2c API." would be correct?

> +    (license public-domain)))
> -- 
> 2.11.1
> 
> 

-- 
ng0 -- https://www.inventati.org/patternsinthechaos/

[PATCH v2] gnu: new re2c package, version 0.16

[Sergei Trofimovich]

Tested on x86_64-linux and i686-linux.

* gnu/local.mk: add re2c.scm to dist
* gnu/packages/re2c.scm: new file

CC: ng0 <contact.ng0@cryptolab.net>
Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
---
Change since v1: texinfo-ified descriotion as suggested by ng0

 gnu/local.mk          |  1 +
 gnu/packages/re2c.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 48 insertions(+)
 create mode 100644 gnu/packages/re2c.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 0948321c9..5c1634e02 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -318,6 +318,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/ratpoison.scm			\
   %D%/packages/rdesktop.scm			\
   %D%/packages/rdf.scm				\
+  %D%/packages/re2c.scm				\
   %D%/packages/readline.scm			\
   %D%/packages/regex.scm				\
   %D%/packages/rrdtool.scm			\
diff --git a/gnu/packages/re2c.scm b/gnu/packages/re2c.scm
new file mode 100644
index 000000000..c7f296638
--- /dev/null
+++ b/gnu/packages/re2c.scm
@@ -0,0 +1,47 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2017 Sergei Trofimovich <slyfox@inbox.ru>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages re2c)
+  #:use-module (guix licenses)
+  #:use-module (guix packages)
+  #:use-module (guix download)
+  #:use-module (guix build-system gnu))
+
+(define-public re2c
+  (package
+    (name "re2c")
+    (version "0.16")
+    (source (origin
+             (method url-fetch)
+             (uri (string-append "https://github.com/skvadrik/" name
+                                 "/releases/download/" version "/"
+                                 name "-" version ".tar.gz"))
+             (sha256
+              (base32
+               "114y0s4vmzip4hkf4cbz4yv8s498gzaylnphbzmwqhbn55j2bha8"))))
+    (build-system gnu-build-system)
+    (home-page "http://re2c.org/")
+    (synopsis "Lexer generator for C/C++")
+    (description
+     "@code{re2c} generates minimalistic hard-coded state machine (as opposed
+to full-featured table-based lexers).  Flexible API allows generated code
+to be wired into virtually any environment.  Instead of exposing traditional
+@code{yylex()} style API, re2c exposes its internals.  Be sure to take a look
+at examples, they cover a lot of real-world cases and shed some light on dark
+corners of re2c API.")
+    (license public-domain)))
-- 
2.11.1

Re: [PATCH] gnu: new re2c package, version 0.16

[Sergei Trofimovich]

[-- Attachment #1: Type: text/plain, Size: 1643 bytes --]

On Sun, 5 Feb 2017 00:47:30 +0000
ng0 <contact.ng0@cryptolab.net> wrote:

> On 17-02-04 17:43:23, Sergei Trofimovich wrote:
> > Tested on x86_64-linux and i686-linux.
> > 
> > * gnu/local.mk: add re2c.scm to dist
> > * gnu/packages/re2c.scm: new file  
> 
> Cool! I had the same package somewhere, thanks for publishing yours :)
> I think there's already a module this could go into. If there isn't (I
> will check tomorrow), what about a more generic name which could hold a
> class of applications? Just an idea.

I mimicked flex which resides in standalone flex.scm.

> I haven't run the code, these are just my initial remarks. Overall it
> looks good, so the only criticism is really in the (description).

> I think the beginning should be "Re2c (...)" or "@code{re2c} (...)"
> 
> > +full-featured table-based lexers).  Flexible API allows generated code to
> > +be wired into virtually any environment.  Instead of exposing traditional
> > +yylex() style API, re2c exposes its internals.  Be sure to take a look at  

Fixed in v2 patch.

> I'm not sure, but I think the "yylex()" will have to be written as
> @code{yylex()} or something similar.
> 
> > +examples, they cover a lot of real-world cases and shed some light on dark
> > +corners of re2c API.")  

Fixed in v2 patch.

> I think "corners of the re2c API." would be correct?

Author's spelling:
    https://raw.githubusercontent.com/skvadrik/re2c/gh-pages-gen/src/index.rst

I'm not sure which is right:
    http://english.stackexchange.com/questions/10020/definite-article-before-schools-colleges-and-universities

-- 

  Sergei

[-- Attachment #2: Цифровая подпись OpenPGP --]
[-- Type: application/pgp-signature, Size: 163 bytes --]

Re: [PATCH] gnu: new re2c package, version 0.16

[ng0]

On 17-02-05 10:55:59, Sergei Trofimovich wrote:
> On Sun, 5 Feb 2017 00:47:30 +0000
> ng0 <contact.ng0@cryptolab.net> wrote:
> 
> > On 17-02-04 17:43:23, Sergei Trofimovich wrote:
> > > Tested on x86_64-linux and i686-linux.
> > > 
> > > * gnu/local.mk: add re2c.scm to dist
> > > * gnu/packages/re2c.scm: new file  
> > 
> > Cool! I had the same package somewhere, thanks for publishing yours :)
> > I think there's already a module this could go into. If there isn't (I
> > will check tomorrow), what about a more generic name which could hold a
> > class of applications? Just an idea.
> 
> I mimicked flex which resides in standalone flex.scm.

Oh. In this case it's okay.

> > I haven't run the code, these are just my initial remarks. Overall it
> > looks good, so the only criticism is really in the (description).
> 
> > I think the beginning should be "Re2c (...)" or "@code{re2c} (...)"
> > 
> > > +full-featured table-based lexers).  Flexible API allows generated code to
> > > +be wired into virtually any environment.  Instead of exposing traditional
> > > +yylex() style API, re2c exposes its internals.  Be sure to take a look at  
> 
> Fixed in v2 patch.
> 
> > I'm not sure, but I think the "yylex()" will have to be written as
> > @code{yylex()} or something similar.
> > 
> > > +examples, they cover a lot of real-world cases and shed some light on dark
> > > +corners of re2c API.")  
> 
> Fixed in v2 patch.

I want someone to double check this. This is an area I don't know much
about, I personally would avoid it and would just write

@code{yylex} style API

but I'd rather would wait for someone who knows more about this.
> > I think "corners of the re2c API." would be correct?
> 
> Author's spelling:
>     https://raw.githubusercontent.com/skvadrik/re2c/gh-pages-gen/src/index.rst
> 
> I'm not sure which is right:
>     http://english.stackexchange.com/questions/10020/definite-article-before-schools-colleges-and-universities
> 
> -- 
> 
>   Sergei

I've read into rules for the use and omission of articles, and my gut
feeling is that you were right the first time (without "the").

-- 
ng0 -- https://www.inventati.org/patternsinthechaos/

Re: [PATCH v2] gnu: new re2c package, version 0.16

[ng0]

Hi,

I've applied and build this, and I have other remarks:

The commit message should look like this:

gnu: Add re2c.

* gnu/packages/re2c.scm: New file.
* gnu/local.mk (GNU_SYSTEM_MODULES): Add re2c.scm.



The "tested on(...)" is more of a personal note and not needed in the
commit message.

I get no difference to the re2c package I have (identical build) so when
those changes will be applied it's good to go from my side.

On 17-02-05 10:34:47, Sergei Trofimovich wrote:
> Tested on x86_64-linux and i686-linux.
> 
> * gnu/local.mk: add re2c.scm to dist
> * gnu/packages/re2c.scm: new file
> 
> CC: ng0 <contact.ng0@cryptolab.net>
> Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
> ---
> Change since v1: texinfo-ified descriotion as suggested by ng0
> 
>  gnu/local.mk          |  1 +
>  gnu/packages/re2c.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 gnu/packages/re2c.scm
> 
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 0948321c9..5c1634e02 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -318,6 +318,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/ratpoison.scm			\
>    %D%/packages/rdesktop.scm			\
>    %D%/packages/rdf.scm				\
> +  %D%/packages/re2c.scm				\
>    %D%/packages/readline.scm			\
>    %D%/packages/regex.scm				\
>    %D%/packages/rrdtool.scm			\
> diff --git a/gnu/packages/re2c.scm b/gnu/packages/re2c.scm
> new file mode 100644
> index 000000000..c7f296638
> --- /dev/null
> +++ b/gnu/packages/re2c.scm
> @@ -0,0 +1,47 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2017 Sergei Trofimovich <slyfox@inbox.ru>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages re2c)
> +  #:use-module (guix licenses)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu))
> +
> +(define-public re2c
> +  (package
> +    (name "re2c")
> +    (version "0.16")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append "https://github.com/skvadrik/" name
> +                                 "/releases/download/" version "/"
> +                                 name "-" version ".tar.gz"))
> +             (sha256
> +              (base32
> +               "114y0s4vmzip4hkf4cbz4yv8s498gzaylnphbzmwqhbn55j2bha8"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://re2c.org/")
> +    (synopsis "Lexer generator for C/C++")
> +    (description
> +     "@code{re2c} generates minimalistic hard-coded state machine (as opposed
> +to full-featured table-based lexers).  Flexible API allows generated code
> +to be wired into virtually any environment.  Instead of exposing traditional
> +@code{yylex()} style API, re2c exposes its internals.  Be sure to take a look
> +at examples, they cover a lot of real-world cases and shed some light on dark
> +corners of re2c API.")
> +    (license public-domain)))
> -- 
> 2.11.1
> 

-- 
ng0 -- https://www.inventati.org/patternsinthechaos/

Re: [PATCH] gnu: new re2c package, version 0.16

[Maxim Cournoyer]

[-- Attachment #1: Type: text/plain, Size: 3450 bytes --]

Hi Sergei,

Sergei Trofimovich <slyfox@inbox.ru> writes:

> Tested on x86_64-linux and i686-linux.
>
> * gnu/local.mk: add re2c.scm to dist
> * gnu/packages/re2c.scm: new file
>
> Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
> ---
>  gnu/local.mk          |  1 +
>  gnu/packages/re2c.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 48 insertions(+)
>  create mode 100644 gnu/packages/re2c.scm
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 0948321c9..5c1634e02 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -318,6 +318,7 @@ GNU_SYSTEM_MODULES =				\
>    %D%/packages/ratpoison.scm			\
>    %D%/packages/rdesktop.scm			\
>    %D%/packages/rdf.scm				\
> +  %D%/packages/re2c.scm				\
>    %D%/packages/readline.scm			\
>    %D%/packages/regex.scm				\
>    %D%/packages/rrdtool.scm			\
> diff --git a/gnu/packages/re2c.scm b/gnu/packages/re2c.scm
> new file mode 100644
> index 000000000..7c5698a82
> --- /dev/null
> +++ b/gnu/packages/re2c.scm
> @@ -0,0 +1,47 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2017 Sergei Trofimovich <slyfox@inbox.ru>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages re2c)
> +  #:use-module (guix licenses)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu))
> +
> +(define-public re2c
> +  (package
> +    (name "re2c")
> +    (version "0.16")
> +    (source (origin
> +             (method url-fetch)
> +             (uri (string-append "https://github.com/skvadrik/" name
> +                                 "/releases/download/" version "/"
> +                                 name "-" version ".tar.gz"))
> +             (sha256
> +              (base32
> +               "114y0s4vmzip4hkf4cbz4yv8s498gzaylnphbzmwqhbn55j2bha8"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://re2c.org/")
> +    (synopsis "Lexer generator for C/C++")
> +    (description
> +     "re2c generates minimalistic hard-coded state machine (as opposed to
> +full-featured table-based lexers).  Flexible API allows generated code to
> +be wired into virtually any environment.  Instead of exposing traditional
> +yylex() style API, re2c exposes its internals.  Be sure to take a look at
> +examples, they cover a lot of real-world cases and shed some light on dark
> +corners of re2c API.")
> +    (license public-domain)))

This looks good to me!

As an unrelated note, it seems that your patches are coming as duplicated
messages on this list (I received 3 messages for this very patch). Maybe
some configuration issue in your mail/smtp client?

Thanks,

Maxim

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

Re: [PATCH v2] gnu: new re2c package, version 0.16

[Ludovic Courtès]

Hello!

Sergei Trofimovich <slyfox@inbox.ru> skribis:

> Tested on x86_64-linux and i686-linux.
>
> * gnu/local.mk: add re2c.scm to dist
> * gnu/packages/re2c.scm: new file

Applied with the commit log ng0 suggested.

Thank you & thanks ng0 and Maxim for the review!

Ludo’.