From mboxrd@z Thu Jan 1 00:00:00 1970 From: ng0 Subject: Re: [PATCH] gnu: new re2c package, version 0.16 Date: Sun, 5 Feb 2017 11:56:53 +0000 Message-ID: <20170205115653.sya5vudz3v5jsdv7@wasp> References: <20170204174323.25083-1-slyfox@inbox.ru> <20170205004730.h6b6wy45fesxzqlz@wasp> <20170205105559.4f6dbaca@sf> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:49446) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caLPl-0003i5-Kt for guix-devel@gnu.org; Sun, 05 Feb 2017 06:55:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caLPh-00010e-R8 for guix-devel@gnu.org; Sun, 05 Feb 2017 06:55:29 -0500 Received: from fragranza.investici.org ([178.175.144.26]:40838) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1caLPh-0000zX-G0 for guix-devel@gnu.org; Sun, 05 Feb 2017 06:55:25 -0500 Content-Disposition: inline In-Reply-To: <20170205105559.4f6dbaca@sf> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Sergei Trofimovich Cc: guix-devel@gnu.org On 17-02-05 10:55:59, Sergei Trofimovich wrote: > On Sun, 5 Feb 2017 00:47:30 +0000 > ng0 wrote: > > > On 17-02-04 17:43:23, Sergei Trofimovich wrote: > > > Tested on x86_64-linux and i686-linux. > > > > > > * gnu/local.mk: add re2c.scm to dist > > > * gnu/packages/re2c.scm: new file > > > > Cool! I had the same package somewhere, thanks for publishing yours :) > > I think there's already a module this could go into. If there isn't (I > > will check tomorrow), what about a more generic name which could hold a > > class of applications? Just an idea. > > I mimicked flex which resides in standalone flex.scm. Oh. In this case it's okay. > > I haven't run the code, these are just my initial remarks. Overall it > > looks good, so the only criticism is really in the (description). > > > I think the beginning should be "Re2c (...)" or "@code{re2c} (...)" > > > > > +full-featured table-based lexers). Flexible API allows generated code to > > > +be wired into virtually any environment. Instead of exposing traditional > > > +yylex() style API, re2c exposes its internals. Be sure to take a look at > > Fixed in v2 patch. > > > I'm not sure, but I think the "yylex()" will have to be written as > > @code{yylex()} or something similar. > > > > > +examples, they cover a lot of real-world cases and shed some light on dark > > > +corners of re2c API.") > > Fixed in v2 patch. I want someone to double check this. This is an area I don't know much about, I personally would avoid it and would just write @code{yylex} style API but I'd rather would wait for someone who knows more about this. > > I think "corners of the re2c API." would be correct? > > Author's spelling: > https://raw.githubusercontent.com/skvadrik/re2c/gh-pages-gen/src/index.rst > > I'm not sure which is right: > http://english.stackexchange.com/questions/10020/definite-article-before-schools-colleges-and-universities > > -- > > Sergei I've read into rules for the use and omission of articles, and my gut feeling is that you were right the first time (without "the"). -- ng0 -- https://www.inventati.org/patternsinthechaos/