all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: ng0 <contact.ng0@cryptolab.net>
To: Sergei Trofimovich <slyfox@inbox.ru>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: new re2c package, version 0.16
Date: Sun, 5 Feb 2017 11:56:53 +0000	[thread overview]
Message-ID: <20170205115653.sya5vudz3v5jsdv7@wasp> (raw)
In-Reply-To: <20170205105559.4f6dbaca@sf>

On 17-02-05 10:55:59, Sergei Trofimovich wrote:
> On Sun, 5 Feb 2017 00:47:30 +0000
> ng0 <contact.ng0@cryptolab.net> wrote:
> 
> > On 17-02-04 17:43:23, Sergei Trofimovich wrote:
> > > Tested on x86_64-linux and i686-linux.
> > > 
> > > * gnu/local.mk: add re2c.scm to dist
> > > * gnu/packages/re2c.scm: new file  
> > 
> > Cool! I had the same package somewhere, thanks for publishing yours :)
> > I think there's already a module this could go into. If there isn't (I
> > will check tomorrow), what about a more generic name which could hold a
> > class of applications? Just an idea.
> 
> I mimicked flex which resides in standalone flex.scm.

Oh. In this case it's okay.

> > I haven't run the code, these are just my initial remarks. Overall it
> > looks good, so the only criticism is really in the (description).
> 
> > I think the beginning should be "Re2c (...)" or "@code{re2c} (...)"
> > 
> > > +full-featured table-based lexers).  Flexible API allows generated code to
> > > +be wired into virtually any environment.  Instead of exposing traditional
> > > +yylex() style API, re2c exposes its internals.  Be sure to take a look at  
> 
> Fixed in v2 patch.
> 
> > I'm not sure, but I think the "yylex()" will have to be written as
> > @code{yylex()} or something similar.
> > 
> > > +examples, they cover a lot of real-world cases and shed some light on dark
> > > +corners of re2c API.")  
> 
> Fixed in v2 patch.

I want someone to double check this. This is an area I don't know much
about, I personally would avoid it and would just write

@code{yylex} style API

but I'd rather would wait for someone who knows more about this.
> > I think "corners of the re2c API." would be correct?
> 
> Author's spelling:
>     https://raw.githubusercontent.com/skvadrik/re2c/gh-pages-gen/src/index.rst
> 
> I'm not sure which is right:
>     http://english.stackexchange.com/questions/10020/definite-article-before-schools-colleges-and-universities
> 
> -- 
> 
>   Sergei

I've read into rules for the use and omission of articles, and my gut
feeling is that you were right the first time (without "the").

-- 
ng0 -- https://www.inventati.org/patternsinthechaos/

  reply	other threads:[~2017-02-05 11:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-04 17:43 [PATCH] gnu: new re2c package, version 0.16 Sergei Trofimovich
2017-02-05  0:47 ` ng0
2017-02-05 10:34   ` [PATCH v2] " Sergei Trofimovich
2017-02-05 12:08     ` ng0
2017-02-06  9:51     ` Ludovic Courtès
2017-02-05 10:55   ` [PATCH] " Sergei Trofimovich
2017-02-05 11:56     ` ng0 [this message]
2017-02-05 23:38 ` Maxim Cournoyer
  -- strict thread matches above, loose matches on Subject: below --
2017-02-04 17:31 Sergei Trofimovich
2017-02-04 16:01 Sergei Trofimovich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170205115653.sya5vudz3v5jsdv7@wasp \
    --to=contact.ng0@cryptolab.net \
    --cc=guix-devel@gnu.org \
    --cc=slyfox@inbox.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.