From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Trofimovich Subject: Re: [PATCH] gnu: new re2c package, version 0.16 Date: Sun, 5 Feb 2017 10:55:59 +0000 Message-ID: <20170205105559.4f6dbaca@sf> References: <20170204174323.25083-1-slyfox@inbox.ru> <20170205004730.h6b6wy45fesxzqlz@wasp> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/QMxgDrZJdj2AMi_UgvMQB=8"; protocol="application/pgp-signature" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42909) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1caKUP-0006cN-17 for guix-devel@gnu.org; Sun, 05 Feb 2017 05:56:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1caKUL-0004eo-V3 for guix-devel@gnu.org; Sun, 05 Feb 2017 05:56:13 -0500 Received: from smtp39.i.mail.ru ([94.100.177.99]:44470) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1caKUL-0004ds-Hy for guix-devel@gnu.org; Sun, 05 Feb 2017 05:56:09 -0500 In-Reply-To: <20170205004730.h6b6wy45fesxzqlz@wasp> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: ng0 Cc: guix-devel@gnu.org --Sig_/QMxgDrZJdj2AMi_UgvMQB=8 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Sun, 5 Feb 2017 00:47:30 +0000 ng0 wrote: > On 17-02-04 17:43:23, Sergei Trofimovich wrote: > > Tested on x86_64-linux and i686-linux. > >=20 > > * gnu/local.mk: add re2c.scm to dist > > * gnu/packages/re2c.scm: new file =20 >=20 > Cool! I had the same package somewhere, thanks for publishing yours :) > I think there's already a module this could go into. If there isn't (I > will check tomorrow), what about a more generic name which could hold a > class of applications? Just an idea. I mimicked flex which resides in standalone flex.scm. > I haven't run the code, these are just my initial remarks. Overall it > looks good, so the only criticism is really in the (description). > I think the beginning should be "Re2c (...)" or "@code{re2c} (...)" >=20 > > +full-featured table-based lexers). Flexible API allows generated code= to > > +be wired into virtually any environment. Instead of exposing traditio= nal > > +yylex() style API, re2c exposes its internals. Be sure to take a look= at =20 Fixed in v2 patch. > I'm not sure, but I think the "yylex()" will have to be written as > @code{yylex()} or something similar. >=20 > > +examples, they cover a lot of real-world cases and shed some light on = dark > > +corners of re2c API.") =20 Fixed in v2 patch. > I think "corners of the re2c API." would be correct? Author's spelling: https://raw.githubusercontent.com/skvadrik/re2c/gh-pages-gen/src/index.= rst I'm not sure which is right: http://english.stackexchange.com/questions/10020/definite-article-befor= e-schools-colleges-and-universities --=20 Sergei --Sig_/QMxgDrZJdj2AMi_UgvMQB=8 Content-Type: application/pgp-signature Content-Description: Цифровая подпись OpenPGP -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAliXBL8ACgkQcaHudmEf86pmvwCfagUgtMxtUvr2AqGqs8Ccn39F uDEAn0Cjjh5Lf6Uc2Ll1dNFoh+jVjo6M =DN0n -----END PGP SIGNATURE----- --Sig_/QMxgDrZJdj2AMi_UgvMQB=8--