all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Danny Milosavljevic <dannym@scratchpost.org>
To: huang_ying_caritas@163.com
Cc: guix-devel@gnu.org
Subject: Re: [PATCH -v2] Fix gtk-im-modules for Gtk+3
Date: Sat, 4 Feb 2017 18:28:05 +0100	[thread overview]
Message-ID: <20170204182805.099e8ba8@scratchpost.org> (raw)
In-Reply-To: <20170130030649.1716-1-huang_ying_caritas@163.com>

Hi,

On Mon, 30 Jan 2017 11:06:49 +0800
huang_ying_caritas@163.com wrote:

> -(define* (manifest-lookup-package manifest name #:optional version)
> +(define* (manifest-lookup-package manifest name #:optional version output)
>    "Return as a monadic value the first package or store path referenced by
>  MANIFEST that is named NAME and optionally has the given VERSION prefix, or #f
>  if not found."

Please update the docstring too.

> +                     (if output
> +                         (string-suffix? output version*)
>                           #t))))

Should that include the separator between the parts? Otherwise it could maybe have false positives...

  parent reply	other threads:[~2017-02-04 17:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-30  3:06 [PATCH -v2] Fix gtk-im-modules for Gtk+3 huang_ying_caritas
2017-02-03 11:21 ` Huang, Ying
2017-02-04 17:28 ` Danny Milosavljevic [this message]
2017-02-04 23:42   ` Huang, Ying
2017-02-06  1:08 ` Ricardo Wurmus
2017-02-06 10:28   ` Huang, Ying

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170204182805.099e8ba8@scratchpost.org \
    --to=dannym@scratchpost.org \
    --cc=guix-devel@gnu.org \
    --cc=huang_ying_caritas@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.