From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 1/2] gnu: Add tremc. Date: Sat, 28 Jan 2017 03:32:35 -0500 Message-ID: <20170128083235.GA3144@jasmine> References: <871svo2w3g.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:55831) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cXOR6-0003xj-Jp for guix-devel@gnu.org; Sat, 28 Jan 2017 03:32:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cXOR3-0002qB-Fi for guix-devel@gnu.org; Sat, 28 Jan 2017 03:32:40 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:44287) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cXOR3-0002pK-BC for guix-devel@gnu.org; Sat, 28 Jan 2017 03:32:37 -0500 Content-Disposition: inline In-Reply-To: <871svo2w3g.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org --KsGdsel6WgEHnImy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 27, 2017 at 07:31:31PM +0100, Marius Bakke wrote: > Leo Famulari writes: > > * gnu/packages/bittorrent.scm (tremc): New variable. > > + (version (string-append "0.0.0-" revision "." (string-take commi= t 7))) >=20 > The script has a VERSION variable specifying 0.9.0, so I think we should > use that. It would of course be better if they provided tagged releases.. Good catch! > > + (description "Tremc is a console client, with a curses interface= , for the > > +Transmission BitTorrent daemon.") >=20 > So all the imports in the script are part of the python standard > library, including "curses"? Neat. LGTM! Yes, that seems to be the case as its packaged. There are some optional dependencies mentioned on the home-page, but I haven't packaged them. --KsGdsel6WgEHnImy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAliMVyMACgkQJkb6MLrK fwjm8BAA17vMpbkQZIHfHtr9TFF/rif+9+hxSSakTcxIl+hvpY6eJolnNDqixTgQ savFzdJTf3m7A/KTfPcRP3WzSPHu/ZKmvzp5DpQWYhSkfzM1mBw5GmSysWFAxzI9 U26Rm7M6kxlaTEPpdDLC6RTU9Xz6eadG9mN7Cv7wQp5K0fGNEH4fRNcst3Xr2E+C nAAz7BcPWxGpPzt5FCvlnsZXuC3Xbejt89vhBmH98t5cxyK/6vuBbA1AqioJfSjU d8PXV4wr8e+lldQ1w37xcCk625MbnpYeohZ/1AEcl2a5DqdXsKkvxtSJK7/ueB7Z z4JR6WkdHOKh2HrCrpW0nayIdOi6rBmRw1VkbUVgIqqOnBG/3M4/yKxVU8FoHaJv /gb/2rm+vCr33A4/5t2MFw5JVVOC7DY0H8o/i7yCR+yAu9Yqs92LLtqHRCEcOTe/ yPTq1UxU6DDYwUGSA9eIy+YVXu6NAo8x46k/5dTdhrBCFnXPxifzG2Jqv38lk7/a MfKvYEhO7cOBuHkQnRcPh9I3IgcSxUn2JkHPv8odTPvhy5Rq8cv9sRP3/bFQ3p1v 5X7m3qT/PesJLhUB36EeobyB+MUqonQcXecU/3Swa7qUIveBo5tJeRjRkeaRZPUf JpUKaChW2x75N+6q4bMHcKS0UTrv9zmTbZDi1YUBcUrewkbJM1Q= =3GKz -----END PGP SIGNATURE----- --KsGdsel6WgEHnImy--