* [PATCH] environment: Fix setting writable? on networking related files
@ 2017-01-27 6:26 Christopher Baines
2017-01-30 9:43 ` Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Christopher Baines @ 2017-01-27 6:26 UTC (permalink / raw)
To: guix-devel
* guix/scripts/environment.scm (launch-environment/container): Include the
file name in the call to string=? when deciding if the file should be
writable.
---
guix/scripts/environment.scm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/guix/scripts/environment.scm b/guix/scripts/environment.scm
index a08367d1b..8a3a935a1 100644
--- a/guix/scripts/environment.scm
+++ b/guix/scripts/environment.scm
@@ -421,7 +421,8 @@ host file systems to mount inside the container."
;; read-only within the
;; container.
(writable?
- (string=? "/etc/resolv.conf")))))
+ (string=? file
+ "/etc/resolv.conf")))))
%network-configuration-files)
'())
;; Mappings for the union closure of all inputs.
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] environment: Fix setting writable? on networking related files
2017-01-27 6:26 [PATCH] environment: Fix setting writable? on networking related files Christopher Baines
@ 2017-01-30 9:43 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2017-01-30 9:43 UTC (permalink / raw)
To: Christopher Baines; +Cc: guix-devel
Christopher Baines <mail@cbaines.net> skribis:
> * guix/scripts/environment.scm (launch-environment/container): Include the
> file name in the call to string=? when deciding if the file should be
> writable.
[...]
> (writable?
> - (string=? "/etc/resolv.conf")))))
> + (string=? file
> + "/etc/resolv.conf")))))
Good catch! Those multiple-arity equality predicates are terrible.
Applied, thanks!
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-30 9:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-27 6:26 [PATCH] environment: Fix setting writable? on networking related files Christopher Baines
2017-01-30 9:43 ` Ludovic Courtès
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.