all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#25508: Git hook shebangs should not be rewritten
@ 2017-01-22 23:25 Leo Famulari
  2020-11-16 18:10 ` bug#25304: " Miguel Ángel Arruga Vivas
  0 siblings, 1 reply; 4+ messages in thread
From: Leo Famulari @ 2017-01-22 23:25 UTC (permalink / raw)
  To: 25508; +Cc: John Darrington

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

----- Forwarded message from John Darrington <john@darrington.wattle.id.au> -----

Date: Sun, 22 Jan 2017 14:01:24 +0100
From: John Darrington <john@darrington.wattle.id.au>
To: guix-devel@gnu.org
Subject: Not patching shebang in git hook samples ?
User-Agent: Mutt/1.5.23 (2014-03-12)

The git package ships with a number of sample hook files.  These are shell scripts and
therefore the #!/bin/sh line gets substituted at  build time.

However these files get installed into every git repostory that is created, and users
are invited to use them as templates for their own hooks.

This will be fine until both git and bash are updated.  Now the original bash is free
to be garbage collected.  If that happens, the path: 
#!/gnu/store/qkw4zrwfybxww8f56nkb6hggxambk89b-bash-4.4.0/bin/sh
will no longer exist.

I suggest what we turn off the shebang patching for the files in share/templates for git.

J'

-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.




----- End forwarded message -----

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-11-16 20:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-22 23:25 bug#25508: Git hook shebangs should not be rewritten Leo Famulari
2020-11-16 18:10 ` bug#25304: " Miguel Ángel Arruga Vivas
2020-11-16 18:42   ` Marius Bakke
2020-11-16 20:51     ` Miguel Ángel Arruga Vivas

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.