From mboxrd@z Thu Jan 1 00:00:00 1970 From: Danny Milosavljevic Subject: python2-traceback2, python2-linecache2 Date: Thu, 19 Jan 2017 15:34:12 +0100 Message-ID: <20170119153412.6cacee8d@scratchpost.org> References: <8737gxxza3.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170118075305.29573-1-dannym@scratchpost.org> <20170118075305.29573-2-dannym@scratchpost.org> <874m0w9sj7.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> <20170119102850.67bf3e21@scratchpost.org> <87lgu76w8j.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:52585) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cUDnE-0004bt-GF for guix-devel@gnu.org; Thu, 19 Jan 2017 09:34:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cUDn9-0001ML-KV for guix-devel@gnu.org; Thu, 19 Jan 2017 09:34:24 -0500 Received: from dd1012.kasserver.com ([85.13.128.8]:37472) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cUDn9-0001Kb-Dh for guix-devel@gnu.org; Thu, 19 Jan 2017 09:34:19 -0500 In-Reply-To: <87lgu76w8j.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Marius Bakke Cc: guix-devel@gnu.org Hi, > The traceback2 module works on python3 as well. I don't think patching > imports will be necessary? Maybe it works. However, I think it's silly to package a "traceback" module for Python 3.5 which is a backport of the "traceback" module included in the CPython 3.5 interpreter when we use the CPython 3.5 interpreter in the first place. Same for python-linecache2. Therefore, I would have another patchset which adds them for Python 2 only and patches them out otherwise (s/traceback2/traceback/g). Adding them for Python 3.5 would just be asking for them to become outdated for no reason (they are part of Python 3.5 and will update with it - their origin is Python 3.5). That said, I'm happy that this is being discussed - I'm not sure what the right way to go forward is. >But I see we don't currently have traceback2, so I'm fine with 1.4.0 for now just to avoid packaging it. The rest LGTM, let's get this [python-testtools] in! OK!