From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH 1/1] gnu: icestorm: Replace reference in icebox_vlog.
Date: Sat, 14 Jan 2017 20:25:28 +0100
Message-ID: <20170114202524.0f056d54@scratchpost.org>
References: <20170114185652.29952-1-theodoros.for@openmailbox.org>
	<20170114185652.29952-2-theodoros.for@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53440)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cSTxM-0002Ah-Kp
	for guix-devel@gnu.org; Sat, 14 Jan 2017 14:25:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cSTxH-00069o-Gt
	for guix-devel@gnu.org; Sat, 14 Jan 2017 14:25:40 -0500
Received: from dd1012.kasserver.com ([85.13.128.8]:43358)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <dannym@scratchpost.org>)
	id 1cSTxH-00069a-4w
	for guix-devel@gnu.org; Sat, 14 Jan 2017 14:25:35 -0500
In-Reply-To: <20170114185652.29952-2-theodoros.for@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: guix-devel@gnu.org

Hi,

thanks for the patch!

On Sat, 14 Jan 2017 20:56:52 +0200
Theodoros Foradis <theodoros.for@openmailbox.org> wrote:

> * gnu/packages/fpga.scm (icestorm)[arguments]: Modify phases
> "fix-usr-local" to replace reference to /usr/local/share.
> ---
>  gnu/packages/fpga.scm | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/gnu/packages/fpga.scm b/gnu/packages/fpga.scm
> index f65eae8..eb05a39 100644
> --- a/gnu/packages/fpga.scm
> +++ b/gnu/packages/fpga.scm
> @@ -225,11 +225,12 @@ For synthesis, the compiler generates netlists in the desired format.")
>                            (string-append "PREFIX=" (assoc-ref %outputs "out")))
>         #:phases
>          (modify-phases %standard-phases
> -          (add-after 'unpack 'remove-usr-local
> -            (lambda _
> -              (substitute* "iceprog/Makefile"
> +          (add-after 'unpack 'fix-usr-local
> +            (lambda* (#:key outputs #:allow-other-keys)

> +              (substitute* '("iceprog/Makefile"

Patching this files changes nothing in the final result.

The package is built in an isolated container anyway - it's not like it can access /usr/local while it's building.

And if we did that everywhere we would have lots of substitution commands all over the place as noise - doing nothing useful, drowning out the important signal of actually useful substitutions. Therefore, I don't think we should do this.

What do the others think?

> "icebox/icebox_vlog.py")

... oops. This one I definitely agree with (the /usr/local/share one).