network-interface-names-*

network-interface-names-*

[John Darrington]

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

The procedures exported from guix/build/syscalls : 

network-interface-names
network-interface-flags
set-network-interface-flags
network-interface-netmask

.. and possibily a few others all take an argument called "sock" or "socket".

In the case of network-interface-names this parameter is #:optional and 
defaults to  (socket SOCK_STREAM AF_INET 0)

In all of the other procedures this argument is not optional, but so far
as I can tell, all callers pass the above expression as its value, and 
if I understand the API correctly, it's unlikely that anything else will
ever be required.

Will you accept a patch making "sock" #:optional for all parameters which
need it?



-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

Re: network-interface-names-*

[Ludovic Courtès]

John Darrington <john@darrington.wattle.id.au> skribis:

> The procedures exported from guix/build/syscalls : 
>
> network-interface-names
> network-interface-flags
> set-network-interface-flags
> network-interface-netmask
>
> .. and possibily a few others all take an argument called "sock" or "socket".
>
> In the case of network-interface-names this parameter is #:optional and 
> defaults to  (socket SOCK_STREAM AF_INET 0)
>
> In all of the other procedures this argument is not optional, but so far
> as I can tell, all callers pass the above expression as its value, and 
> if I understand the API correctly, it's unlikely that anything else will
> ever be required.
>
> Will you accept a patch making "sock" #:optional for all parameters which
> need it?

The problem is that we’d need to change the order of arguments in all of
these procedures (so that ‘sock’ comes last), and it would also
encourage inefficient code: we’d keep calling socket(2) for every call.

So while I agree that the API is kind of cumbersome (well, the
underlying syscalls are!), I’m inclined to leave it as is.

Now, maybe you can add higher-level procedures along the lines of
‘configure-network-interface’?

Thanks,
Ludo’.