From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH 2/2] scripts: system: Rename --no-grub option to
	--no-bootloader.
Date: Wed, 11 Jan 2017 00:10:08 +0100
Message-ID: <20170111001008.74e6e566@scratchpost.org>
References: <20170110184243.6100-1-david@craven.ch>
	<20170110184243.6100-2-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45389)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cR5YY-0004yf-61
	for guix-devel@gnu.org; Tue, 10 Jan 2017 18:10:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cR5YT-0003XZ-6l
	for guix-devel@gnu.org; Tue, 10 Jan 2017 18:10:18 -0500
Received: from dd1012.kasserver.com ([85.13.128.8]:58505)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <dannym@scratchpost.org>)
	id 1cR5YT-0003W5-0d
	for guix-devel@gnu.org; Tue, 10 Jan 2017 18:10:13 -0500
In-Reply-To: <20170110184243.6100-2-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

LGTM.

P.S.

I think it would be nice if we extended it to install a bootloader iff there is a package specified in the operating-system configuration:

This wouldn't install a bootloader:

  (operating-system ...
    (bootloader (grub-configuration (device "/dev/sda")))

But this would install a bootloader:

  (operating-system ...
    (bootloader (grub-configuration (device "/dev/sda")
                                    (package grub)))

The advantages are:
- If the user doesn't specify to overwrite the bootloader it doesn't overwrite the bootloader (ever - no more forgetting to pass --no-grub)
- The user has to specify either grub, grub-efi or u-boot - and if he doesn't, it doesn't install a random one - it installs none (and keeps the installed one - it would update for example the grub config file, though).

The disadvantages are:
- Config file not backwards compatible
- Installing from scratch without any bootloader is harder - docs should mention it

What do you think?

That said, your patch series is OK as is!