From: Danny Milosavljevic <dannym@scratchpost.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/2] scripts: system: Rename --no-grub option to --no-bootloader.
Date: Wed, 11 Jan 2017 00:10:08 +0100 [thread overview]
Message-ID: <20170111001008.74e6e566@scratchpost.org> (raw)
In-Reply-To: <20170110184243.6100-2-david@craven.ch>
LGTM.
P.S.
I think it would be nice if we extended it to install a bootloader iff there is a package specified in the operating-system configuration:
This wouldn't install a bootloader:
(operating-system ...
(bootloader (grub-configuration (device "/dev/sda")))
But this would install a bootloader:
(operating-system ...
(bootloader (grub-configuration (device "/dev/sda")
(package grub)))
The advantages are:
- If the user doesn't specify to overwrite the bootloader it doesn't overwrite the bootloader (ever - no more forgetting to pass --no-grub)
- The user has to specify either grub, grub-efi or u-boot - and if he doesn't, it doesn't install a random one - it installs none (and keeps the installed one - it would update for example the grub config file, though).
The disadvantages are:
- Config file not backwards compatible
- Installing from scratch without any bootloader is harder - docs should mention it
What do you think?
That said, your patch series is OK as is!
next prev parent reply other threads:[~2017-01-10 23:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 18:42 [PATCH 1/2] system: Rename grub to bootloader David Craven
2017-01-10 18:42 ` [PATCH 2/2] scripts: system: Rename --no-grub option to --no-bootloader David Craven
2017-01-10 23:10 ` Danny Milosavljevic [this message]
2017-01-11 8:23 ` David Craven
2017-01-10 18:51 ` [PATCH 1/2] system: Rename grub to bootloader David Craven
2017-01-12 14:14 ` Ludovic Courtès
2017-01-12 14:45 ` David Craven
2017-01-14 17:40 ` Ludovic Courtès
2017-01-13 6:06 ` Chris Marusich
2017-01-10 23:01 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170111001008.74e6e566@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.