Re: [PATCH 1/1] gnu: Add sysstat.

[Leo Famulari <leo@famulari.name>]

[-- Attachment #1: Type: text/plain, Size: 1073 bytes --]

On Tue, Jan 10, 2017 at 01:33:21PM +0200, Efraim Flashner wrote:
> On Sat, Jan 07, 2017 at 02:01:21PM -0500, Leo Famulari wrote:
> > * gnu/packages/linux.scm (sysstat): New variable.
> > +         (add-after 'build 'skip-touching-var
> > +           (lambda _
> > +             (substitute* "Makefile"
> > +               (("mkdir -p \\$\\(DESTDIR\\)\\$\\(SA_DIR\\)")
> > +                ""))
> 
> I would add this to the previous line

It could go there, but I prefer to keep it on its own line for clarify.
The string that is being matches is hard to read. Putting the empty
replacement on its own line clearly says "delete that string".

> > +    (description "The sysstat utilities are a collection of performance
> > +monitoring tools for Linux.  These include mpstat, iostat, tapestat, cifsiostat,
> > +pidstat, sar, sadc, sadf and sa.")
> 
> should these be @code{mpstat} ...

Done, and pushed! Thanks!

> I have lumina packaged locally, it wants iostat from sysstat for some of
> its functionality.

Awesome, let's get it in GNU Guix :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]