From mboxrd@z Thu Jan 1 00:00:00 1970 From: Efraim Flashner Subject: Re: [PATCH 2/3] gnu: Add fluid. Date: Mon, 9 Jan 2017 12:11:19 +0200 Message-ID: <20170109101119.GA24479@macbook42.flashner.co.il> References: <20170104124703.9621-1-ng0@libertad.pw> <20170104145305.13901-1-ng0@libertad.pw> <20170104145305.13901-3-ng0@libertad.pw> <87shospohn.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="CE+1k2dSO48ffgeK" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42357) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cQWvH-0005Eh-Dx for guix-devel@gnu.org; Mon, 09 Jan 2017 05:11:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cQWvC-000393-Qo for guix-devel@gnu.org; Mon, 09 Jan 2017 05:11:27 -0500 Content-Disposition: inline In-Reply-To: <87shospohn.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?utf-8?Q?Court=C3=A8s?= Cc: guix-devel@gnu.org --CE+1k2dSO48ffgeK Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jan 09, 2017 at 10:32:52AM +0100, Ludovic Court=C3=A8s wrote: > Hi! >=20 > ng0 skribis: >=20 > > * gnu/packages/qt.scm (fluid): New variable. >=20 > I think it=E2=80=99s best to put it in kde.scm or some other place; it fe= els > wrong to import (gnu packages kde-frameworks) in (gnu packages qt). >=20 > > +(define-public fluid > > + (package > > + (name "fluid") > > + (version "0.9.0") > > + (source > > + (origin > > + (method url-fetch) > > + (uri (string-append "https://github.com/lirios/fluid/releases/d= ownload/" > > + "v" version "/" name "-" version ".tar.xz")) > > + (file-name (string-append name "-" version ".tar.xz")) > > + (sha256 > > + (base32 > > + "0m6mijlnizgvmh0z2wcrmkfl5cdrylxz3d7bqii8dasmm0q8f68y")))) > > + (build-system cmake-build-system) > > + (arguments > > + `(#:tests? #f ; XXX: The tests do not find the fluid module. > > + #:phases > > + (modify-phases %standard-phases > > + (add-before 'build 'setenv > > + (lambda _ > > + (setenv "QT_QPA_PLATFORM" "offscreen")))))) >=20 > Please add as a comment why this is needed, and add this phase before > =E2=80=98check=E2=80=99 for clarity. Also add #t as the return value. >=20 > I removed the #:tests? #f as Danny suggested, but the tests are failing > in a way that suggests there=E2=80=99s something wrong: >=20 > --8<---------------cut here---------------start------------->8--- > Test project /tmp/guix-build-fluid-0.9.0.drv-0/build > Start 1: tst_controls > 1/3 Test #1: tst_controls .....................***Failed 0.05 sec > file:///tmp/guix-build-fluid-0.9.0.drv-0/fluid-0.9.0/tests/auto/controls/= tst_icon.qml:17:1: module "Fluid.Controls" is not installed=20 > import Fluid.Controls 1.0=20 > ^ > ********* Start testing of tst_controls ********* > Config: Using QtTest library 5.7.1, Qt 5.7.1 (x86_64-little_endian-lp64 s= hared (dynamic) release build; by GCC 4.9.4) > QWARN : tst_controls::tst_icon::compile()=20 > /tmp/guix-build-fluid-0.9.0.drv-0/fluid-0.9.0/tests/auto/controls/tst_i= con.qml produced 1 error(s): > /tmp/guix-build-fluid-0.9.0.drv-0/fluid-0.9.0/tests/auto/controls/tst= _icon.qml:17,1: module "Fluid.Controls" is not installed > Working directory: /tmp/guix-build-fluid-0.9.0.drv-0/build/tests/auto/c= ontrols > View: QQuickView, import paths: > '/tmp/guix-build-fluid-0.9.0.drv-0/build/tests/auto/controls' > 'qrc:/qt-project.org/imports' > '/gnu/store/0v50sh1lgkwkhxxq1v37ayxr15vayn6k-qtdeclarative-5.7.1/qml' > '/gnu/store/31mn2qgx5gh3zg3pk4w0j2a89jrkqnyv-qtquickcontrols2-5.7.1/q= ml' > Plugin paths: > '.' >=20 > FAIL! : tst_controls::tst_icon::compile() module "Fluid.Controls" is not= installed > --8<---------------cut here---------------end--------------->8--- >=20 > Could you check what=E2=80=99s going on? I've been working a bit with the tests in the qt modules, and qtdeclarative, for instance, can't find qtquick, which is part of qtdeclarative. Debian adds: (for qtdeclarative) ---- QML2_IMPORT_PATH=3D$(CURDIR)/test_root/usr/lib/$(DEB_HOST_MULTIARCH)/qt5/qm= l \ HOME=3D$(CURDIR) LD_LIBRARY_PATH=3D$(CURDIR)/lib ---- to the test phase so that the tests can find what was just built. I would suggest trying either running the tests after 'install (which probably won't make a difference), or setting an environmental variable or patching the source to change where Some-Important-Qt-Import-Path=E2=84= =A2 is. >=20 > Thanks you! >=20 > Ludo=E2=80=99. >=20 --=20 Efraim Flashner =D7=90=D7=A4=D7=A8=D7=99=D7=9D = =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --CE+1k2dSO48ffgeK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEkVdB/rIvpOM7bo+N9MHTkX6s7pMFAlhzYccACgkQ9MHTkX6s 7pPMtQ//T/R/OF1OfLL7o2/Sd9BJyiU3vyFJ/tqW9izANVGjCPPGH1b9cnaVjumK tyR+SNur/N7wzNGXHA9w9Vvk4AKD/HXOyO2oGUZ0xZTqXpXrSQAWXPBsHQy7zXQn mGkFDLAbZOYRv/zHkD2q0loa+kdR8ygvuJoxC2/YFQVz5j1xBjDrsvwWcTWIXIe/ xDU9lXKmXFE5xl549AcMNXhBBymoJZEFog+bT3DfMELL9vjOO6v8irrcCAlAktOG BJfXwv6aCJgiCsIChkkAxta9Jzn385oq8NGsJZ4RGKo9A8t2N8eNsSgC4e79xeXY HYE17qoyTZdW9jEu0jHEAjvpPU3VA80zPuFlRgmq428Avk9pozYSqFiNMfrOW8f1 3S0ugWug9UUBRK+5cEXCMnjwpNfkPXF2Fh1d4uCJKIJT+D1CznzWSVF0b4csLYRj bi4cohQbMQ7SWdT+OB+VkSYr0jBw6VJKD3ApZ46aBmxeGVipBOSGxazThetYL28D OPlmt2r95d5lTGtZDXXzWytaJG4gD7J5kpeylQxAj/tU23e+1X3ULEja3X4lOsuv bOkDttDomBLcvvYLnMwajH62EJA9FZz2Na5+pKLneUfa8rNWLqGQ7hpMSOO+8sdz Kl/BKOfkWVe40j6HhA3HoV6IYRoI7/7br0ZdooCLmOjMYXw4hIk= =fCtG -----END PGP SIGNATURE----- --CE+1k2dSO48ffgeK--