all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 2/5] gnu: gnu-make: Don't replace 'sh' reference with 'bash'.
Date: Thu, 5 Jan 2017 12:40:15 -0500	[thread overview]
Message-ID: <20170105174015.GA23295@jasmine> (raw)
In-Reply-To: <8737gxjup1.fsf@kirby.i-did-not-set--mail-host-address--so-tickle-me>

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

On Thu, Jan 05, 2017 at 06:14:02PM +0100, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > * gnu/packages/base.scm (gnu-make)[arguments]: Use /bin/sh instead of /bin/bash
> > in 'set-default-shell' phase.
> > ---
> >  gnu/packages/base.scm | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
> > index 66c5e0cdc..1f25a05aa 100644
> > --- a/gnu/packages/base.scm
> > +++ b/gnu/packages/base.scm
> > @@ -364,7 +364,7 @@ functionality beyond that which is outlined in the POSIX standard.")
> >              (let ((bash (assoc-ref inputs "bash")))
> >                (substitute* "job.c"
> >                  (("default_shell =.*$")
> > -                 (format #f "default_shell = \"~a/bin/bash\";\n"
> > +                 (format #f "default_shell = \"~a/bin/sh\";\n"
> >                           bash)))))))))
> 
> Could you add a #t at the end of this phase while at it? :-)

Yes, I'll go through the whole series and make this change where
appropriate :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-01-05 17:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-05 16:28 [PATCH 0/5] Clean-up of /bin/sh patching Leo Famulari
2017-01-05 16:28 ` [PATCH 1/5] gnu: m4: Don't replace 'sh' reference with 'bash' Leo Famulari
2017-01-05 16:28 ` [PATCH 2/5] gnu: gnu-make: " Leo Famulari
2017-01-05 17:14   ` Marius Bakke
2017-01-05 17:40     ` Leo Famulari [this message]
2017-01-05 16:28 ` [PATCH 3/5] gnu: glibc/linux: " Leo Famulari
2017-01-05 16:28 ` [PATCH 4/5] gnu: glibc/linux: Use /bin/sh instead of /bin/bash as the default shell Leo Famulari
2017-01-05 16:28 ` [PATCH 5/5] gnu: gawk: Don't replace 'sh' reference with 'bash' Leo Famulari
2017-01-05 17:10 ` [PATCH 0/5] Clean-up of /bin/sh patching Marius Bakke
2017-01-05 23:12   ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170105174015.GA23295@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.