From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH 1/2] gnu: libtool: Use 'modify-phases'. Date: Thu, 5 Jan 2017 10:43:48 -0500 Message-ID: <20170105154348.GA21781@jasmine> References: <20170101144525.10710-1-ng0@libertad.pw> <20170101152428.27552-1-ng0@libertad.pw> <20170105010939.GA30755@jasmine> <87fukxvlmg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cNdxnHkX5QqsyA0e" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:35751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cPACr-0006lh-KN for guix-devel@gnu.org; Thu, 05 Jan 2017 10:43:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cPACm-0001Za-Nz for guix-devel@gnu.org; Thu, 05 Jan 2017 10:43:57 -0500 Content-Disposition: inline In-Reply-To: <87fukxvlmg.fsf@gnu.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Ludovic =?iso-8859-1?Q?Court=E8s?= Cc: guix-devel@gnu.org --cNdxnHkX5QqsyA0e Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jan 05, 2017 at 11:36:55AM +0100, Ludovic Court=C3=A8s wrote: > Leo Famulari skribis: > > On Sun, Jan 01, 2017 at 03:24:27PM +0000, ng0 wrote: > > + (modify-phases %standard-phases > > + (add-before 'check 'pre-check > > + (lambda* (#:key inputs #:allow-other-keys) >=20 > Could you align =E2=80=9C(=E2=80=9D below the =E2=80=98d=E2=80=99 of =E2= =80=98add-before=E2=80=99? Done. > > + (add-after 'patch-source-shebangs 'restore-ltmain-shebang > > + (lambda* (#:key inputs #:allow-other-keys) >=20 > Likewise. Done. > > + (substitute* "build-aux/ltmain.in" > > + (((string-append (assoc-ref inputs "bash") "/b= in/sh")) > > + "/bin/sh"))))))) >=20 > We should use literal strings for patterns, like: >=20 > (substitute* =E2=80=A6 > (("^#!.*/bin/sh$") =E2=80=A6)) Done. > > From 809120b991603b8c557be7481be2bbae29bd8a7f Mon Sep 17 00:00:00 2001 > > From: Leo Famulari > > Date: Wed, 4 Jan 2017 19:44:27 -0500 > > Subject: [PATCH 3/3] gnu: libtool: Don't replace 'sh' reference with 'b= ash'. > > > > Bash behaves differently based on how it is invoked (see Invocation in = bash(1)). > > > > * gnu/packages/autotools.scm (libtool)[arguments]: Use /bin/sh instead > > of /bin/bash in 'pre-check' phase. Fix typo in comment. >=20 > Makes sense. More are coming! > Could you push them to =E2=80=98core-updates=E2=80=99? Done! > Thank you Leo & ng0! Thanks ng0! --cNdxnHkX5QqsyA0e Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlhuabMACgkQJkb6MLrK fwiVbg//WOLoCLuhdKCUmpS5jeDdHLroEJrlomb56ua29UWaY1zuGUhQkV+7It2c DNMkFKsmIX1s57FiPjGrMPaUaEiPYud9w7uT0FqfMoP3Tv2i8eQ3OpRGjfnt7li6 2lJ1mxsCYldnk3h5xMKqqX+C3scK5RBhvDnQ5wdix8wDP5eChGpptavHC6IWh5xB +BAAMf3cVTbhIyAQ7kznACAwIdK4KHSuswv+X5IVbnAeOFUnawnbD2yBBQUBoG+I mTgC3racoBUT5GqIe7TkgPUtkeIa/JzQqu4HqHVKd0PSj8psNyE39zvB/KQalFM5 FFFc4565hWlEemgrr8nNOrB38NeEdi8jojFUj25U2uyzPyj0N2G8pRmgVir9+UNA g/HSDLnC8Mf4LF8oc4VyNirqr5C2lBIMcgAoM0sJcKar/ypV2vjyz8srDw/AhFnQ /BGvdNAK62uYwWrYZMZuqzJZw3ezCLN76UIYKyqtxi1DA2oWXHtVRsydl0X2twEI UES6bpAwVK/GE52pZORwnoz4Krxk1XmJJHjrsAjpPkShrfXB1UnM6PRMFW2ciWJC ezWqfoQ1v92KdPPKg2ajHj/ltiRzoMUqaMANaQj40gkA/jGhYxZ0jbH256iFwT7Q 5YV7IOgegkXX4yL2oBWbYpLVWL7Qz6AT4r+jVpAuDOa19wnKbDM= =vi/T -----END PGP SIGNATURE----- --cNdxnHkX5QqsyA0e--