all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Leo Famulari <leo@famulari.name>
To: Marius Bakke <mbakke@fastmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: sed: Update to 4.3.
Date: Wed, 4 Jan 2017 15:16:38 -0500	[thread overview]
Message-ID: <20170104201638.GC7042@jasmine> (raw)
In-Reply-To: <20170104160134.28283-1-mbakke@fastmail.com>

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Wed, Jan 04, 2017 at 05:01:34PM +0100, Marius Bakke wrote:
> * gnu/packages/base.scm (sed): Update to 4.3.
> [source]: Use xz tarball. Remove upstreamed patch.
> [home-page]: Use https.
> [native-inputs]: Add perl.
> * gnu/packages/patches/sed-hurd-path-max.patch: Delete file.
> * gnu/local.mk (dist_patch_DATA): Remove it.

Thanks!

We should make sure that the built package doesn't retain a reference to
Perl.

It's interesting that `guix refresh -l sed` doesn't show the full impact
of this change:

$ guix refresh -l sed
Building the following 4 packages would ensure 4 dependent packages are rebuilt: password-store-1.6.5 hydra-20151030.1ff48da bamm-1.7.3 roary-3.7.0

Also, this part of the package definition is incorrect:

(substitute* '("testsuite/bsd.sh"
               "testsuite/bug-regex9.c")
  (("/bin/sh")
   (string-append bash "/bin/bash")))
#t)))))))

Bash and sh behave differently; the replacement string should refer to
'/bin/sh'.

Feel free to correct this in your patch, or I will do it in a later
commit. Let me know what you decide.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2017-01-04 20:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-04 16:01 [PATCH] gnu: sed: Update to 4.3 Marius Bakke
2017-01-04 20:16 ` Leo Famulari [this message]
2017-01-04 20:21   ` Leo Famulari
2017-01-05 14:23   ` Marius Bakke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170104201638.GC7042@jasmine \
    --to=leo@famulari.name \
    --cc=guix-devel@gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.