Re: [PATCH] gnu: sed: Update to 4.3.

[Leo Famulari <leo@famulari.name>]

[-- Attachment #1: Type: text/plain, Size: 1063 bytes --]

On Wed, Jan 04, 2017 at 05:01:34PM +0100, Marius Bakke wrote:
> * gnu/packages/base.scm (sed): Update to 4.3.
> [source]: Use xz tarball. Remove upstreamed patch.
> [home-page]: Use https.
> [native-inputs]: Add perl.
> * gnu/packages/patches/sed-hurd-path-max.patch: Delete file.
> * gnu/local.mk (dist_patch_DATA): Remove it.

Thanks!

We should make sure that the built package doesn't retain a reference to
Perl.

It's interesting that `guix refresh -l sed` doesn't show the full impact
of this change:

$ guix refresh -l sed
Building the following 4 packages would ensure 4 dependent packages are rebuilt: password-store-1.6.5 hydra-20151030.1ff48da bamm-1.7.3 roary-3.7.0

Also, this part of the package definition is incorrect:

(substitute* '("testsuite/bsd.sh"
               "testsuite/bug-regex9.c")
  (("/bin/sh")
   (string-append bash "/bin/bash")))
#t)))))))

Bash and sh behave differently; the replacement string should refer to
'/bin/sh'.

Feel free to correct this in your patch, or I will do it in a later
commit. Let me know what you decide.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]