From mboxrd@z Thu Jan  1 00:00:00 1970
From: Danny Milosavljevic <dannym@scratchpost.org>
Subject: Re: [PATCH] gnu: Add ldc-1.1.0-beta4
Date: Wed, 4 Jan 2017 15:52:34 +0100
Message-ID: <20170104155234.1463ac4e@scratchpost.org>
References: <CALjrZwaDQFJUOG0sLmC4vq_--8qz394-D-d7eLjQbzQPX7AW5Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44570)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cOmvl-0005qv-Oe
	for guix-devel@gnu.org; Wed, 04 Jan 2017 09:52:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dannym@scratchpost.org>) id 1cOmvh-0003fd-Sn
	for guix-devel@gnu.org; Wed, 04 Jan 2017 09:52:45 -0500
Received: from dd1012.kasserver.com ([85.13.128.8]:48828)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <dannym@scratchpost.org>)
	id 1cOmvh-0003el-MC
	for guix-devel@gnu.org; Wed, 04 Jan 2017 09:52:41 -0500
In-Reply-To: <CALjrZwaDQFJUOG0sLmC4vq_--8qz394-D-d7eLjQbzQPX7AW5Q@mail.gmail.com>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Frederick Muriithi <fredmanglis@gmail.com>
Cc: guix-devel@gnu.org

Hi,

On Wed, 4 Jan 2017 17:01:14 +0300
Frederick Muriithi <fredmanglis@gmail.com> wrote:

> Added ldc-1.1.0-beta4 since all other beta versions from there seem to
> reuse the same phobos, druntime and dmd-testsuite.

Thanks for the patch!

Hmm, you added gdb to the native-inputs but commented out the gdb invocations later? Why?

Also, could you ask upsteam whether they add a version flag (or something) for the http tests? So it can be enabled/disabled without huge patches in the future...

Also, why did you comment out unzip? You can add "unzip" to native-inputs.

Also, why do you add another "patch-phobos" phase? I think the one in ldc, from which you inherit, does the same, no?

I think I had the same problem with tzNames before. I think one of the functions there doesn't interpret its argument as a relative path if it contains a slash anywhere, ruining your /gnu/store prefix or something. Please look into it.