From: Danny Milosavljevic <dannym@scratchpost.org>
To: Frederick Muriithi <fredmanglis@gmail.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add ldc-1.1.0-beta4
Date: Wed, 4 Jan 2017 15:52:34 +0100 [thread overview]
Message-ID: <20170104155234.1463ac4e@scratchpost.org> (raw)
In-Reply-To: <CALjrZwaDQFJUOG0sLmC4vq_--8qz394-D-d7eLjQbzQPX7AW5Q@mail.gmail.com>
Hi,
On Wed, 4 Jan 2017 17:01:14 +0300
Frederick Muriithi <fredmanglis@gmail.com> wrote:
> Added ldc-1.1.0-beta4 since all other beta versions from there seem to
> reuse the same phobos, druntime and dmd-testsuite.
Thanks for the patch!
Hmm, you added gdb to the native-inputs but commented out the gdb invocations later? Why?
Also, could you ask upsteam whether they add a version flag (or something) for the http tests? So it can be enabled/disabled without huge patches in the future...
Also, why did you comment out unzip? You can add "unzip" to native-inputs.
Also, why do you add another "patch-phobos" phase? I think the one in ldc, from which you inherit, does the same, no?
I think I had the same problem with tzNames before. I think one of the functions there doesn't interpret its argument as a relative path if it contains a slash anywhere, ruining your /gnu/store prefix or something. Please look into it.
next prev parent reply other threads:[~2017-01-04 14:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 14:01 [PATCH] gnu: Add ldc-1.1.0-beta4 Frederick Muriithi
2017-01-04 14:44 ` Pjotr Prins
2017-01-04 14:52 ` Danny Milosavljevic [this message]
2017-01-04 15:27 ` Frederick Muriithi
2017-01-04 15:46 ` Danny Milosavljevic
2017-01-04 15:53 ` Frederick Muriithi
2017-01-04 16:58 ` Danny Milosavljevic
2017-01-05 16:33 ` Frederick Muriithi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104155234.1463ac4e@scratchpost.org \
--to=dannym@scratchpost.org \
--cc=fredmanglis@gmail.com \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.