From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 1/3] gnu: Add xdot.
Date: Sun, 1 Jan 2017 20:09:58 -0500
Message-ID: <20170102010958.GA12653@jasmine>
References: <20161126142758.25457-1-theodoros.for@openmailbox.org>
	<20161126142758.25457-2-theodoros.for@openmailbox.org>
	<87wpfofuzg.fsf@openmailbox.org> <87k2b9chew.fsf@gnu.org>
	<87tw9i4p6g.fsf@openmailbox.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53326)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cNr8W-0004DL-6I
	for guix-devel@gnu.org; Sun, 01 Jan 2017 20:10:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cNr8T-0006a7-2B
	for guix-devel@gnu.org; Sun, 01 Jan 2017 20:10:04 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:45857)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1cNr8S-0006Zk-UA
	for guix-devel@gnu.org; Sun, 01 Jan 2017 20:10:01 -0500
Content-Disposition: inline
In-Reply-To: <87tw9i4p6g.fsf@openmailbox.org>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: Theodoros Foradis <theodoros.for@openmailbox.org>
Cc: guix-devel <guix-devel@gnu.org>

On Sun, Jan 01, 2017 at 08:44:16PM +0200, Theodoros Foradis wrote:
> 
> Ludovic Courtès writes:
> 
> > Kei Kebreau <kei@openmailbox.org> skribis:
> >
> >> Theodoros Foradis <theodoros.for@openmailbox.org> writes:
> >>
> >>> * gnu/packages/graphviz.scm (xdot): New variable.
> >
> > [...]
> >
> >> Other than the comment above, LGTM. Is there someone more experienced
> >> with Python packages who can double check this?
> >
> > If it builds and passes ‘guix lint’ and looks good to you, please push,
> > Kei.
> >
> > We can always modify it later if we find a problem.
> >
> > Thanks!
> >
> > Ludo’.
> 
> Hello,
> 
> I see that the patch series has not been pushed yet. Do I need to post an
> updated patch, including the extra configure flag that was suggested?

Hi,

I just pushed all 3 patches with some minor edits to the commit messages
and the description of xdot.

I'm sorry these fell through the cracks! Thank you for reminding us :)