From: David Craven <david@craven.ch>
To: guix-devel@gnu.org
Subject: [PATCH 2/2] build-system: cargo: Use correct cargo.
Date: Thu, 29 Dec 2016 16:34:53 +0100 [thread overview]
Message-ID: <20161229153453.5698-2-david@craven.ch> (raw)
In-Reply-To: <20161229153453.5698-1-david@craven.ch>
* gnu/packages/rust.scm (cargo-bootstrap): Make private.
* guix/build-system/cargo.scm (default-cargo): Use cargo.
* guix/build/cargo-build-system.scm (install): Pass correct path to
--root.
---
gnu/packages/rust.scm | 4 +---
guix/build-system/cargo.scm | 3 +--
guix/build/cargo-build-system.scm | 2 +-
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/gnu/packages/rust.scm b/gnu/packages/rust.scm
index c6c4f3171..215030a7e 100644
--- a/gnu/packages/rust.scm
+++ b/gnu/packages/rust.scm
@@ -121,9 +121,7 @@
which can in turn be used to build the final Rust compiler.")
(license license:asl2.0)))
-;; FIXME: Make private once cargo is packaged. Is currently used by the
-;; cargo-build-system.
-(define-public cargo-bootstrap
+(define cargo-bootstrap
(package
(name "cargo-bootstrap")
(version (cargo-version %rust-bootstrap-binaries-version))
diff --git a/guix/build-system/cargo.scm b/guix/build-system/cargo.scm
index 8d835dda1..1ee28bcfe 100644
--- a/guix/build-system/cargo.scm
+++ b/guix/build-system/cargo.scm
@@ -46,8 +46,7 @@ to NAME and VERSION."
"Return the default Cargo package."
;; Lazily resolve the binding to avoid a circular dependency.
(let ((rust (resolve-interface '(gnu packages rust))))
- ;; FIXME: Package cargo and replace cargo-bootstrap with cargo.
- (module-ref rust 'cargo-bootstrap)))
+ (module-ref rust 'cargo)))
(define (default-rustc)
"Return the default Rustc package."
diff --git a/guix/build/cargo-build-system.scm b/guix/build/cargo-build-system.scm
index 460d829b3..6357812f9 100644
--- a/guix/build/cargo-build-system.scm
+++ b/guix/build/cargo-build-system.scm
@@ -85,7 +85,7 @@
;; When the package includes executables we install
;; it using cargo install. This fails when the crate
;; doesn't contain an executable.
- (system* "cargo" "install" "--root" bin)
+ (system* "cargo" "install" "--root" out)
#t))
(define %standard-phases
--
2.11.0
next prev parent reply other threads:[~2016-12-29 15:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 15:34 [PATCH 1/2] gnu: Add cargo David Craven
2016-12-29 15:34 ` David Craven [this message]
2017-01-02 21:12 ` [PATCH 2/2] build-system: cargo: Use correct cargo Ludovic Courtès
2016-12-30 21:58 ` [PATCH 1/2] gnu: Add cargo Chris Marusich
2016-12-30 23:11 ` David Craven
2016-12-31 0:07 ` Chris Marusich
2016-12-31 0:21 ` David Craven
2016-12-31 2:31 ` Chris Marusich
2017-01-02 21:07 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161229153453.5698-2-david@craven.ch \
--to=david@craven.ch \
--cc=guix-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.