all messages for Guix-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: [PATCH v4] daemon: Set ownership of kept build directories to the calling user.
@ 2016-12-23 11:18 Vincent Legoll
  2016-12-23 13:33 ` John Darrington
  0 siblings, 1 reply; 8+ messages in thread
From: Vincent Legoll @ 2016-12-23 11:18 UTC (permalink / raw)
  To: Hartmut Goebel; +Cc: guix-devel

Hello,

+            // Change the ownership if clientUid is set. Never change the
+            // ownership or the group to "root" for security reasons.
+            if (settings.clientUid != (uid_t) -1 && settings.clientUid != 0) {

Is "0" a magical value that don't need casting or am I missing something ?

-- 
Vincent Legoll

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH v3] daemon: Set ownership of kept build directories to the calling user.
@ 2016-12-08 12:12 Hartmut Goebel
  2016-12-08 12:14 ` [PATCH v4] " Hartmut Goebel
  0 siblings, 1 reply; 8+ messages in thread
From: Hartmut Goebel @ 2016-12-08 12:12 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: guix-devel

Am 06.12.2016 um 16:08 schrieb Ludovic Courtès:
> If you have checked that it works as intended, please push with these
> changes and email the commit ID to 15890-done@debbugs.gnu.org.

I can only verify that it worked with revision 6634180 "gnu: guile-ssh:
Update to 0.10.2.", but not with current master.

Starting with 21531ad "offload: Use Guile-SSH instead of GNU lsh" I get
errors, which I could not work around:

guix: offload: command not found
Try `guix --help' for more information.
guix build: error: build failed: unexpected EOF reading a line

So, although I'm confident the code is correct, I can not verify with
current master. Thus I'm posting a new version of the patch asking you
to test and push.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2016-12-25 23:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-23 11:18 [PATCH v4] daemon: Set ownership of kept build directories to the calling user Vincent Legoll
2016-12-23 13:33 ` John Darrington
2016-12-23 21:15   ` Danny Milosavljevic
2016-12-24 12:34     ` Hartmut Goebel
2016-12-25 23:34       ` Danny Milosavljevic
  -- strict thread matches above, loose matches on Subject: below --
2016-12-08 12:12 [PATCH v3] " Hartmut Goebel
2016-12-08 12:14 ` [PATCH v4] " Hartmut Goebel
2016-12-09 14:23   ` Ludovic Courtès
2016-12-09 14:47     ` Hartmut Goebel

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/guix.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.