From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Darrington Subject: Re: [PATCH] gnu: Add asunder. Date: Sat, 24 Dec 2016 08:07:41 +0100 Message-ID: <20161224070741.GA22948@jocasta.intra> References: <20161217092040.3112-1-cmmarusich@gmail.com> <20161217092040.3112-2-cmmarusich@gmail.com> <20161217185621.GC1726@jasmine> <878trd7gmz.fsf@gmail.com> <87d1gj12nb.fsf@gmail.com> <20161223163640.GA8463@jasmine> <87mvfmnkin.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="azLHFNyN32YCQGCU" Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45618) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cKgR8-00072H-Dn for guix-devel@gnu.org; Sat, 24 Dec 2016 02:08:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cKgR4-0007qT-Gd for guix-devel@gnu.org; Sat, 24 Dec 2016 02:08:10 -0500 Received: from de.cellform.com ([88.217.224.109]:51935 helo=jocasta.intra) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cKgR4-0007pc-8n for guix-devel@gnu.org; Sat, 24 Dec 2016 02:08:06 -0500 Content-Disposition: inline In-Reply-To: <87mvfmnkin.fsf@gmail.com> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Chris Marusich Cc: guix-devel@gnu.org --azLHFNyN32YCQGCU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 23, 2016 at 06:11:44PM -0800, Chris Marusich wrote: Leo Famulari writes: =20 > On Fri, Dec 23, 2016 at 12:16:24AM -0800, Chris Marusich wrote: >> Hi Leo, >>=20 >> I've responded to the feedback from you, Hartmut, and John. How do= es >> the latest patch look? It's available here: >>=20 >> https://lists.gnu.org/archive/html/guix-devel/2016-12/msg00707.html > > Thanks for the reminder! I pushed as > 426e6083ae9d4569005dab8edf948485e5979171. > > I think it would be useful to figure out if it's possible to avoid t= he > wrapper somehow, but I didn't look into this closely. =20 I'm sure we could avoid the wrapper by patching the source, but why would that be better? The wrapper is a simple and robust solution, and in this case I can't see any drawbacks to using it. =20 For context, Asunder assumes that various tools will be made available via the PATH environment variable. It refuses to function in certain cases when a tool that it needs can't be found in the PATH. I'm sure = we could patch this mechanism, but it seems simpler to just create a wrapper that puts the directories containing the tools onto the PATH. =20 FWIW, I think wrappers are bit of a nasty solution and should be avoided if feasible. Sometimes however there is no reasonable way to avoid them. It sounds as if this might be such as case. J' --=20 Avoid eavesdropping. Send strong encrypted email. PGP Public key ID: 1024D/2DE827B3=20 fingerprint =3D 8797 A26D 0854 2EAB 0285 A290 8A67 719C 2DE8 27B3 See http://sks-keyservers.net or any PGP keyserver for public key. --azLHFNyN32YCQGCU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlheHr0ACgkQimdxnC3oJ7OfzQCfe6WwOICZ8GVFjQN6UF86bu0S fasAni2rVvMox+dhEK6ILpl0Sorn8hq0 =/1zV -----END PGP SIGNATURE----- --azLHFNyN32YCQGCU--