Re: [PATCH] gnu: Add asunder.

[John Darrington <john@darrington.wattle.id.au>]

[-- Attachment #1: Type: text/plain, Size: 1735 bytes --]

On Fri, Dec 23, 2016 at 06:11:44PM -0800, Chris Marusich wrote:
     Leo Famulari <leo@famulari.name> writes:
     
     > On Fri, Dec 23, 2016 at 12:16:24AM -0800, Chris Marusich wrote:
     >> Hi Leo,
     >> 
     >> I've responded to the feedback from you, Hartmut, and John.  How does
     >> the latest patch look?  It's available here:
     >> 
     >> https://lists.gnu.org/archive/html/guix-devel/2016-12/msg00707.html
     >
     > Thanks for the reminder! I pushed as
     > 426e6083ae9d4569005dab8edf948485e5979171.
     >
     > I think it would be useful to figure out if it's possible to avoid the
     > wrapper somehow, but I didn't look into this closely.
     
     I'm sure we could avoid the wrapper by patching the source, but why
     would that be better?  The wrapper is a simple and robust solution, and
     in this case I can't see any drawbacks to using it.
     
     For context, Asunder assumes that various tools will be made available
     via the PATH environment variable.  It refuses to function in certain
     cases when a tool that it needs can't be found in the PATH.  I'm sure we
     could patch this mechanism, but it seems simpler to just create a
     wrapper that puts the directories containing the tools onto the PATH.
     

FWIW, I think wrappers are  bit of a nasty solution and should be avoided
if feasible.  Sometimes however there is no reasonable way to avoid them.
It sounds as if this might be such as case.  J'


-- 
Avoid eavesdropping.  Send strong encrypted email.
PGP Public key ID: 1024D/2DE827B3 
fingerprint = 8797 A26D 0854 2EAB 0285  A290 8A67 719C 2DE8 27B3
See http://sks-keyservers.net or any PGP keyserver for public key.


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]