From: Marius Bakke <mbakke@fastmail.com>
Subject: Re: [PATCH] gnu: Add python-hdf4.
Date: Thu, 22 Dec 2016 18:09:07 +0100

> Thomas Danckaert <thomas.danckaert@gmail.com> writes:
>
>> Hi Guix,
>>
>> this patch adds python-hdf4.  I'm not sure if the line “Python-HDF4
>> is a fork of pyhdf.” in the description is necessary.  The original
>> and “official” pyhdf (http://hdfeos.org/software/pyhdf.php) is
>> somewhat outdated (e.g. doesn't support python3).
>
> The "official" pyhdf and this fork was released around the same 
> time and
> have the same version number. Confusing! But I'll take your word 
> that
> this one is better.

Yes, it seems it mirrors updates in the “official” one, and keeps the 
same version numbers.

> Regarding the patch, I wonder if it should go in (gnu packages 
> maths),
> similar to how we put PDF libraries in pdf.scm and XML in xml.scm 
> etc.
> But no strong opinion here.

I've wondered the same.  Right now, h5py, which is a similar package 
for HDF5, is also in python.scm, so I decided to add this package 
next to it.  As an aside, I find many packages in maths.scm are not 
really “mathy” (“science” maybe), but anyway :-)

> The 'check' phase seems to run the build again, and prints at the 
> end
> "Ran 0 tests in 0.000s". Looking at the Github ".travis.yml", the CI
> tool runs the command "nosetests" instead of 'python setup.py test' 
> like
> python-build-system does by default. Can you try replacing the 
> 'check'
> phase with that command? You'll need 'python-nose' as a 
> native-input.

I hadn't noticed that. This patch adds nosetests, but that just 
prints “Ran 0 tests in .005s”, so it seems there are no tests.  Shall 
we just delete the 'check' phase?

Other changes applied!

thank you,

Thomas