[PATCH] Add pagure SCM/forge

[PATCH] Add pagure SCM/forge

[ng0]

[PATCH 01/11] gnu: Add python-flask-wtf.
[PATCH 02/11] gnu: Add python-flask-multistatic.
[PATCH 03/11] gnu: Add python-kitchen.
[PATCH 04/11] gnu: Add python-munch.
[PATCH 05/11] gnu: Add python-pygit2.
[PATCH 06/11] gnu: Add python2-openid.
[PATCH 07/11] gnu: Add python-openid-cla.
[PATCH 08/11] gnu: Add python-openid-teams.
[PATCH 09/11] gnu: Add python-straight.plugin.
[PATCH 10/11] gnu: Add python-trollius-redis.
[PATCH 11/11] gnu: Add pagure.

*drumroll* This adds pagure (https://pagure.io) and its dependency graph,
excluding some fedora specific packages. I hacked on this today and will
work on a service as soon as I've read more up on the docs, etc.

I hope I managed to do this python package okay despite not having all of
the new python documentation.

[PATCH 01/11] gnu: Add python-flask-wtf.

[ng0]

* gnu/packages/python.scm (python-flask-wtf): New variable.
---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index c46d51724..d9796b8e5 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9191,6 +9191,31 @@ presume or force a developer to use a particular tool or library.")
 (define-public python2-flask
   (package-with-python2 python-flask))
 
+(define-public python-flask-wtf
+  (package
+    (name "python-flask-wtf")
+    (version "0.13.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "Flask-WTF" version))
+       (sha256
+        (base32
+         "04l5743j2dici46038sqlzvf0xzpg8rf7s9ld2x24xv7f4idg990"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-flask-babel" ,python-flask-babel)
+       ("python-nose" ,python-nose)))
+  (home-page "https://github.com/lepture/flask-wtf")
+  (synopsis "Simple integration of Flask and WTForms")
+  (description
+   "Simple integration of Flask and WTForms, including CSRF,
+file upload, and reCAPTCHA.")
+  (license license:bsd-3)))
+
+(define-public python2-flask-wtf
+  (package-with-python2 python-flask-wtf))
+
 (define-public python-cookies
   (package
     (name "python-cookies")
-- 
2.11.0

Re: [PATCH 01/11] gnu: Add python-flask-wtf.

[Leo Famulari]

On Sun, Dec 11, 2016 at 06:12:27PM +0000, ng0 wrote:
> * gnu/packages/python.scm (python-flask-wtf): New variable.

> +    (propagated-inputs
> +     `(("python-flask-babel" ,python-flask-babel)
> +       ("python-nose" ,python-nose)))

Nose is a tool for running unit tests. Should python-nose be a
native-input here?

Also, I noticed the test suite failed because python-wtforms was not
available.

Re: [PATCH 01/11] gnu: Add python-flask-wtf.

[ng0]

Leo Famulari <leo@famulari.name> writes:

> On Sun, Dec 11, 2016 at 06:12:27PM +0000, ng0 wrote:
>> * gnu/packages/python.scm (python-flask-wtf): New variable.
>
>> +    (propagated-inputs
>> +     `(("python-flask-babel" ,python-flask-babel)
>> +       ("python-nose" ,python-nose)))
>
> Nose is a tool for running unit tests. Should python-nose be a
> native-input here?
>
> Also, I noticed the test suite failed because python-wtforms was not
> available.
>

Ah, thanks.
Yeah I need to make my notes about the new python system.. I had
everything propagated now.. which is false it seems.
-- 
♥Ⓐ  ng0  | ng0.chaosnet.org

Re: [PATCH 01/11] gnu: Add python-flask-wtf.

[Leo Famulari]

On Sun, Dec 11, 2016 at 11:05:56PM +0000, ng0 wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Sun, Dec 11, 2016 at 06:12:27PM +0000, ng0 wrote:
> >> * gnu/packages/python.scm (python-flask-wtf): New variable.
> >
> >> +    (propagated-inputs
> >> +     `(("python-flask-babel" ,python-flask-babel)
> >> +       ("python-nose" ,python-nose)))
> >
> > Nose is a tool for running unit tests. Should python-nose be a
> > native-input here?
> >
> > Also, I noticed the test suite failed because python-wtforms was not
> > available.
> >
> 
> Ah, thanks.
> Yeah I need to make my notes about the new python system.. I had
> everything propagated now.. which is false it seems.

My understanding is that everything used at run-time should be
propagated, but things used only while building are still native-inputs.

Re: [PATCH 01/11] gnu: Add python-flask-wtf.

[Hartmut Goebel]

Am 12.12.2016 um 00:22 schrieb Leo Famulari:
> My understanding is that everything used at run-time should be
> propagated, but things used only while building are still native-inputs.

That's it :-)

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Re: [PATCH 01/11] gnu: Add python-flask-wtf.

[Hartmut Goebel]

Am 12.12.2016 um 00:05 schrieb ng0:
> Yeah I need to make my notes about the new python system.. I had
> everything propagated now.. which is false it seems.

We could add nose to the lint checkers, should we?

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

[PATCH 02/11] gnu: Add python-flask-multistatic.

[ng0]

* gnu/packages/python.scm (python-flask-multistatic): New variable.
---
 gnu/packages/python.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index d9796b8e5..f3e0142f5 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9216,6 +9216,30 @@ file upload, and reCAPTCHA.")
 (define-public python2-flask-wtf
   (package-with-python2 python-flask-wtf))
 
+(define-public python-flask-multistatic
+  (package
+    (name "python-flask-multistatic")
+    (version "1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "flask-multistatic" version))
+       (sha256
+        (base32
+         "0p4v50rwv64wcd0zlq7rzl4waprwr4hj19s3cgf1isywa7jcisgm"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-flask" ,python-flask)))
+    (home-page "https://pagure.io/flask-multistatic")
+    (synopsis "Flask plugin to allow overriding static files")
+    (description
+     "@code{flask-multistatic} is a simple plugin to add
+support for overriding static files to flask.")
+    (license license:gpl3)))
+
+(define-public python2-flask-multistatic
+  (package-with-python2 python-flask-multistatic))
+
 (define-public python-cookies
   (package
     (name "python-cookies")
-- 
2.11.0

Re: [PATCH 02/11] gnu: Add python-flask-multistatic.

[Leo Famulari]

On Sun, Dec 11, 2016 at 06:12:28PM +0000, ng0 wrote:
> * gnu/packages/python.scm (python-flask-multistatic): New variable.

> +    (license license:gpl3)))

It should be gpl3+:

https://pagure.io/flask-multistatic/blob/master/f/flask_multistatic.py

[PATCH 03/11] gnu: Add python-kitchen.

[ng0]

* gnu/packages/python.scm (python-kitchen): New variable.
---
 gnu/packages/python.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index f3e0142f5..6b355b723 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -2432,6 +2432,39 @@ version numbers.")
              (propagated-inputs
               `(("python2-functools32" ,python2-functools32))))))
 
+;; The source on github and pypi is newer than on fedorahosted.
+(define-public python-kitchen
+  (package
+    (name "python-kitchen")
+    (version "1.2.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/fedora-infra/"
+                           "kitchen/archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1ybx8nccbh6j1v6xj60j8dkbwnhlj0i1hizfrxzcdvrm9wn6a8wa"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-chardet" ,python-chardet)))
+    (home-page "https://fedorahosted.org/kitchen")
+    (synopsis "Python API for snippets")
+    (description
+     "@code{kitchen} module provides a python API for all sorts
+of little useful snippets of code that everybody ends up
+writing for their projects but never seem big enough to build
+an independent release.  Use kitchen and stop cutting and
+pasting that code over and over.")
+    (license (list license:lgpl2.1
+                   ;; subprocess.py, test_subprocess.py,
+                   ;; kitchen/pycompat25/defaultdict.py:
+                   license:psfl))))
+
+(define-public python2-kitchen
+  (package-with-python2 python-kitchen))
+
 (define-public python-unidecode
   (package
     (name "python-unidecode")
-- 
2.11.0

Re: [PATCH 03/11] gnu: Add python-kitchen.

[Leo Famulari]

On Sun, Dec 11, 2016 at 06:12:29PM +0000, ng0 wrote:
> * gnu/packages/python.scm (python-kitchen): New variable.

> +;; The source on github and pypi is newer than on fedorahosted.

<https://fedorahosted.org/> is being retired, and we'll need to update
our packages accordingly.

https://communityblog.fedoraproject.org/fedorahosted-sunset-2017-02-28/

> +    (version "1.2.4")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/fedora-infra/"
> +                           "kitchen/archive/" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1ybx8nccbh6j1v6xj60j8dkbwnhlj0i1hizfrxzcdvrm9wn6a8wa"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-chardet" ,python-chardet)))
> +    (home-page "https://fedorahosted.org/kitchen")
> +    (synopsis "Python API for snippets")
> +    (description
> +     "@code{kitchen} module provides a python API for all sorts
> +of little useful snippets of code that everybody ends up
> +writing for their projects but never seem big enough to build
> +an independent release.  Use kitchen and stop cutting and
> +pasting that code over and over.")
> +    (license (list license:lgpl2.1
> +                   ;; subprocess.py, test_subprocess.py,
> +                   ;; kitchen/pycompat25/defaultdict.py:
> +                   license:psfl))))

I think it's lgpl2.1+, based on the handful of source file headers that
I checked.

[PATCH 04/11] gnu: Add python-munch.

[ng0]

* gnu/packages/python.scm (python-munch): New variable.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 6b355b723..2a49a060b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3257,6 +3257,28 @@ capabilities.")
 (define python2-numpy-bootstrap
   (package-with-python2 python-numpy-bootstrap))
 
+(define-public python-munch
+  (package
+    (name "python-munch")
+    (version "2.0.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "munch" version))
+       (sha256
+        (base32
+         "1cmqg91xnqx8gvnh4pmp0bfl1dfcm65d5p9mg73zz8pkjhx6h80l"))))
+    (build-system python-build-system)
+    (home-page "http://github.com/Infinidat/munch")
+    (synopsis "Dot-accessible dictionary")
+    (description
+     "Munch is a dot-accessible dictionary similar to
+JavaScript objects.")
+    (license license:expat)))
+
+(define-public python2-munch
+  (package-with-python2 python-munch))
+
 (define-public python2-fastlmm
   (package
     (name "python2-fastlmm")
-- 
2.11.0

[PATCH 05/11] gnu: Add python-pygit2.

[ng0]

* gnu/packages/python.scm (python-pygit2): New variable.
---
 gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 2a49a060b..32f83deb4 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3376,6 +3376,36 @@ association studies (GWAS) on extremely large data sets.")
 (define-public python2-numpy
   (package-with-python2 python-numpy))
 
+(define-public python-pygit2
+  (package
+    (name "python-pygit2")
+    (version "0.24.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/libgit2/"
+                           "pygit2/archive/v" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1j7zkz2bsn4wqmkg1zkxb3r00xx28rkz9jdwcsikcl4ffa298xwa"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-six" ,python-six)
+       ("python-cffi" ,python-cffi)
+       ("libgit2" ,libgit2)
+       ("python-tox" ,python-tox)))
+    (home-page "http://github.com/libgit2/pygit2")
+    (synopsis "Python bindings for libgit2")
+    (description
+     "Pygit2 is a set of Python bindings to the libgit2
+shared library, libgit2 implements Git plumbing.")
+    ;; GPL2.0 only, with linking exception.
+    (license license:gpl2)))
+
+(define-public python2-pygit2
+  (package-with-python2 python-pygit2))
+
 (define-public python-pyparsing
   (package
     (name "python-pyparsing")
-- 
2.11.0

bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]

[Leo Famulari]

I noticed while building the package added by ng0's patch (below) that
the test suite fails, but the check phase succeeds:

[...]
======================================================================
ERROR: test_clone_with_credentials (test.test_repository.CloneRepositoryTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/test/test_repository.py", line 544, in test_clone_with_credentials
    self._temp_dir, callbacks=pygit2.RemoteCallbacks(credentials=pygit2.UserPass("libgit2", "libgit2")))
  File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/__init__.py", line 255, in clone_repository
    check_error(err)
  File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/errors.py", line 64, in check_error
    raise GitError(message)
_pygit2.GitError: curl error: Couldn't resolve host 'bitbucket.org'


----------------------------------------------------------------------
Ran 262 tests in 5.771s

FAILED (errors=3)
phase `check' succeeded after 8.9 seconds
[...]

Any ideas?

On Sun, Dec 11, 2016 at 06:12:31PM +0000, ng0 wrote:
> * gnu/packages/python.scm (python-pygit2): New variable.
> ---
>  gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 2a49a060b..32f83deb4 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -3376,6 +3376,36 @@ association studies (GWAS) on extremely large data sets.")
>  (define-public python2-numpy
>    (package-with-python2 python-numpy))
>  
> +(define-public python-pygit2
> +  (package
> +    (name "python-pygit2")
> +    (version "0.24.2")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/libgit2/"
> +                           "pygit2/archive/v" version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "1j7zkz2bsn4wqmkg1zkxb3r00xx28rkz9jdwcsikcl4ffa298xwa"))))
> +    (build-system python-build-system)
> +    (propagated-inputs
> +     `(("python-six" ,python-six)
> +       ("python-cffi" ,python-cffi)
> +       ("libgit2" ,libgit2)
> +       ("python-tox" ,python-tox)))
> +    (home-page "http://github.com/libgit2/pygit2")
> +    (synopsis "Python bindings for libgit2")
> +    (description
> +     "Pygit2 is a set of Python bindings to the libgit2
> +shared library, libgit2 implements Git plumbing.")
> +    ;; GPL2.0 only, with linking exception.
> +    (license license:gpl2)))
> +
> +(define-public python2-pygit2
> +  (package-with-python2 python-pygit2))
> +
>  (define-public python-pyparsing
>    (package
>      (name "python-pyparsing")
> -- 
> 2.11.0
> 
> 

bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2309 bytes --]

Leo Famulari <leo@famulari.name> writes:

> I noticed while building the package added by ng0's patch (below) that
> the test suite fails, but the check phase succeeds:
>
> [...]
> ======================================================================
> ERROR: test_clone_with_credentials (test.test_repository.CloneRepositoryTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
>   File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/test/test_repository.py", line 544, in test_clone_with_credentials
>     self._temp_dir, callbacks=pygit2.RemoteCallbacks(credentials=pygit2.UserPass("libgit2", "libgit2")))
>   File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/__init__.py", line 255, in clone_repository
>     check_error(err)
>   File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/errors.py", line 64, in check_error
>     raise GitError(message)
> _pygit2.GitError: curl error: Couldn't resolve host 'bitbucket.org'
>
>
> ----------------------------------------------------------------------
> Ran 262 tests in 5.771s
>
> FAILED (errors=3)
> phase `check' succeeded after 8.9 seconds
> [...]
>
> Any ideas?

It looks like the 'check' phase ends with 'delete-file-recursively',
which has an unspecified return value, and that eventual failures from
'call-setuppy' are lost.

--8<---------------cut here---------------start------------->8---
(define* (check #:key tests? test-target use-setuptools? #:allow-other-keys)
  "Run the test suite of a given Python package."
  (if tests?
      ;; Running `setup.py test` creates an additional .egg-info directory in
      ;; build/lib in some cases, e.g. if the source is in a sub-directory
      ;; (given with `package_dir`). This will by copied to the output, too,
      ;; so we need to remove.
      (let ((before (find-files "build" "\\.egg-info$" #:directories? #t)))
        (call-setuppy test-target '() use-setuptools?)
        (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
               (inter (lset-difference eqv? after before)))
          (for-each delete-file-recursively inter)))
    #t))
--8<---------------cut here---------------end--------------->8---

Perhaps something like this would work (untested)?


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Perhaps something like this would work (untested)?

Oops, here is the patch I wanted to attach:

--8<---------------cut here---------------start------------->8---
(define* (check #:key tests? test-target use-setuptools? #:allow-other-keys)
  "Run the test suite of a given Python package."
  (if tests?
      (let ((before (find-files "build" "\\.egg-info$" #:directories? #t)))
        (if (call-setuppy test-target '() use-setuptools?)
            (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
                   (inter (lset-difference eqv? after before)))
              (for-each delete-file-recursively inter)
              #t))
        #f)
      #t))
--8<---------------cut here---------------end--------------->8---

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

On Mon, Dec 12, 2016 at 12:05:57AM +0100, Marius Bakke wrote:
> Marius Bakke <mbakke@fastmail.com> writes:
> 
> > Perhaps something like this would work (untested)?
> 
> Oops, here is the patch I wanted to attach:

Can you make it a patch? :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]

[Marius Bakke]

[-- Attachment #1.1: Type: text/plain, Size: 406 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Mon, Dec 12, 2016 at 12:05:57AM +0100, Marius Bakke wrote:
>> Marius Bakke <mbakke@fastmail.com> writes:
>> 
>> > Perhaps something like this would work (untested)?
>> 
>> Oops, here is the patch I wanted to attach:
>
> Can you make it a patch? :)

I'm testing it now on a branch, will report on the results in while. Here
it is in patch form:


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-build-system-python-Make-sure-return-value-from-chec.patch --]
[-- Type: text/x-patch, Size: 1554 bytes --]

From e069a7f1927ade7a178cb876ee4b4c339a093ba5 Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke@fastmail.com>
Date: Mon, 12 Dec 2016 00:25:27 +0100
Subject: [PATCH] build-system/python: Make sure return value from 'check' is
 preserved.

* guix/build/python-build-system.scm (check): Wrap 'call-setuppy' in 'if' so
that it actually fails when the tests fail.
---
 guix/build/python-build-system.scm | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index 3f280b0ac..20eb24edc 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -137,11 +137,13 @@
       ;; (given with `package_dir`). This will by copied to the output, too,
       ;; so we need to remove.
       (let ((before (find-files "build" "\\.egg-info$" #:directories? #t)))
-        (call-setuppy test-target '() use-setuptools?)
-        (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
-               (inter (lset-difference eqv? after before)))
-          (for-each delete-file-recursively inter)))
-    #t))
+        (if (call-setuppy test-target '() use-setuptools?)
+            (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
+                   (inter (lset-difference eqv? after before)))
+              (for-each delete-file-recursively inter)
+              #t))
+        #f)
+      #t))
 
 (define (get-python-version python)
   (let* ((version     (last (string-split python #\-)))
-- 
2.11.0

bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]

[Marius Bakke]

[-- Attachment #1.1: Type: text/plain, Size: 1836 bytes --]

Marius Bakke <mbakke@fastmail.com> writes:

> Leo Famulari <leo@famulari.name> writes:
>
>> I noticed while building the package added by ng0's patch (below) that
>> the test suite fails, but the check phase succeeds:
>>
>> [...]
>> ======================================================================
>> ERROR: test_clone_with_credentials (test.test_repository.CloneRepositoryTest)
>> ----------------------------------------------------------------------
>> Traceback (most recent call last):
>>   File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/test/test_repository.py", line 544, in test_clone_with_credentials
>>     self._temp_dir, callbacks=pygit2.RemoteCallbacks(credentials=pygit2.UserPass("libgit2", "libgit2")))
>>   File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/__init__.py", line 255, in clone_repository
>>     check_error(err)
>>   File "/tmp/guix-build-python-pygit2-0.24.2.drv-0/pygit2-0.24.2/pygit2/errors.py", line 64, in check_error
>>     raise GitError(message)
>> _pygit2.GitError: curl error: Couldn't resolve host 'bitbucket.org'
>>
>>
>> ----------------------------------------------------------------------
>> Ran 262 tests in 5.771s
>>
>> FAILED (errors=3)
>> phase `check' succeeded after 8.9 seconds
>> [...]
>>
>> Any ideas?
>
> It looks like the 'check' phase ends with 'delete-file-recursively',
> which has an unspecified return value, and that eventual failures from
> 'call-setuppy' are lost.

The good news: the attached patch makes 'check' work as expected. The
bad news is that we have some breakages.

'python-py' fails with:

TypeError: py.test.__dict__ is not a dictionary

Which seems similar to

https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174165144

I tried adding a newer setuptools as input, to no avail. Needs more
investigation.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-build-system-python-Make-sure-check-returns-failures.patch --]
[-- Type: text/x-patch, Size: 1648 bytes --]

From 12c4a14b415f26155f85f8ea172ddf696e274855 Mon Sep 17 00:00:00 2001
From: Marius Bakke <mbakke@fastmail.com>
Date: Mon, 12 Dec 2016 00:25:27 +0100
Subject: [PATCH] build-system/python: Make sure 'check' returns failures.

* guix/build/python-build-system.scm (check): Wrap 'call-setuppy' in 'if' so
that it actually fails when the tests fail. Print informational message when
skipped.
---
 guix/build/python-build-system.scm | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/guix/build/python-build-system.scm b/guix/build/python-build-system.scm
index 3f280b0ac..dd07986b9 100644
--- a/guix/build/python-build-system.scm
+++ b/guix/build/python-build-system.scm
@@ -137,11 +137,15 @@
       ;; (given with `package_dir`). This will by copied to the output, too,
       ;; so we need to remove.
       (let ((before (find-files "build" "\\.egg-info$" #:directories? #t)))
-        (call-setuppy test-target '() use-setuptools?)
-        (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
-               (inter (lset-difference eqv? after before)))
-          (for-each delete-file-recursively inter)))
-    #t))
+        (if (call-setuppy test-target '() use-setuptools?)
+            (let* ((after (find-files "build" "\\.egg-info$" #:directories? #t))
+                   (inter (lset-difference eqv? after before)))
+              (for-each delete-file-recursively inter)
+              #t)
+            #f))
+      (begin
+        (format #t "test suite not run~%")
+        #t)))
 
 (define (get-python-version python)
   (let* ((version     (last (string-split python #\-)))
-- 
2.11.0

bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1007 bytes --]

On Mon, Dec 12, 2016 at 08:54:40AM +0100, Marius Bakke wrote:
> The good news: the attached patch makes 'check' work as expected. The
> bad news is that we have some breakages.
> 
> 'python-py' fails with:
> 
> TypeError: py.test.__dict__ is not a dictionary
> 
> Which seems similar to
> 
> https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174165144

Yikes, I had hoped to avoid addressing that Nix issue and the humongous
"fix" for a while longer:

https://github.com/NixOS/nixpkgs/pull/12552

> I tried adding a newer setuptools as input, to no avail. Needs more
> investigation.

Okay, I'm happy to hear that it didn't work ;) My understanding is that
with the new python-build-system, packages are built with the setuptools
that comes with Python, not the external python-setuptools package.

Please let us know what you find.

Hartmut, any thoughts?

In any case, I think it's time to start working on a 'python-updates'
branch, which could include this patch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]

[Hartmut Goebel]

First of all thanks for spotting this bug.

>> The bad news is that we have some breakages.
>>
>> 'python-py' fails with:
>>
>> TypeError: py.test.__dict__ is not a dictionary
>>
>> Which seems similar to
>>
>> https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174165144

The relevant comment is
https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174196194:
Starting with version 18.4, setuptools will always try to execute a
test-suite (see
https://setuptools.readthedocs.io/en/latest/history.html#id186), which
will fail if there is none.

So the solution is to disable the test-suite for python-py, as there is
no test-suite which can be run via "setup.py test". For testing I added
"python-setuptools" (18.3.1) as native input. This made the "check"
phase run "0 tests" for python2-py and no tests at al for python-py.

(This package includes a test-suite (see tox.ini), but this test-suite
requires py.test, with itself requires python-py. So I suggest to
disable it.)

Our Python (3.5.2) comes with setuptools 20.10.1.

> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
> "fix" for a while longer:
>
> https://github.com/NixOS/nixpkgs/pull/12552

This puill-request is huge, but for setuptools, it comes down that they
updated from 18.2 to 19.4.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

bug#25177: Test failures don't cause some Python packages to fail [was Re: [PATCH 05/11] gnu: Add python-pygit2.]

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 2202 bytes --]

Hartmut Goebel <h.goebel@crazy-compilers.com> writes:

> First of all thanks for spotting this bug.
>
>>> The bad news is that we have some breakages.
>>>
>>> 'python-py' fails with:
>>>
>>> TypeError: py.test.__dict__ is not a dictionary
>>>
>>> Which seems similar to
>>>
>>> https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174165144
>
> The relevant comment is
> https://github.com/NixOS/nixpkgs/issues/12565#issuecomment-174196194:
> Starting with version 18.4, setuptools will always try to execute a
> test-suite (see
> https://setuptools.readthedocs.io/en/latest/history.html#id186), which
> will fail if there is none.
>
> So the solution is to disable the test-suite for python-py, as there is
> no test-suite which can be run via "setup.py test". For testing I added
> "python-setuptools" (18.3.1) as native input. This made the "check"
> phase run "0 tests" for python2-py and no tests at al for python-py.
>
> (This package includes a test-suite (see tox.ini), but this test-suite
> requires py.test, with itself requires python-py. So I suggest to
> disable it.)

I tried upgrading pytest to 3.0.5 and adding a variant that does not
propagate 'python-py' as input for the 'python-py' package. That got a
bit further, but it does not accept modules from the store!

"ImportError: 'test' module incorrectly imported from '/gnu/store/mwci3544rk71p131mgri5am0sxbz09a6-python-pytest-minimal-3.0.5/lib/python3.5/site-packages'. Expected '/tmp/guix-build-python-py-1.4.31.drv-0/py-1.4.31/py'. Is this module globally installed?"

Disabled tests for now.

> Our Python (3.5.2) comes with setuptools 20.10.1.

Is the 2.7 variant the same version? When adding "python-setuptools" as
native-input, is it guaranteed to override the bundled one?

>> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
>> "fix" for a while longer:
>>
>> https://github.com/NixOS/nixpkgs/pull/12552
>
> This puill-request is huge, but for setuptools, it comes down that they
> updated from 18.2 to 19.4.

Sounds like we're going down the same road. I've started a branch with
the earlier patch and a few other fixes. Is it ok to overwrite the
existing 'python-updates' branch on Savannah?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]


>>> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
>>> "fix" for a while longer:
>>>
>>> https://github.com/NixOS/nixpkgs/pull/12552
>>
>> This puill-request is huge, but for setuptools, it comes down that they
>> updated from 18.2 to 19.4.
>
> Sounds like we're going down the same road. I've started a branch with
> the earlier patch and a few other fixes. Is it ok to overwrite the
> existing 'python-updates' branch on Savannah?

There are some commits in python-updates that haven't made its way into
any other branches. I created a new branch 'python-tests' for this fix.

Please build and fix as much as possible. I'd like to get this merged
ASAP. @Leo can you start this branch on Hydra?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]

On Tue, Dec 13, 2016 at 09:21:44PM +0100, Marius Bakke wrote:
> 
> >>> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
> >>> "fix" for a while longer:
> >>>
> >>> https://github.com/NixOS/nixpkgs/pull/12552
> >>
> >> This puill-request is huge, but for setuptools, it comes down that they
> >> updated from 18.2 to 19.4.
> >
> > Sounds like we're going down the same road. I've started a branch with
> > the earlier patch and a few other fixes. Is it ok to overwrite the
> > existing 'python-updates' branch on Savannah?
> 
> There are some commits in python-updates that haven't made its way into
> any other branches. I created a new branch 'python-tests' for this fix.
> 
> Please build and fix as much as possible. I'd like to get this merged
> ASAP. @Leo can you start this branch on Hydra?

Several of the commit messages were truncated because of lines that
began with '#:tests?'. The '#' character creates a comment.

I fixed the commit messages with `git rebase`. This means that most of
the commits are now signed by me. I didn't change the commits
themselves.

The evaluation is pending:

https://hydra.gnu.org/jobset/gnu/python-tests

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1519 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Tue, Dec 13, 2016 at 09:21:44PM +0100, Marius Bakke wrote:
>> 
>> >>> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
>> >>> "fix" for a while longer:
>> >>>
>> >>> https://github.com/NixOS/nixpkgs/pull/12552
>> >>
>> >> This puill-request is huge, but for setuptools, it comes down that they
>> >> updated from 18.2 to 19.4.
>> >
>> > Sounds like we're going down the same road. I've started a branch with
>> > the earlier patch and a few other fixes. Is it ok to overwrite the
>> > existing 'python-updates' branch on Savannah?
>> 
>> There are some commits in python-updates that haven't made its way into
>> any other branches. I created a new branch 'python-tests' for this fix.
>> 
>> Please build and fix as much as possible. I'd like to get this merged
>> ASAP. @Leo can you start this branch on Hydra?
>
> Several of the commit messages were truncated because of lines that
> began with '#:tests?'. The '#' character creates a comment.

Oh my. Thanks for taking care of that, not sure how I missed it.

> I fixed the commit messages with `git rebase`. This means that most of
> the commits are now signed by me. I didn't change the commits
> themselves.
>
> The evaluation is pending:
>
> https://hydra.gnu.org/jobset/gnu/python-tests

Great, thanks! Looks like this is going to take a while. Once this is
done, should consider reviving 'python-updates' since some breakages
seem Python 3.5 specific.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1436 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Tue, Dec 13, 2016 at 09:21:44PM +0100, Marius Bakke wrote:
>> 
>> >>> Yikes, I had hoped to avoid addressing that Nix issue and the humongous
>> >>> "fix" for a while longer:
>> >>>
>> >>> https://github.com/NixOS/nixpkgs/pull/12552
>> >>
>> >> This puill-request is huge, but for setuptools, it comes down that they
>> >> updated from 18.2 to 19.4.
>> >
>> > Sounds like we're going down the same road. I've started a branch with
>> > the earlier patch and a few other fixes. Is it ok to overwrite the
>> > existing 'python-updates' branch on Savannah?
>> 
>> There are some commits in python-updates that haven't made its way into
>> any other branches. I created a new branch 'python-tests' for this fix.
>> 
>> Please build and fix as much as possible. I'd like to get this merged
>> ASAP. @Leo can you start this branch on Hydra?
>
> Several of the commit messages were truncated because of lines that
> began with '#:tests?'. The '#' character creates a comment.
>
> I fixed the commit messages with `git rebase`. This means that most of
> the commits are now signed by me. I didn't change the commits
> themselves.
>
> The evaluation is pending:
>
> https://hydra.gnu.org/jobset/gnu/python-tests

All failures from this run should be fixed, and then some. Can you
restart it?

@Hartmut, what was your command for building everything python? :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

On Thu, Dec 15, 2016 at 10:26:45AM +0100, Marius Bakke wrote:
> All failures from this run should be fixed, and then some. Can you
> restart it?

Done, thanks for working on this!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Thu, Dec 15, 2016 at 10:26:45AM +0100, Marius Bakke wrote:
>> All failures from this run should be fixed, and then some. Can you
>> restart it?
>
> Done, thanks for working on this!

Most of the current failures should now be fixed as well. Do you think
another Hydra run is necessary? I would like to merge this before the
release, so I think any remaining failures can be handled directly on
master for more visibility and testing. WDYT?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 1215 bytes --]

On Fri, Dec 16, 2016 at 03:02:20PM +0100, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Thu, Dec 15, 2016 at 10:26:45AM +0100, Marius Bakke wrote:
> >> All failures from this run should be fixed, and then some. Can you
> >> restart it?
> >
> > Done, thanks for working on this!
> 
> Most of the current failures should now be fixed as well. Do you think
> another Hydra run is necessary? I would like to merge this before the
> release, so I think any remaining failures can be handled directly on
> master for more visibility and testing. WDYT?

There are still ~4000 queued builds:

https://hydra.gnu.org/eval/109396?full=1#tabs-unfinished

I'd like to wait for it to be closer to done before merging.

I think it's okay to release without these changes because, in practice,
the bug in question doesn't cause problems for people who are using our
packages, right? My understanding is that people installing from 0.12.0
won't have large numbers of Python packages that fail to build, since we
are dealing with spurious test successes.

It's certainly not desirable to release with this bug, but will there be
"real" problems for users?

What do you think?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 1788 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Fri, Dec 16, 2016 at 03:02:20PM +0100, Marius Bakke wrote:
>> Leo Famulari <leo@famulari.name> writes:
>> 
>> > On Thu, Dec 15, 2016 at 10:26:45AM +0100, Marius Bakke wrote:
>> >> All failures from this run should be fixed, and then some. Can you
>> >> restart it?
>> >
>> > Done, thanks for working on this!
>> 
>> Most of the current failures should now be fixed as well. Do you think
>> another Hydra run is necessary? I would like to merge this before the
>> release, so I think any remaining failures can be handled directly on
>> master for more visibility and testing. WDYT?
>
> There are still ~4000 queued builds:
>
> https://hydra.gnu.org/eval/109396?full=1#tabs-unfinished
>
> I'd like to wait for it to be closer to done before merging.

I think that job can be cancelled and a new one started, since there
have been quite a few fixes since. I've now successfully built
`./pre-inst-env guix build $(guix package -A python | awk '{print $1}')`
locally, but there may still be some leaf packages that are failing.

> I think it's okay to release without these changes because, in practice,
> the bug in question doesn't cause problems for people who are using our
> packages, right? My understanding is that people installing from 0.12.0
> won't have large numbers of Python packages that fail to build, since we
> are dealing with spurious test successes.
>
> It's certainly not desirable to release with this bug, but will there be
> "real" problems for users?
>
> What do you think?

Yes, it would have to be merged now or wait until after the release.
Very few actual problems have been solved, and none in core packages.
So let's postpone this and focus on getting master in shape :-)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 965 bytes --]

On Sat, Dec 17, 2016 at 06:38:26PM +0100, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> > https://hydra.gnu.org/eval/109396?full=1#tabs-unfinished
> >
> > I'd like to wait for it to be closer to done before merging.
> 
> I think that job can be cancelled and a new one started, since there
> have been quite a few fixes since. I've now successfully built
> `./pre-inst-env guix build $(guix package -A python | awk '{print $1}')`
> locally, but there may still be some leaf packages that are failing.

I've canceled that evaluation and started another.

> > It's certainly not desirable to release with this bug, but will there be
> > "real" problems for users?
> >
> > What do you think?
> 
> Yes, it would have to be merged now or wait until after the release.
> Very few actual problems have been solved, and none in core packages.
> So let's postpone this and focus on getting master in shape :-)

Okay, sounds good :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 758 bytes --]

On Sat, Dec 17, 2016 at 12:56:21PM -0500, Leo Famulari wrote:
> On Sat, Dec 17, 2016 at 06:38:26PM +0100, Marius Bakke wrote:
> > Leo Famulari <leo@famulari.name> writes:
> > > https://hydra.gnu.org/eval/109396?full=1#tabs-unfinished
> > >
> > > I'd like to wait for it to be closer to done before merging.
> > 
> > I think that job can be cancelled and a new one started, since there
> > have been quite a few fixes since. I've now successfully built
> > `./pre-inst-env guix build $(guix package -A python | awk '{print $1}')`
> > locally, but there may still be some leaf packages that are failing.
> 
> I've canceled that evaluation and started another.

The evaluation failed:

https://hydra.gnu.org/jobset/gnu/python-tests#tabs-errors

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Sat, Dec 17, 2016 at 12:56:21PM -0500, Leo Famulari wrote:
>> On Sat, Dec 17, 2016 at 06:38:26PM +0100, Marius Bakke wrote:
>> > Leo Famulari <leo@famulari.name> writes:
>> > > https://hydra.gnu.org/eval/109396?full=1#tabs-unfinished
>> > >
>> > > I'd like to wait for it to be closer to done before merging.
>> > 
>> > I think that job can be cancelled and a new one started, since there
>> > have been quite a few fixes since. I've now successfully built
>> > `./pre-inst-env guix build $(guix package -A python | awk '{print $1}')`
>> > locally, but there may still be some leaf packages that are failing.
>> 
>> I've canceled that evaluation and started another.
>
> The evaluation failed:
>
> https://hydra.gnu.org/jobset/gnu/python-tests#tabs-errors

Whoops. Fixed in 7b6ff42aa3cf9398213d3c1f0e5f87c45a9730df.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

On Sun, Dec 18, 2016 at 12:47:59AM +0100, Marius Bakke wrote:
> Whoops. Fixed in 7b6ff42aa3cf9398213d3c1f0e5f87c45a9730df.

Thanks! I started a new evaluation.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Sun, Dec 18, 2016 at 12:47:59AM +0100, Marius Bakke wrote:
>> Whoops. Fixed in 7b6ff42aa3cf9398213d3c1f0e5f87c45a9730df.
>
> Thanks! I started a new evaluation.

Looks like this one timed out:

https://hydra.gnu.org/jobset/gnu/python-tests#tabs-errors

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 421 bytes --]

On Sun, Dec 18, 2016 at 07:55:54PM +0100, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Sun, Dec 18, 2016 at 12:47:59AM +0100, Marius Bakke wrote:
> >> Whoops. Fixed in 7b6ff42aa3cf9398213d3c1f0e5f87c45a9730df.
> >
> > Thanks! I started a new evaluation.
> 
> Looks like this one timed out:
> 
> https://hydra.gnu.org/jobset/gnu/python-tests#tabs-errors

Bah, I started a new one.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 694 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Sun, Dec 18, 2016 at 07:55:54PM +0100, Marius Bakke wrote:
>> Leo Famulari <leo@famulari.name> writes:
>> 
>> > On Sun, Dec 18, 2016 at 12:47:59AM +0100, Marius Bakke wrote:
>> >> Whoops. Fixed in 7b6ff42aa3cf9398213d3c1f0e5f87c45a9730df.
>> >
>> > Thanks! I started a new evaluation.
>> 
>> Looks like this one timed out:
>> 
>> https://hydra.gnu.org/jobset/gnu/python-tests#tabs-errors
>
> Bah, I started a new one.

Did this one get cancelled? Perhaps we should merge this to 'staging'
and deal with any remaining failures when that is ready to be evaluated.

I believe the vast majority of python packages are now "fixed".

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]

On Tue, Dec 20, 2016 at 07:49:59PM +0100, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> > Bah, I started a new one.
> 
> Did this one get cancelled? Perhaps we should merge this to 'staging'
> and deal with any remaining failures when that is ready to be evaluated.

Yes, it looks like that, although I don't know the exact reason. Hydra
has lots of resource management and stability problems.

I guess the python-tests jobset was canceled to free some resources for
the release-0.12.0 jobset.

I'd like to restart python-tests after 0.12.0 is released.

> I believe the vast majority of python packages are now "fixed".

Thank you!

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Marius Bakke]

[-- Attachment #1: Type: text/plain, Size: 708 bytes --]

Leo Famulari <leo@famulari.name> writes:

> On Tue, Dec 20, 2016 at 07:49:59PM +0100, Marius Bakke wrote:
>> Leo Famulari <leo@famulari.name> writes:
>> > Bah, I started a new one.
>> 
>> Did this one get cancelled? Perhaps we should merge this to 'staging'
>> and deal with any remaining failures when that is ready to be evaluated.
>
> Yes, it looks like that, although I don't know the exact reason. Hydra
> has lots of resource management and stability problems.
>
> I guess the python-tests jobset was canceled to free some resources for
> the release-0.12.0 jobset.
>
> I'd like to restart python-tests after 0.12.0 is released.

Should we try to evaluate this branch before staging?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 487 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 848 bytes --]

On Sat, Dec 24, 2016 at 02:43:38PM +0100, Marius Bakke wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Tue, Dec 20, 2016 at 07:49:59PM +0100, Marius Bakke wrote:
> >> Leo Famulari <leo@famulari.name> writes:
> >> > Bah, I started a new one.
> >> 
> >> Did this one get cancelled? Perhaps we should merge this to 'staging'
> >> and deal with any remaining failures when that is ready to be evaluated.
> >
> > Yes, it looks like that, although I don't know the exact reason. Hydra
> > has lots of resource management and stability problems.
> >
> > I guess the python-tests jobset was canceled to free some resources for
> > the release-0.12.0 jobset.
> >
> > I'd like to restart python-tests after 0.12.0 is released.
> 
> Should we try to evaluate this branch before staging?

Yes, I just started a new evaluation.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 437 bytes --]

On Sat, Dec 24, 2016 at 11:26:37AM -0500, Leo Famulari wrote:
> On Sat, Dec 24, 2016 at 02:43:38PM +0100, Marius Bakke wrote:
> > Should we try to evaluate this branch before staging?
> 
> Yes, I just started a new evaluation.

There are still some failing packages that we need to address:

https://hydra.gnu.org/eval/109407?compare=master&full=1

... but I haven't had time to look at them individually.

In a few days :)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

bug#25177: Test failures don't cause some Python packages to fail

[Hartmut Goebel]

Am 15.12.2016 um 10:26 schrieb Marius Bakke:
> @Hartmut, what was your command for building everything python? :-)

I have a script for this :-) But maybe there is a more inteligent way like:

guix refresh -l python | sed 's/.*: //' | xargs guix build --keep-going

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel@crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Removing the python-updates branch [was Re: bug#25177: Test failures don't cause some Python packages to fail]

[Leo Famulari]

[-- Attachment #1: Type: text/plain, Size: 442 bytes --]

On Tue, Dec 13, 2016 at 10:34:03AM +0100, Marius Bakke wrote:
> Sounds like we're going down the same road. I've started a branch with
> the earlier patch and a few other fixes. Is it ok to overwrite the
> existing 'python-updates' branch on Savannah?

I'm going to delete that old branch tomorrow if there are no objections.
I started it before I knew the magnitude of the work required, and I
think it will be easier to start from scratch.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[PATCH 06/11] gnu: Add python2-openid.

[ng0]

* gnu/packages/python.scm (python2-openid): New variable.
---
 gnu/packages/python.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 32f83deb4..6f3e75001 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5011,6 +5011,27 @@ features useful for text console applications.")
 (define-public python2-urwid
   (package-with-python2 python-urwid))
 
+(define-public python2-openid
+  (package
+    (name "python2-openid")
+    (version "2.2.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/openid/"
+                           "python-openid/archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1rkgsx1cxb85zl8jkaqmnbhdm3rvs8qcvv3z0k6jwmgkwi0kda1z"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2)) ; No Python 3 support.
+    (home-page "https://github.com/openid/python-openid")
+    (synopsis "OpenID support for servers and consumers")
+    (description "OpenID library for Python.")
+    (license license:asl2.0)))
+
 (define-public python-urwidtrees
   (package
     (name "python-urwidtrees")
-- 
2.11.0

[PATCH 07/11] gnu: Add python-openid-cla.

[ng0]

* gnu/packages/python.scm (python-openid-cla): New variable.
---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 6f3e75001..24e17522a 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5265,6 +5265,31 @@ another XPath engine to find the matching elements in an XML or HTML document.")
 (define-public python2-cssselect
   (package-with-python2 python-cssselect))
 
+(define-public python-openid-cla
+  (package
+    (name "python-openid-cla")
+    (version "1.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/puiterwijk/"
+                           "python-openid-cla/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "18iri5zls94fa4wk1r7hyk4mr9z669km4g1858yrnq64dkr13a0w"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/puiterwijk/python-openid-cla/")
+    (synopsis "Implementation of the OpenID cla extension for python-openid")
+    (description
+     "@code{openid-cla} is an implementation of the OpenID cla
+extension for python-openid.")
+    (license license:bsd-3)))
+
+(define-public python2-openid-cla
+  (package-with-python2 python-openid-cla))
+
 (define-public python-netifaces
   (package
     (name "python-netifaces")
-- 
2.11.0

[PATCH 08/11] gnu: Add python-openid-teams.

[ng0]

* gnu/packages/python.scm (python-openid-teams): New variable.
---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 24e17522a..8740ed2c9 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5290,6 +5290,31 @@ extension for python-openid.")
 (define-public python2-openid-cla
   (package-with-python2 python-openid-cla))
 
+(define-public python-openid-teams
+  (package
+    (name "python-openid-teams")
+    (version "1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/puiterwijk/"
+                           "python-openid-teams/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "08m26gsikibfawr5hn01gh8q2f9csrwjqi9jliyln4cdwvz318xw"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/puiterwijk/python-openid-teams/")
+    (synopsis "Implementation of the OpenID teams extension for python-openid")
+    (description
+     "@code{openid-teams} is an implementation of the OpenID
+teams extension for python-openid.")
+    (license license:bsd-3)))
+
+(define-public python2-openid-teams
+  (package-with-python2 python-openid-teams))
+
 (define-public python-netifaces
   (package
     (name "python-netifaces")
-- 
2.11.0

[PATCH 09/11] gnu: Add python-straight.plugin.

[ng0]

* gnu/packages/python.scm (python-straight.plugin): New variable.
---
 gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 8740ed2c9..45451af74 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5982,6 +5982,33 @@ term.js Javascript terminal emulator library.")
           ,python2-backport-ssl-match-hostname)
           ,@(package-propagated-inputs terminado))))))
 
+(define-public python-straight.plugin
+  (package
+    (name "python-straight.plugin")
+    (version "1.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/ironfroggy/"
+                           "straight.plugin/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0yy7ymng4d2dgqg81dz48b176zarbk1il7ig1m1q8zl8l559n817"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/ironfroggy/straight.plugin")
+    (synopsis "Simple namespaced plugin facility")
+    (description
+     "Straight Plugin provides a type of plugin you can create
+from almost any existing Python modules, and an easy way for
+outside developers to add functionality and customization to
+your projects with their own plugins.")
+    (license license:expat)))
+
+(define-public python2-straight.plugin
+  (package-with-python2 python-straight.plugin))
+
 (define-public python-fonttools
   (package
     (name "python-fonttools")
-- 
2.11.0

[PATCH 10/11] gnu: Add python-trollius-redis.

[ng0]

* gnu/packages/python.scm (python-trollius-redis): New variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 45451af74..11800b359 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8004,6 +8004,29 @@ minimal and fast API targetting the following uses:
 (define-public python2-execnet
   (package-with-python2 python-execnet))
 
+(define-public python-trollius-redis
+(package
+  (name "python-trollius-redis")
+  (version "0.1.4")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "trollius_redis" version))
+      (sha256
+       (base32
+        "0k3vypszmgmaipgw9xscvgm79h2zd6p6ci8gdp5sxl6g5kbqr9fy"))))
+  (build-system python-build-system)
+  (home-page "https://github.com/benjolitz/trollius-redis")
+  (synopsis "Port of asyncio-redis to trollius")
+  (description
+   "@code{trollius-redis} is a Redis client for Python
+trollius.  It is a PEP 3156 implementation of the redis
+protocol.")
+  (license license:bsd-2)))
+
+(define-public python2-trollius-redis
+  (package-with-python2 python-trollius-redis))
+
 ;;; The software provided by this package was integrated into pytest 2.8.
 (define-public python-pytest-cache
   (package
-- 
2.11.0

[PATCH 11/11] gnu: Add pagure.

[ng0]

* gnu/packages/version-control.scm (pagure): New variable.
---
 gnu/packages/version-control.scm | 81 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 80 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index f6845fab0..1eee6ad87 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -10,7 +10,7 @@
 ;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
-;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016 ng0 <ng0@libertad.pw>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1265,3 +1265,82 @@ a built-in wiki, built-in file browsing, built-in tickets system, etc.")
     (description "Stagit creates static pages for git repositories, the results can
 be served with a HTTP file server of your choice.")
     (license license:expat)))
+
+(define-public pagure
+  (package
+    (name "pagure")
+    (version "2.10.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (list
+             ;; XXX: upstream serves an invalid certificate.
+             (string-append "https://web.archive.org/web/20161211142731/"
+                            "https://releases.pagure.org/pagure/pagure-"
+                            version ".tar.gz")
+             (string-append "https://releases.pagure.org/pagure/"
+                                 name "-" version ".tar.gz")))
+       (sha256
+        (base32
+         "1h629hd8wfvdnmlrd1g3hpxcgkqzrxdpnxnmqhd2wi04g86pn7pg"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'install-additional-files
+           ;; We need to copy files.
+           (lambda* (#:key outputs #:allow-other-keys)
+             (install-file "files/pagure.cfg.sample"
+                           (string-append (assoc-ref outputs "out") "/etc/pagure/"))
+             (install-file "files/alembic.ini"
+                           (string-append (assoc-ref outputs "out") "/etc/pagure/"))
+             (install-file "files/pagure.conf"
+                           (string-append (assoc-ref outputs "out") "/etc/httpd/conf.d/"))
+             (install-file "files/pagure.wsgi"
+                           (string-append (assoc-ref outputs "out") "/share/pagure/"))
+             (install-file "createdb.py"
+                           (string-append (assoc-ref outputs "out") "/share/pagure/"))
+             #t)))))
+    (propagated-inputs
+     `(("python2-alembic" ,python2-alembic)
+       ("python2-arrow" ,python2-arrow)
+       ("python2-binaryornot" ,python2-binaryornot)
+       ("python2-bleach" ,python2-bleach)
+       ("python2-blinker" ,python2-blinker)
+       ("python2-chardet" ,python2-chardet)
+       ("python2-docutils" ,python2-docutils)
+       ("python2-enum34" ,python2-enum34)
+       ("python2-flask" ,python2-flask)
+       ("python2-flask-wtf" ,python2-flask-wtf)
+       ("python2-flask-multistatic" ,python2-flask-multistatic)
+       ("python2-kitchen" ,python2-kitchen)
+       ("python2-markdown" ,python2-markdown)
+       ("python2-munch" ,python2-munch)
+       ("python2-pillow" ,python2-pillow)
+       ("python2-psutil" ,python2-psutil)
+       ;; pyclamd ; only for VIRUS_SCAN_ATTACHMENTS
+       ("python2-pygit2" ,python2-pygit2)
+       ("python2-pygments" ,python2-pygments)
+       ("python2-openid" ,python2-openid)
+       ("python2-openid-cla" ,python2-openid-cla)
+       ("python2-openid-teams" ,python2-openid-teams)
+       ("python2-redis" ,python2-redis)
+       ("python2-six" ,python2-six)
+       ("python2-sqlalchemy" ,python2-sqlalchemy)
+       ("python2-straight.plugin" ,python2-straight.plugin)
+       ("python2-trollius-redis" ,python2-trollius-redis)
+       ("python2-wtforms" ,python2-wtforms)
+       ("python2-cryptography" ,python2-cryptography)
+       ;; TODO: python2-fedora ;for fas and openid auth backends
+       ("python2-py-bcrypt" ,python2-py-bcrypt)))
+    (home-page "https://pagure.io/pagure/")
+    (synopsis "Git-centered forge based on pygit2")
+    (description
+     "Pagure is a git-centered forge, python based using pygit2.
+With pagure you can host your project with its documentation,
+let your users report issues or request enhancements using the
+ticketing system and build your community of contributors by
+allowing them to fork your projects and contribute to it via
+the now-popular pull-request mechanism.")
+    (license license:gpl2+)))
-- 
2.11.0

Re: [PATCH 11/11] gnu: Add pagure.

[ng0]

ng0 <ng0@libertad.pw> writes:

> * gnu/packages/version-control.scm (pagure): New variable.
> ---
>  gnu/packages/version-control.scm | 81 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 80 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index f6845fab0..1eee6ad87 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -10,7 +10,7 @@
>  ;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
>  ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
>  ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
> -;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
> +;;; Copyright © 2016 ng0 <ng0@libertad.pw>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1265,3 +1265,82 @@ a built-in wiki, built-in file browsing, built-in tickets system, etc.")
>      (description "Stagit creates static pages for git repositories, the results can
>  be served with a HTTP file server of your choice.")
>      (license license:expat)))
> +
> +(define-public pagure
> +  (package
> +    (name "pagure")
> +    (version "2.10.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (list
> +             ;; XXX: upstream serves an invalid certificate.
> +             (string-append "https://web.archive.org/web/20161211142731/"
> +                            "https://releases.pagure.org/pagure/pagure-"
> +                            version ".tar.gz")
> +             (string-append "https://releases.pagure.org/pagure/"
> +                                 name "-" version ".tar.gz")))

Please add this when commiting:
XXX: The certificate issue upstream https://pagure.io/fedora-infrastructure/issue/5600

Thanks!

> +       (sha256
> +        (base32
> +         "1h629hd8wfvdnmlrd1g3hpxcgkqzrxdpnxnmqhd2wi04g86pn7pg"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'install-additional-files
> +           ;; We need to copy files.
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (install-file "files/pagure.cfg.sample"
> +                           (string-append (assoc-ref outputs "out") "/etc/pagure/"))
> +             (install-file "files/alembic.ini"
> +                           (string-append (assoc-ref outputs "out") "/etc/pagure/"))
> +             (install-file "files/pagure.conf"
> +                           (string-append (assoc-ref outputs "out") "/etc/httpd/conf.d/"))
> +             (install-file "files/pagure.wsgi"
> +                           (string-append (assoc-ref outputs "out") "/share/pagure/"))
> +             (install-file "createdb.py"
> +                           (string-append (assoc-ref outputs "out") "/share/pagure/"))
> +             #t)))))
> +    (propagated-inputs
> +     `(("python2-alembic" ,python2-alembic)
> +       ("python2-arrow" ,python2-arrow)
> +       ("python2-binaryornot" ,python2-binaryornot)
> +       ("python2-bleach" ,python2-bleach)
> +       ("python2-blinker" ,python2-blinker)
> +       ("python2-chardet" ,python2-chardet)
> +       ("python2-docutils" ,python2-docutils)
> +       ("python2-enum34" ,python2-enum34)
> +       ("python2-flask" ,python2-flask)
> +       ("python2-flask-wtf" ,python2-flask-wtf)
> +       ("python2-flask-multistatic" ,python2-flask-multistatic)
> +       ("python2-kitchen" ,python2-kitchen)
> +       ("python2-markdown" ,python2-markdown)
> +       ("python2-munch" ,python2-munch)
> +       ("python2-pillow" ,python2-pillow)
> +       ("python2-psutil" ,python2-psutil)
> +       ;; pyclamd ; only for VIRUS_SCAN_ATTACHMENTS
> +       ("python2-pygit2" ,python2-pygit2)
> +       ("python2-pygments" ,python2-pygments)
> +       ("python2-openid" ,python2-openid)
> +       ("python2-openid-cla" ,python2-openid-cla)
> +       ("python2-openid-teams" ,python2-openid-teams)
> +       ("python2-redis" ,python2-redis)
> +       ("python2-six" ,python2-six)
> +       ("python2-sqlalchemy" ,python2-sqlalchemy)
> +       ("python2-straight.plugin" ,python2-straight.plugin)
> +       ("python2-trollius-redis" ,python2-trollius-redis)
> +       ("python2-wtforms" ,python2-wtforms)
> +       ("python2-cryptography" ,python2-cryptography)
> +       ;; TODO: python2-fedora ;for fas and openid auth backends
> +       ("python2-py-bcrypt" ,python2-py-bcrypt)))
> +    (home-page "https://pagure.io/pagure/")
> +    (synopsis "Git-centered forge based on pygit2")
> +    (description
> +     "Pagure is a git-centered forge, python based using pygit2.
> +With pagure you can host your project with its documentation,
> +let your users report issues or request enhancements using the
> +ticketing system and build your community of contributors by
> +allowing them to fork your projects and contribute to it via
> +the now-popular pull-request mechanism.")
> +    (license license:gpl2+)))
> -- 
> 2.11.0
>
>

-- 
♥Ⓐ  ng0  | ng0.chaosnet.org

Re: [PATCH 11/11] gnu: Add pagure.

[Leo Famulari]

On Sun, Dec 11, 2016 at 06:12:37PM +0000, ng0 wrote:
> * gnu/packages/version-control.scm (pagure): New variable.

> +         (add-after 'install 'install-additional-files
> +           ;; We need to copy files.

Can you give a little more detail about what these files are, why we
need them, etc?

> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (install-file "files/pagure.cfg.sample"
> +                           (string-append (assoc-ref outputs "out") "/etc/pagure/"))
> +             (install-file "files/alembic.ini"
> +                           (string-append (assoc-ref outputs "out") "/etc/pagure/"))
> +             (install-file "files/pagure.conf"
> +                           (string-append (assoc-ref outputs "out") "/etc/httpd/conf.d/"))
> +             (install-file "files/pagure.wsgi"
> +                           (string-append (assoc-ref outputs "out") "/share/pagure/"))
> +             (install-file "createdb.py"
> +                           (string-append (assoc-ref outputs "out") "/share/pagure/"))
> +             #t)))))

> +       ;; pyclamd ; only for VIRUS_SCAN_ATTACHMENTS

Is this a TODO package?

Re: [PATCH 11/11] gnu: Add pagure.

[Ricardo Wurmus]

Hi ng0,

thanks for the patch set!

> * gnu/packages/version-control.scm (pagure): New variable.
> ---
>  gnu/packages/version-control.scm | 81 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 80 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
> index f6845fab0..1eee6ad87 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -10,7 +10,7 @@
>  ;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
>  ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
>  ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
> -;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
> +;;; Copyright © 2016 ng0 <ng0@libertad.pw>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -1265,3 +1265,82 @@ a built-in wiki, built-in file browsing, built-in tickets system, etc.")
>      (description "Stagit creates static pages for git repositories, the results can
>  be served with a HTTP file server of your choice.")
>      (license license:expat)))
> +
> +(define-public pagure
> +  (package
> +    (name "pagure")
> +    (version "2.10.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (list
> +             ;; XXX: upstream serves an invalid certificate.
> +             (string-append "https://web.archive.org/web/20161211142731/"
> +                            "https://releases.pagure.org/pagure/pagure-"
> +                            version ".tar.gz")
> +             (string-append "https://releases.pagure.org/pagure/"
> +                                 name "-" version ".tar.gz")))
> +       (sha256
> +        (base32
> +         "1h629hd8wfvdnmlrd1g3hpxcgkqzrxdpnxnmqhd2wi04g86pn7pg"))))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'install 'install-additional-files
> +           ;; We need to copy files.
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (install-file "files/pagure.cfg.sample"
> +                           (string-append (assoc-ref outputs "out") "/etc/pagure/"))
> +             (install-file "files/alembic.ini"
> +                           (string-append (assoc-ref outputs "out") "/etc/pagure/"))
> +             (install-file "files/pagure.conf"
> +                           (string-append (assoc-ref outputs "out") "/etc/httpd/conf.d/"))
> +             (install-file "files/pagure.wsgi"
> +                           (string-append (assoc-ref outputs "out") "/share/pagure/"))
> +             (install-file "createdb.py"
> +                           (string-append (assoc-ref outputs "out") "/share/pagure/"))

Are these files useful for us?  Or should this really be handled by a
service because the files are just examples?

> +             #t)))))
> +    (propagated-inputs

Is it really necessary to propagate these inputs?  Is this package used
as a Python library or does it provide executables?  In the latter case
the python-build-system takes care of wrapping executables, so that
propagation won’t be necessary.

> +     `(("python2-alembic" ,python2-alembic)
> +       ("python2-arrow" ,python2-arrow)
> +       ("python2-binaryornot" ,python2-binaryornot)
> +       ("python2-bleach" ,python2-bleach)
> +       ("python2-blinker" ,python2-blinker)
> +       ("python2-chardet" ,python2-chardet)
> +       ("python2-docutils" ,python2-docutils)
> +       ("python2-enum34" ,python2-enum34)
> +       ("python2-flask" ,python2-flask)
> +       ("python2-flask-wtf" ,python2-flask-wtf)
> +       ("python2-flask-multistatic" ,python2-flask-multistatic)
> +       ("python2-kitchen" ,python2-kitchen)
> +       ("python2-markdown" ,python2-markdown)
> +       ("python2-munch" ,python2-munch)
> +       ("python2-pillow" ,python2-pillow)
> +       ("python2-psutil" ,python2-psutil)
> +       ;; pyclamd ; only for VIRUS_SCAN_ATTACHMENTS
> +       ("python2-pygit2" ,python2-pygit2)
> +       ("python2-pygments" ,python2-pygments)
> +       ("python2-openid" ,python2-openid)
> +       ("python2-openid-cla" ,python2-openid-cla)
> +       ("python2-openid-teams" ,python2-openid-teams)
> +       ("python2-redis" ,python2-redis)
> +       ("python2-six" ,python2-six)
> +       ("python2-sqlalchemy" ,python2-sqlalchemy)
> +       ("python2-straight.plugin" ,python2-straight.plugin)

Unusual name.  If you added this package please make sure to rename it
to “python2-straight-plugin” (no “.” in package names).

> +       ("python2-trollius-redis" ,python2-trollius-redis)
> +       ("python2-wtforms" ,python2-wtforms)
> +       ("python2-cryptography" ,python2-cryptography)
> +       ;; TODO: python2-fedora ;for fas and openid auth backends
> +       ("python2-py-bcrypt" ,python2-py-bcrypt)))
> +    (home-page "https://pagure.io/pagure/")
> +    (synopsis "Git-centered forge based on pygit2")

What is a forge?

> +    (description
> +     "Pagure is a git-centered forge, python based using pygit2.

“Python-based”

> +With pagure you can host your project with its documentation,
> +let your users report issues or request enhancements using the
> +ticketing system and build your community of contributors by
> +allowing them to fork your projects and contribute to it via

“projects” is plural, so I’m not sure what “contribute to it” (singular)
refers to.

> +the now-popular pull-request mechanism.")

I’d remove “now-popular”.

> +    (license license:gpl2+)))


-- 
Ricardo
  
  GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
  http://elephly.net

Re: [PATCH] Add pagure SCM/forge

[Leo Famulari]

On Sun, Dec 11, 2016 at 06:12:26PM +0000, ng0 wrote:
> [PATCH 01/11] gnu: Add python-flask-wtf.
> [PATCH 02/11] gnu: Add python-flask-multistatic.
> [PATCH 03/11] gnu: Add python-kitchen.
> [PATCH 04/11] gnu: Add python-munch.
> [PATCH 05/11] gnu: Add python-pygit2.
> [PATCH 06/11] gnu: Add python2-openid.
> [PATCH 07/11] gnu: Add python-openid-cla.
> [PATCH 08/11] gnu: Add python-openid-teams.
> [PATCH 09/11] gnu: Add python-straight.plugin.
> [PATCH 10/11] gnu: Add python-trollius-redis.
> [PATCH 11/11] gnu: Add pagure.

Awesome!

I sent a few comments about licenses. Can you check those and send
updated patches if necessary?

I also noticed a few packages that pull their source from GitHub even
though it is available on PyPi, like python-openid-teams:

https://pypi.python.org/pypi/python-openid-teams

Is there a reason for that? If not, can you make sure to use the PyPi
source code instead?

Thanks!

Re: [PATCH] Add pagure SCM/forge

[ng0]

Leo Famulari <leo@famulari.name> writes:

> On Sun, Dec 11, 2016 at 06:12:26PM +0000, ng0 wrote:
>> [PATCH 01/11] gnu: Add python-flask-wtf.
>> [PATCH 02/11] gnu: Add python-flask-multistatic.
>> [PATCH 03/11] gnu: Add python-kitchen.
>> [PATCH 04/11] gnu: Add python-munch.
>> [PATCH 05/11] gnu: Add python-pygit2.
>> [PATCH 06/11] gnu: Add python2-openid.
>> [PATCH 07/11] gnu: Add python-openid-cla.
>> [PATCH 08/11] gnu: Add python-openid-teams.
>> [PATCH 09/11] gnu: Add python-straight.plugin.
>> [PATCH 10/11] gnu: Add python-trollius-redis.
>> [PATCH 11/11] gnu: Add pagure.
>
> Awesome!
>
> I sent a few comments about licenses. Can you check those and send
> updated patches if necessary?
>
> I also noticed a few packages that pull their source from GitHub even
> though it is available on PyPi, like python-openid-teams:
>
> https://pypi.python.org/pypi/python-openid-teams
>
> Is there a reason for that? If not, can you make sure to use the PyPi
> source code instead?
>
> Thanks!
>

Wasn't it like when the source is on github or somewhere else
upstream, we should loose the dependency on pypi infrastructure
and use that upstream? That's why I changed source where
possible.

I can send the updates when I'm back from Berlin, late Wednesday
- Thursday'ish

Thanks for your review.
-- 
♥Ⓐ  ng0  | ng0.chaosnet.org

Re: [PATCH] Add pagure SCM/forge

[Leo Famulari]

On Mon, Dec 12, 2016 at 09:21:44AM +0000, ng0 wrote:
> Leo Famulari <leo@famulari.name> writes:
> > I also noticed a few packages that pull their source from GitHub even
> > though it is available on PyPi, like python-openid-teams:
> >
> > https://pypi.python.org/pypi/python-openid-teams
> >
> > Is there a reason for that? If not, can you make sure to use the PyPi
> > source code instead?
> 
> Wasn't it like when the source is on github or somewhere else
> upstream, we should loose the dependency on pypi infrastructure
> and use that upstream? That's why I changed source where
> possible.

Hm, I hadn't heard about this, but I could have missed something :)

I thought we were still using PyPi wherever possible because we have
useful import and update tools for package sources hosted on PyPi.

> I can send the updates when I'm back from Berlin, late Wednesday
> - Thursday'ish

Sounds good!

[PATCH] series: Add pagure (v2).

[ng0]

Applied the feedback, thanks.
Regarding the extra files, read the changed comment and
the link I included. It's my understanding that this will help
people to use pagure. My intention is to write a service for it,
so I do not need the sample files, but it might serve as a
reference for systems which are not GuixSD.

[PATCH 01/11] gnu: Add python-flask-wtf.

[ng0]

* gnu/packages/python.scm (python-flask-wtf): New variable.
---
 gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 6d6d880bb..763e452f1 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9236,6 +9236,33 @@ presume or force a developer to use a particular tool or library.")
 (define-public python2-flask
   (package-with-python2 python-flask))
 
+(define-public python-flask-wtf
+  (package
+    (name "python-flask-wtf")
+    (version "0.13.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "Flask-WTF" version))
+       (sha256
+        (base32
+         "04l5743j2dici46038sqlzvf0xzpg8rf7s9ld2x24xv7f4idg990"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-flask-babel" ,python-flask-babel)))
+    (native-inputs
+     `(("python-nose" ,python-nose)
+       ("python-wtforms" ,python-wtforms)))
+  (home-page "https://github.com/lepture/flask-wtf")
+  (synopsis "Simple integration of Flask and WTForms")
+  (description
+   "Simple integration of Flask and WTForms, including CSRF,
+file upload, and reCAPTCHA.")
+  (license license:bsd-3)))
+
+(define-public python2-flask-wtf
+  (package-with-python2 python-flask-wtf))
+
 (define-public python-cookies
   (package
     (name "python-cookies")
-- 
2.11.0

[PATCH 02/11] gnu: Add python-flask-multistatic.

[ng0]

* gnu/packages/python.scm (python-flask-multistatic): New variable.
---
 gnu/packages/python.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 763e452f1..b324f993e 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9263,6 +9263,30 @@ file upload, and reCAPTCHA.")
 (define-public python2-flask-wtf
   (package-with-python2 python-flask-wtf))
 
+(define-public python-flask-multistatic
+  (package
+    (name "python-flask-multistatic")
+    (version "1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "flask-multistatic" version))
+       (sha256
+        (base32
+         "0p4v50rwv64wcd0zlq7rzl4waprwr4hj19s3cgf1isywa7jcisgm"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-flask" ,python-flask)))
+    (home-page "https://pagure.io/flask-multistatic")
+    (synopsis "Flask plugin to allow overriding static files")
+    (description
+     "@code{flask-multistatic} is a simple plugin to add
+support for overriding static files to flask.")
+    (license license:gpl3+)))
+
+(define-public python2-flask-multistatic
+  (package-with-python2 python-flask-multistatic))
+
 (define-public python-cookies
   (package
     (name "python-cookies")
-- 
2.11.0

[PATCH 03/11] gnu: Add python-kitchen.

[ng0]

* gnu/packages/python.scm (python-kitchen): New variable.
---
 gnu/packages/python.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index b324f993e..9ebdbc420 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -2436,6 +2436,38 @@ version numbers.")
              (propagated-inputs
               `(("python2-functools32" ,python2-functools32))))))
 
+(define-public python-kitchen
+  (package
+    (name "python-kitchen")
+    (version "1.2.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/fedora-infra/"
+                           "kitchen/archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1ybx8nccbh6j1v6xj60j8dkbwnhlj0i1hizfrxzcdvrm9wn6a8wa"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-chardet" ,python-chardet)))
+    (home-page "https://fedorahosted.org/kitchen")
+    (synopsis "Python API for snippets")
+    (description
+     "@code{kitchen} module provides a python API for all sorts
+of little useful snippets of code that everybody ends up
+writing for their projects but never seem big enough to build
+an independent release.  Use kitchen and stop cutting and
+pasting that code over and over.")
+    (license (list license:lgpl2.1+
+                   ;; subprocess.py, test_subprocess.py,
+                   ;; kitchen/pycompat25/defaultdict.py:
+                   license:psfl))))
+
+(define-public python2-kitchen
+  (package-with-python2 python-kitchen))
+
 (define-public python-unidecode
   (package
     (name "python-unidecode")
-- 
2.11.0

[PATCH 04/11] gnu: Add python-munch.

[ng0]

* gnu/packages/python.scm (python-munch): New variable.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 9ebdbc420..8578b917b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3260,6 +3260,28 @@ capabilities.")
 (define python2-numpy-bootstrap
   (package-with-python2 python-numpy-bootstrap))
 
+(define-public python-munch
+  (package
+    (name "python-munch")
+    (version "2.0.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "munch" version))
+       (sha256
+        (base32
+         "1cmqg91xnqx8gvnh4pmp0bfl1dfcm65d5p9mg73zz8pkjhx6h80l"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/Infinidat/munch")
+    (synopsis "Dot-accessible dictionary")
+    (description
+     "Munch is a dot-accessible dictionary similar to
+JavaScript objects.")
+    (license license:expat)))
+
+(define-public python2-munch
+  (package-with-python2 python-munch))
+
 (define-public python2-fastlmm
   (package
     (name "python2-fastlmm")
-- 
2.11.0

[PATCH 05/11] gnu: Add python-pygit2.

[ng0]

* gnu/packages/python.scm (python-pygit2): New variable.
---
 gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 8578b917b..c28dac0f8 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3379,6 +3379,36 @@ association studies (GWAS) on extremely large data sets.")
 (define-public python2-numpy
   (package-with-python2 python-numpy))
 
+(define-public python-pygit2
+  (package
+    (name "python-pygit2")
+    (version "0.24.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/libgit2/"
+                           "pygit2/archive/v" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1j7zkz2bsn4wqmkg1zkxb3r00xx28rkz9jdwcsikcl4ffa298xwa"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-six" ,python-six)
+       ("python-cffi" ,python-cffi)
+       ("libgit2" ,libgit2)
+       ("python-tox" ,python-tox)))
+    (home-page "http://github.com/libgit2/pygit2")
+    (synopsis "Python bindings for libgit2")
+    (description
+     "Pygit2 is a set of Python bindings to the libgit2
+shared library, libgit2 implements Git plumbing.")
+    ;; GPL2.0 only, with linking exception.
+    (license license:gpl2)))
+
+(define-public python2-pygit2
+  (package-with-python2 python-pygit2))
+
 (define-public python-pyparsing
   (package
     (name "python-pyparsing")
-- 
2.11.0

[PATCH 06/11] gnu: Add python2-openid.

[ng0]

* gnu/packages/python.scm (python2-openid): New variable.
---
 gnu/packages/python.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index c28dac0f8..ca5201f33 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5055,6 +5055,27 @@ features useful for text console applications.")
 (define-public python2-urwid
   (package-with-python2 python-urwid))
 
+(define-public python2-openid
+  (package
+    (name "python2-openid")
+    (version "2.2.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/openid/"
+                           "python-openid/archive/" version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "1rkgsx1cxb85zl8jkaqmnbhdm3rvs8qcvv3z0k6jwmgkwi0kda1z"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2)) ; No Python 3 support.
+    (home-page "https://github.com/openid/python-openid")
+    (synopsis "OpenID support for servers and consumers")
+    (description "OpenID library for Python.")
+    (license license:asl2.0)))
+
 (define-public python-urwidtrees
   (package
     (name "python-urwidtrees")
-- 
2.11.0

[PATCH 07/11] gnu: Add python-openid-cla.

[ng0]

* gnu/packages/python.scm (python-openid-cla): New variable.
---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index ca5201f33..8246a33d5 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5309,6 +5309,31 @@ another XPath engine to find the matching elements in an XML or HTML document.")
 (define-public python2-cssselect
   (package-with-python2 python-cssselect))
 
+(define-public python-openid-cla
+  (package
+    (name "python-openid-cla")
+    (version "1.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/puiterwijk/"
+                           "python-openid-cla/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "18iri5zls94fa4wk1r7hyk4mr9z669km4g1858yrnq64dkr13a0w"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/puiterwijk/python-openid-cla/")
+    (synopsis "Implementation of the OpenID cla extension for python-openid")
+    (description
+     "@code{openid-cla} is an implementation of the OpenID cla
+extension for python-openid.")
+    (license license:bsd-3)))
+
+(define-public python2-openid-cla
+  (package-with-python2 python-openid-cla))
+
 (define-public python-netifaces
   (package
     (name "python-netifaces")
-- 
2.11.0

[PATCH 08/11] gnu: Add python-openid-teams.

[ng0]

* gnu/packages/python.scm (python-openid-teams): New variable.
---
 gnu/packages/python.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 8246a33d5..e7e10dc90 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5334,6 +5334,31 @@ extension for python-openid.")
 (define-public python2-openid-cla
   (package-with-python2 python-openid-cla))
 
+(define-public python-openid-teams
+  (package
+    (name "python-openid-teams")
+    (version "1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/puiterwijk/"
+                           "python-openid-teams/archive/v"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "08m26gsikibfawr5hn01gh8q2f9csrwjqi9jliyln4cdwvz318xw"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/puiterwijk/python-openid-teams/")
+    (synopsis "Implementation of the OpenID teams extension for python-openid")
+    (description
+     "@code{openid-teams} is an implementation of the OpenID
+teams extension for python-openid.")
+    (license license:bsd-3)))
+
+(define-public python2-openid-teams
+  (package-with-python2 python-openid-teams))
+
 (define-public python-netifaces
   (package
     (name "python-netifaces")
-- 
2.11.0

[PATCH 09/11] gnu: Add python-straight-plugin.

[ng0]

* gnu/packages/python.scm (python-straight-plugin): New variable.
---
 gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index e7e10dc90..b1bfc4850 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6026,6 +6026,33 @@ term.js Javascript terminal emulator library.")
           ,python2-backport-ssl-match-hostname)
           ,@(package-propagated-inputs terminado))))))
 
+(define-public python-straight-plugin
+  (package
+    (name "python-straight-plugin")
+    (version "1.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/ironfroggy/"
+                           "straight.plugin/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0yy7ymng4d2dgqg81dz48b176zarbk1il7ig1m1q8zl8l559n817"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/ironfroggy/straight.plugin")
+    (synopsis "Simple namespaced plugin facility")
+    (description
+     "Straight Plugin provides a type of plugin you can create
+from almost any existing Python modules, and an easy way for
+outside developers to add functionality and customization to
+your projects with their own plugins.")
+    (license license:expat)))
+
+(define-public python2-straight-plugin
+  (package-with-python2 python-straight-plugin))
+
 (define-public python-fonttools
   (package
     (name "python-fonttools")
-- 
2.11.0

[PATCH 10/11] gnu: Add python-trollius-redis.

[ng0]

* gnu/packages/python.scm (python-trollius-redis): New variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index b1bfc4850..1ff4bc8f6 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8048,6 +8048,29 @@ minimal and fast API targetting the following uses:
 (define-public python2-execnet
   (package-with-python2 python-execnet))
 
+(define-public python-trollius-redis
+(package
+  (name "python-trollius-redis")
+  (version "0.1.4")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "trollius_redis" version))
+      (sha256
+       (base32
+        "0k3vypszmgmaipgw9xscvgm79h2zd6p6ci8gdp5sxl6g5kbqr9fy"))))
+  (build-system python-build-system)
+  (home-page "https://github.com/benjolitz/trollius-redis")
+  (synopsis "Port of asyncio-redis to trollius")
+  (description
+   "@code{trollius-redis} is a Redis client for Python
+trollius.  It is a PEP 3156 implementation of the redis
+protocol.")
+  (license license:bsd-2)))
+
+(define-public python2-trollius-redis
+  (package-with-python2 python-trollius-redis))
+
 ;;; The software provided by this package was integrated into pytest 2.8.
 (define-public python-pytest-cache
   (package
-- 
2.11.0

[PATCH 11/11] gnu: Add pagure.

[ng0]

* gnu/packages/version-control.scm (pagure): New variable.
---
 gnu/packages/version-control.scm | 87 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 86 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 7918b90ca..3b8fecc38 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -10,7 +10,7 @@
 ;;; Copyright © 2015 Kyle Meyer <kyle@kyleam.com>
 ;;; Copyright © 2015 Ricardo Wurmus <rekado@elephly.net>
 ;;; Copyright © 2016 Leo Famulari <leo@famulari.name>
-;;; Copyright © 2016 ng0 <ng0@we.make.ritual.n0.is>
+;;; Copyright © 2016 ng0 <ng0@libertad.pw>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1263,3 +1263,88 @@ a built-in wiki, built-in file browsing, built-in tickets system, etc.")
     (description "Stagit creates static pages for git repositories, the results can
 be served with a HTTP file server of your choice.")
     (license license:expat)))
+
+(define-public pagure
+  (package
+    (name "pagure")
+    (version "2.10.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (list
+             ;; XXX: upstream serves an invalid certificate,
+             ;; https://pagure.io/fedora-infrastructure/issue/5600
+             (string-append "https://web.archive.org/web/20161211142731/"
+                            "https://releases.pagure.org/pagure/pagure-"
+                            version ".tar.gz")
+             (string-append "https://releases.pagure.org/pagure/"
+                                 name "-" version ".tar.gz")))
+       (sha256
+        (base32
+         "1h629hd8wfvdnmlrd1g3hpxcgkqzrxdpnxnmqhd2wi04g86pn7pg"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'install 'install-additional-files
+           ;; Copy the sample files as they can help setting up
+           ;; the service. This is a step mentioned at
+           ;; https://docs.pagure.org/pagure/install.html#installing-pagure-via-setup-py
+           (lambda* (#:key outputs #:allow-other-keys)
+             (install-file "files/pagure.cfg.sample"
+                           (string-append (assoc-ref outputs "out") "/etc/pagure/"))
+             (install-file "files/alembic.ini"
+                           (string-append (assoc-ref outputs "out") "/etc/pagure/"))
+             (install-file "files/pagure.conf"
+                           (string-append (assoc-ref outputs "out") "/etc/httpd/conf.d/"))
+             (install-file "files/pagure.wsgi"
+                           (string-append (assoc-ref outputs "out") "/share/pagure/"))
+             (install-file "createdb.py"
+                           (string-append (assoc-ref outputs "out") "/share/pagure/"))
+             #t)))))
+    (propagated-inputs
+     ;; There are no executables provided, it is all provided
+     ;; as a library.
+     `(("python2-alembic" ,python2-alembic)
+       ("python2-arrow" ,python2-arrow)
+       ("python2-binaryornot" ,python2-binaryornot)
+       ("python2-bleach" ,python2-bleach)
+       ("python2-blinker" ,python2-blinker)
+       ("python2-chardet" ,python2-chardet)
+       ("python2-docutils" ,python2-docutils)
+       ("python2-enum34" ,python2-enum34)
+       ("python2-flask" ,python2-flask)
+       ("python2-flask-wtf" ,python2-flask-wtf)
+       ("python2-flask-multistatic" ,python2-flask-multistatic)
+       ("python2-kitchen" ,python2-kitchen)
+       ("python2-markdown" ,python2-markdown)
+       ("python2-munch" ,python2-munch)
+       ("python2-pillow" ,python2-pillow)
+       ("python2-psutil" ,python2-psutil)
+       ;; TODO: pyclamd ; only for VIRUS_SCAN_ATTACHMENTS
+       ("python2-pygit2" ,python2-pygit2)
+       ("python2-pygments" ,python2-pygments)
+       ("python2-openid" ,python2-openid)
+       ("python2-openid-cla" ,python2-openid-cla)
+       ("python2-openid-teams" ,python2-openid-teams)
+       ("python2-redis" ,python2-redis)
+       ("python2-six" ,python2-six)
+       ("python2-sqlalchemy" ,python2-sqlalchemy)
+       ("python2-straight.plugin" ,python2-straight.plugin)
+       ("python2-trollius-redis" ,python2-trollius-redis)
+       ("python2-wtforms" ,python2-wtforms)
+       ("python2-cryptography" ,python2-cryptography)
+       ;; TODO: python2-fedora ;for fas and openid auth backends
+       ("python2-py-bcrypt" ,python2-py-bcrypt)))
+    (home-page "https://pagure.io/pagure/")
+    (synopsis "Web-based collaborative software platform based on pygit2")
+    (description
+     "Pagure is a git-centered, web-based collaborative
+software platform, Python-based using pygit2.
+With pagure you can host your project with its documentation,
+let your users report issues or request enhancements using the
+ticketing system and build your community of contributors by
+allowing them to fork your project and contribute to it via
+the pull-request mechanism.")
+    (license license:gpl2+)))
-- 
2.11.0

Re: [PATCH 11/11] gnu: Add pagure.

[Leo Famulari]

On Wed, Dec 14, 2016 at 12:25:26PM +0000, ng0 wrote:
> * gnu/packages/version-control.scm (pagure): New variable.

How can I test this? Is there supposed to be 'runserver.py' file to run?

https://pagure.io/pagure

Re: [PATCH 11/11] gnu: Add pagure.

[ng0]

Leo Famulari <leo@famulari.name> writes:

> On Wed, Dec 14, 2016 at 12:25:26PM +0000, ng0 wrote:
>> * gnu/packages/version-control.scm (pagure): New variable.
>
> How can I test this? Is there supposed to be 'runserver.py' file to run?
>
> https://pagure.io/pagure

It's mostly "read the docs" and as I progressed in reading the
docs, I realized I forgot to add some more files.
So... New patch coming in later, sorry. Can everything else
except pagure be merged already? Or do you want to wait on that?

https://docs.pagure.org/pagure/install.html#installing-pagure-via-setup-py

-- 
♥Ⓐ  ng0  | ng0.chaosnet.org

Re: [PATCH 11/11] gnu: Add pagure.

[Leo Famulari]

On Wed, Dec 14, 2016 at 04:27:18PM +0000, ng0 wrote:
> Leo Famulari <leo@famulari.name> writes:
> 
> > On Wed, Dec 14, 2016 at 12:25:26PM +0000, ng0 wrote:
> >> * gnu/packages/version-control.scm (pagure): New variable.
> >
> > How can I test this? Is there supposed to be 'runserver.py' file to run?
> >
> > https://pagure.io/pagure
> 
> It's mostly "read the docs" and as I progressed in reading the
> docs, I realized I forgot to add some more files.
> So... New patch coming in later, sorry. Can everything else
> except pagure be merged already? Or do you want to wait on that?

Seeing Pagure run is the best way to test the rest of the patches, so
I'd rather wait.

Note that the v2 patches still need to be changed to download their
source code from PyPi.

Pagure dependencies, rebased (v3)

[ng0]

Moved the sources from github to pypi as suggested by Leo.
As I need to write a service for redis and pagure to sufficiently test pagure, it would be good if the dependencies could be added before pagure.

[PATCH 01/11] gnu: Add python-flask-wtf.

[ng0]

* gnu/packages/python.scm (python-flask-wtf): New variable.
---
 gnu/packages/python.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 76e6ac165..5a7c2a0ca 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9219,6 +9219,33 @@ presume or force a developer to use a particular tool or library.")
 (define-public python2-flask
   (package-with-python2 python-flask))
 
+(define-public python-flask-wtf
+  (package
+    (name "python-flask-wtf")
+    (version "0.13.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "Flask-WTF" version))
+       (sha256
+        (base32
+         "04l5743j2dici46038sqlzvf0xzpg8rf7s9ld2x24xv7f4idg990"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-flask-babel" ,python-flask-babel)))
+    (native-inputs
+     `(("python-nose" ,python-nose)
+       ("python-wtforms" ,python-wtforms)))
+  (home-page "https://github.com/lepture/flask-wtf")
+  (synopsis "Simple integration of Flask and WTForms")
+  (description
+   "Simple integration of Flask and WTForms, including CSRF,
+file upload, and reCAPTCHA.")
+  (license license:bsd-3)))
+
+(define-public python2-flask-wtf
+  (package-with-python2 python-flask-wtf))
+
 (define-public python-cookies
   (package
     (name "python-cookies")
-- 
2.11.0

Re: [PATCH 01/11] gnu: Add python-flask-wtf.

[Danny Milosavljevic]

Since flask-WTF directly imports flask, this package should also propagate flask.

Dependencies of pagure, revision of 2016-12-21

[ng0]

[PATCH 01/11] gnu: Add python-flask-wtf.

> Danny Milosavljevic:     
> Subject: Re: [PATCH 01/11] gnu: Add python-flask-wtf.                                      
> Date: Wed, 21 Dec 2016 00:10:39 +0100                                                      
> Since flask-WTF directly imports flask, this package should also propagate flask.    

Addressed in this new revision of the patch series, thanks Danny!

[PATCH 02/11] gnu: Add python-flask-multistatic.
[PATCH 03/11] gnu: Add python-kitchen.
[PATCH 04/11] gnu: Add python-munch.
[PATCH 05/11] gnu: Add python-pygit2.
[PATCH 06/11] gnu: Add python2-openid.
[PATCH 07/11] gnu: Add python-openid-cla.
[PATCH 08/11] gnu: Add python-openid-teams.
[PATCH 09/11] gnu: Add python-straight-plugin.
[PATCH 10/11] gnu: Add python-trollius-redis.

[PATCH 01/11] gnu: Add python-flask-wtf.

[ng0]

* gnu/packages/python.scm (python-flask-wtf): New variable.
---
 gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index bfa7eae55..0e5966336 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9219,6 +9219,34 @@ presume or force a developer to use a particular tool or library.")
 (define-public python2-flask
   (package-with-python2 python-flask))
 
+(define-public python-flask-wtf
+  (package
+    (name "python-flask-wtf")
+    (version "0.13.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "Flask-WTF" version))
+       (sha256
+        (base32
+         "04l5743j2dici46038sqlzvf0xzpg8rf7s9ld2x24xv7f4idg990"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-flask-babel" ,python-flask-babel)
+       ("python-babel" ,python-babel)))
+    (native-inputs
+     `(("python-nose" ,python-nose)
+       ("python-wtforms" ,python-wtforms)))
+  (home-page "https://github.com/lepture/flask-wtf")
+  (synopsis "Simple integration of Flask and WTForms")
+  (description
+   "Simple integration of Flask and WTForms, including CSRF,
+file upload, and reCAPTCHA.")
+  (license license:bsd-3)))
+
+(define-public python2-flask-wtf
+  (package-with-python2 python-flask-wtf))
+
 (define-public python-cookies
   (package
     (name "python-cookies")
-- 
2.11.0

[PATCH 02/11] gnu: Add python-flask-multistatic.

[ng0]

* gnu/packages/python.scm (python-flask-multistatic): New variable.
---
 gnu/packages/python.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 0e5966336..eb4289161 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9247,6 +9247,30 @@ file upload, and reCAPTCHA.")
 (define-public python2-flask-wtf
   (package-with-python2 python-flask-wtf))
 
+(define-public python-flask-multistatic
+  (package
+    (name "python-flask-multistatic")
+    (version "1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "flask-multistatic" version))
+       (sha256
+        (base32
+         "0p4v50rwv64wcd0zlq7rzl4waprwr4hj19s3cgf1isywa7jcisgm"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-flask" ,python-flask)))
+    (home-page "https://pagure.io/flask-multistatic")
+    (synopsis "Flask plugin to allow overriding static files")
+    (description
+     "@code{flask-multistatic} is a simple plugin to add
+support for overriding static files to flask.")
+    (license license:gpl3+)))
+
+(define-public python2-flask-multistatic
+  (package-with-python2 python-flask-multistatic))
+
 (define-public python-cookies
   (package
     (name "python-cookies")
-- 
2.11.0

[PATCH 03/11] gnu: Add python-kitchen.

[ng0]

* gnu/packages/python.scm (python-kitchen): New variable.
---
 gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index eb4289161..5c4ae5025 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -2435,6 +2435,36 @@ version numbers.")
              (propagated-inputs
               `(("python2-functools32" ,python2-functools32))))))
 
+(define-public python-kitchen
+  (package
+    (name "python-kitchen")
+    (version "1.2.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "kitchen" version))
+       (sha256
+        (base32
+         "0ggv3p4x8jvmmzhp0xm00h6pvh1g0gmycw71rjwagnrj8n23vxrq"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-chardet" ,python-chardet)))
+    (home-page "https://fedorahosted.org/kitchen")
+    (synopsis "Python API for snippets")
+    (description
+     "@code{kitchen} module provides a python API for all sorts
+of little useful snippets of code that everybody ends up
+writing for their projects but never seem big enough to build
+an independent release.  Use kitchen and stop cutting and
+pasting that code over and over.")
+    (license (list license:lgpl2.1+
+                   ;; subprocess.py, test_subprocess.py,
+                   ;; kitchen/pycompat25/defaultdict.py:
+                   license:psfl))))
+
+(define-public python2-kitchen
+  (package-with-python2 python-kitchen))
+
 (define-public python-unidecode
   (package
     (name "python-unidecode")
-- 
2.11.0

[PATCH 04/11] gnu: Add python-munch.

[ng0]

* gnu/packages/python.scm (python-munch): New variable.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5c4ae5025..fdfcf6027 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3255,6 +3255,28 @@ capabilities.")
 (define python2-numpy-bootstrap
   (package-with-python2 python-numpy-bootstrap))
 
+(define-public python-munch
+  (package
+    (name "python-munch")
+    (version "2.0.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "munch" version))
+       (sha256
+        (base32
+         "1cmqg91xnqx8gvnh4pmp0bfl1dfcm65d5p9mg73zz8pkjhx6h80l"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/Infinidat/munch")
+    (synopsis "Dot-accessible dictionary")
+    (description
+     "Munch is a dot-accessible dictionary similar to
+JavaScript objects.")
+    (license license:expat)))
+
+(define-public python2-munch
+  (package-with-python2 python-munch))
+
 (define-public python2-fastlmm
   (package
     (name "python2-fastlmm")
-- 
2.11.0

[PATCH 05/11] gnu: Add python-pygit2.

[ng0]

* gnu/packages/python.scm (python-pygit2): New variable.
---
 gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index fdfcf6027..3203bb421 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3374,6 +3374,34 @@ association studies (GWAS) on extremely large data sets.")
 (define-public python2-numpy
   (package-with-python2 python-numpy))
 
+(define-public python-pygit2
+  (package
+    (name "python-pygit2")
+    (version "0.24.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pygit2" version))
+       (sha256
+        (base32
+         "0shnafv9zc483wmcr4fzgvirg1qzz42xpdqd4a3ad39sdj1qbbia"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-six" ,python-six)
+       ("python-cffi" ,python-cffi)
+       ("libgit2" ,libgit2)
+       ("python-tox" ,python-tox)))
+    (home-page "https://github.com/libgit2/pygit2")
+    (synopsis "Python bindings for libgit2")
+    (description
+     "Pygit2 is a set of Python bindings to the libgit2
+shared library, libgit2 implements Git plumbing.")
+    ;; GPL2.0 only, with linking exception.
+    (license license:gpl2)))
+
+(define-public python2-pygit2
+  (package-with-python2 python-pygit2))
+
 (define-public python-pyparsing
   (package
     (name "python-pyparsing")
-- 
2.11.0

[PATCH 06/11] gnu: Add python2-openid.

[ng0]

* gnu/packages/python.scm (python2-openid): New variable.
---
 gnu/packages/python.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 3203bb421..a8ede93fd 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5048,6 +5048,26 @@ features useful for text console applications.")
 (define-public python2-urwid
   (package-with-python2 python-urwid))
 
+(define-public python2-openid
+  (package
+    (name "python2-openid")
+    (version "2.2.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "python-openid" version))
+       (sha256
+        (base32
+         "1vvhxlghjan01snfdc4k7ykd80vkyjgizwgg9bncnin8rqz1ricj"))))
+    (build-system python-build-system)
+    (arguments
+     ;; Python 3 support is in `python3-openid`, a separate package.
+     `(#:python ,python-2))
+    (home-page "https://github.com/openid/python-openid")
+    (synopsis "OpenID support for servers and consumers")
+    (description "OpenID library for Python.")
+    (license license:asl2.0)))
+
 (define-public python-urwidtrees
   (package
     (name "python-urwidtrees")
-- 
2.11.0

[PATCH 07/11] gnu: Add python-openid-cla.

[ng0]

* gnu/packages/python.scm (python-openid-cla): New variable.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index a8ede93fd..445df2cbc 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5301,6 +5301,28 @@ another XPath engine to find the matching elements in an XML or HTML document.")
 (define-public python2-cssselect
   (package-with-python2 python-cssselect))
 
+(define-public python-openid-cla
+  (package
+    (name "python-openid-cla")
+    (version "1.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "python-openid-cla" version))
+       (sha256
+        (base32
+         "102hy2qisvjxp5s0v9lvwqi4f2dk0dhns40vjgn008yxc7k0h3cr"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/puiterwijk/python-openid-cla/")
+    (synopsis "Implementation of the OpenID cla extension for python-openid")
+    (description
+     "@code{openid-cla} is an implementation of the OpenID cla
+extension for python-openid.")
+    (license license:bsd-3)))
+
+(define-public python2-openid-cla
+  (package-with-python2 python-openid-cla))
+
 (define-public python-netifaces
   (package
     (name "python-netifaces")
-- 
2.11.0

[PATCH 08/11] gnu: Add python-openid-teams.

[ng0]

* gnu/packages/python.scm (python-openid-teams): New variable.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 445df2cbc..4fd883fbe 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5323,6 +5323,28 @@ extension for python-openid.")
 (define-public python2-openid-cla
   (package-with-python2 python-openid-cla))
 
+(define-public python-openid-teams
+  (package
+    (name "python-openid-teams")
+    (version "1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "python-openid-teams" version))
+       (sha256
+        (base32
+         "05zrh78alav24rxkbqlpbad6d3x2nljk6z6j7kflxf3vdqa7w969"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/puiterwijk/python-openid-teams/")
+    (synopsis "Implementation of the OpenID teams extension for python-openid")
+    (description
+     "@code{openid-teams} is an implementation of the OpenID
+teams extension for python-openid.")
+    (license license:bsd-3)))
+
+(define-public python2-openid-teams
+  (package-with-python2 python-openid-teams))
+
 (define-public python-netifaces
   (package
     (name "python-netifaces")
-- 
2.11.0

[PATCH 09/11] gnu: Add python-straight-plugin.

[ng0]

* gnu/packages/python.scm (python-straight-plugin): New variable.
---
 gnu/packages/python.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 4fd883fbe..27405d0b5 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6012,6 +6012,30 @@ term.js Javascript terminal emulator library.")
           ,python2-backport-ssl-match-hostname)
           ,@(package-propagated-inputs terminado))))))
 
+(define-public python-straight-plugin
+  (package
+    (name "python-straight-plugin")
+    (version "1.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "straight.plugin" version))
+       (sha256
+        (base32
+         "069pjll4383p4kkgvcc40hgyvf79j2wdbpgwz77yigzxksh1gj62"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/ironfroggy/straight.plugin")
+    (synopsis "Simple namespaced plugin facility")
+    (description
+     "Straight Plugin provides a type of plugin you can create
+from almost any existing Python modules, and an easy way for
+outside developers to add functionality and customization to
+your projects with their own plugins.")
+    (license license:expat)))
+
+(define-public python2-straight-plugin
+  (package-with-python2 python-straight-plugin))
+
 (define-public python-fonttools
   (package
     (name "python-fonttools")
-- 
2.11.0

[PATCH 10/11] gnu: Add python-trollius-redis.

[ng0]

* gnu/packages/python.scm (python-trollius-redis): New variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 27405d0b5..949725756 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8017,6 +8017,29 @@ minimal and fast API targetting the following uses:
 (define-public python2-execnet
   (package-with-python2 python-execnet))
 
+(define-public python-trollius-redis
+(package
+  (name "python-trollius-redis")
+  (version "0.1.4")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "trollius_redis" version))
+      (sha256
+       (base32
+        "0k3vypszmgmaipgw9xscvgm79h2zd6p6ci8gdp5sxl6g5kbqr9fy"))))
+  (build-system python-build-system)
+  (home-page "https://github.com/benjolitz/trollius-redis")
+  (synopsis "Port of asyncio-redis to trollius")
+  (description
+   "@code{trollius-redis} is a Redis client for Python
+trollius.  It is a PEP 3156 implementation of the redis
+protocol.")
+  (license license:bsd-2)))
+
+(define-public python2-trollius-redis
+  (package-with-python2 python-trollius-redis))
+
 ;;; The software provided by this package was integrated into pytest 2.8.
 (define-public python-pytest-cache
   (package
-- 
2.11.0

Re: Dependencies of pagure, revision of 2016-12-21

[ng0]

ng0 <ng0@libertad.pw> writes:

> [PATCH 01/11] gnu: Add python-flask-wtf.
>
>> Danny Milosavljevic:     
>> Subject: Re: [PATCH 01/11] gnu: Add python-flask-wtf.                                      
>> Date: Wed, 21 Dec 2016 00:10:39 +0100                                                      
>> Since flask-WTF directly imports flask, this package should also propagate flask.    
>
> Addressed in this new revision of the patch series, thanks Danny!

Harmut, can you review this series once you are back to work?
It'd be very much appreciated.

> [PATCH 02/11] gnu: Add python-flask-multistatic.
> [PATCH 03/11] gnu: Add python-kitchen.
> [PATCH 04/11] gnu: Add python-munch.
> [PATCH 05/11] gnu: Add python-pygit2.
> [PATCH 06/11] gnu: Add python2-openid.
> [PATCH 07/11] gnu: Add python-openid-cla.
> [PATCH 08/11] gnu: Add python-openid-teams.
> [PATCH 09/11] gnu: Add python-straight-plugin.
> [PATCH 10/11] gnu: Add python-trollius-redis.
>
>

Thanks in advance,
-- 
♥Ⓐ  ng0
PGP keys and more: https://n0is.noblogs.org/ http://ng0.chaosnet.org

Re: Dependencies of pagure, revision of 2016-12-21

[Leo Famulari]

On Wed, Dec 21, 2016 at 11:47:08AM +0000, ng0 wrote:
> [PATCH 01/11] gnu: Add python-flask-wtf.
> 
> > Danny Milosavljevic:     
> > Subject: Re: [PATCH 01/11] gnu: Add python-flask-wtf.                                      
> > Date: Wed, 21 Dec 2016 00:10:39 +0100                                                      
> > Since flask-WTF directly imports flask, this package should also propagate flask.    
> 
> Addressed in this new revision of the patch series, thanks Danny!
> 
> [PATCH 02/11] gnu: Add python-flask-multistatic.
> [PATCH 03/11] gnu: Add python-kitchen.
> [PATCH 04/11] gnu: Add python-munch.
> [PATCH 05/11] gnu: Add python-pygit2.
> [PATCH 06/11] gnu: Add python2-openid.
> [PATCH 07/11] gnu: Add python-openid-cla.
> [PATCH 08/11] gnu: Add python-openid-teams.
> [PATCH 09/11] gnu: Add python-straight-plugin.
> [PATCH 10/11] gnu: Add python-trollius-redis.

Thanks! Pushed with these changes:

For python-flask-wtf, I made python-wtforms a propagated-input because
it sounds like flask-wtf needs to use it at run-time.

I also added some detail to a some of the descriptions.

In the commit messages, I mentioned the python-2 variants of the packages.

Re: Dependencies of pagure, revision of 2016-12-21

[ng0]

Leo Famulari <leo@famulari.name> writes:

> On Wed, Dec 21, 2016 at 11:47:08AM +0000, ng0 wrote:
>> [PATCH 01/11] gnu: Add python-flask-wtf.
>> 
>> > Danny Milosavljevic:     
>> > Subject: Re: [PATCH 01/11] gnu: Add python-flask-wtf.                                      
>> > Date: Wed, 21 Dec 2016 00:10:39 +0100                                                      
>> > Since flask-WTF directly imports flask, this package should also propagate flask.    
>> 
>> Addressed in this new revision of the patch series, thanks Danny!
>> 
>> [PATCH 02/11] gnu: Add python-flask-multistatic.
>> [PATCH 03/11] gnu: Add python-kitchen.
>> [PATCH 04/11] gnu: Add python-munch.
>> [PATCH 05/11] gnu: Add python-pygit2.
>> [PATCH 06/11] gnu: Add python2-openid.
>> [PATCH 07/11] gnu: Add python-openid-cla.
>> [PATCH 08/11] gnu: Add python-openid-teams.
>> [PATCH 09/11] gnu: Add python-straight-plugin.
>> [PATCH 10/11] gnu: Add python-trollius-redis.
>
> Thanks! Pushed with these changes:
>
> For python-flask-wtf, I made python-wtforms a propagated-input because
> it sounds like flask-wtf needs to use it at run-time.
>
> I also added some detail to a some of the descriptions.
>
> In the commit messages, I mentioned the python-2 variants of the packages.
>

Thanks! CC Harmut as this can be ticked off your todo list.
-- 
♥Ⓐ  ng0
PGP keys and more: https://n0is.noblogs.org/ http://ng0.chaosnet.org

[PATCH 02/11] gnu: Add python-flask-multistatic.

[ng0]

* gnu/packages/python.scm (python-flask-multistatic): New variable.
---
 gnu/packages/python.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5a7c2a0ca..5f7533011 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -9246,6 +9246,30 @@ file upload, and reCAPTCHA.")
 (define-public python2-flask-wtf
   (package-with-python2 python-flask-wtf))
 
+(define-public python-flask-multistatic
+  (package
+    (name "python-flask-multistatic")
+    (version "1.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "flask-multistatic" version))
+       (sha256
+        (base32
+         "0p4v50rwv64wcd0zlq7rzl4waprwr4hj19s3cgf1isywa7jcisgm"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-flask" ,python-flask)))
+    (home-page "https://pagure.io/flask-multistatic")
+    (synopsis "Flask plugin to allow overriding static files")
+    (description
+     "@code{flask-multistatic} is a simple plugin to add
+support for overriding static files to flask.")
+    (license license:gpl3+)))
+
+(define-public python2-flask-multistatic
+  (package-with-python2 python-flask-multistatic))
+
 (define-public python-cookies
   (package
     (name "python-cookies")
-- 
2.11.0

[PATCH 03/11] gnu: Add python-kitchen.

[ng0]

* gnu/packages/python.scm (python-kitchen): New variable.
---
 gnu/packages/python.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 5f7533011..b2a13f52b 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -2435,6 +2435,36 @@ version numbers.")
              (propagated-inputs
               `(("python2-functools32" ,python2-functools32))))))
 
+(define-public python-kitchen
+  (package
+    (name "python-kitchen")
+    (version "1.2.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "kitchen" version))
+       (sha256
+        (base32
+         "0ggv3p4x8jvmmzhp0xm00h6pvh1g0gmycw71rjwagnrj8n23vxrq"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-chardet" ,python-chardet)))
+    (home-page "https://fedorahosted.org/kitchen")
+    (synopsis "Python API for snippets")
+    (description
+     "@code{kitchen} module provides a python API for all sorts
+of little useful snippets of code that everybody ends up
+writing for their projects but never seem big enough to build
+an independent release.  Use kitchen and stop cutting and
+pasting that code over and over.")
+    (license (list license:lgpl2.1+
+                   ;; subprocess.py, test_subprocess.py,
+                   ;; kitchen/pycompat25/defaultdict.py:
+                   license:psfl))))
+
+(define-public python2-kitchen
+  (package-with-python2 python-kitchen))
+
 (define-public python-unidecode
   (package
     (name "python-unidecode")
-- 
2.11.0

[PATCH 04/11] gnu: Add python-munch.

[ng0]

* gnu/packages/python.scm (python-munch): New variable.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index b2a13f52b..0d5e3ca47 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3255,6 +3255,28 @@ capabilities.")
 (define python2-numpy-bootstrap
   (package-with-python2 python-numpy-bootstrap))
 
+(define-public python-munch
+  (package
+    (name "python-munch")
+    (version "2.0.4")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "munch" version))
+       (sha256
+        (base32
+         "1cmqg91xnqx8gvnh4pmp0bfl1dfcm65d5p9mg73zz8pkjhx6h80l"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/Infinidat/munch")
+    (synopsis "Dot-accessible dictionary")
+    (description
+     "Munch is a dot-accessible dictionary similar to
+JavaScript objects.")
+    (license license:expat)))
+
+(define-public python2-munch
+  (package-with-python2 python-munch))
+
 (define-public python2-fastlmm
   (package
     (name "python2-fastlmm")
-- 
2.11.0

[PATCH 05/11] gnu: Add python-pygit2.

[ng0]

* gnu/packages/python.scm (python-pygit2): New variable.
---
 gnu/packages/python.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 0d5e3ca47..cdc8d2b41 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -3374,6 +3374,34 @@ association studies (GWAS) on extremely large data sets.")
 (define-public python2-numpy
   (package-with-python2 python-numpy))
 
+(define-public python-pygit2
+  (package
+    (name "python-pygit2")
+    (version "0.24.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pygit2" version))
+       (sha256
+        (base32
+         "0shnafv9zc483wmcr4fzgvirg1qzz42xpdqd4a3ad39sdj1qbbia"))))
+    (build-system python-build-system)
+    (propagated-inputs
+     `(("python-six" ,python-six)
+       ("python-cffi" ,python-cffi)
+       ("libgit2" ,libgit2)
+       ("python-tox" ,python-tox)))
+    (home-page "https://github.com/libgit2/pygit2")
+    (synopsis "Python bindings for libgit2")
+    (description
+     "Pygit2 is a set of Python bindings to the libgit2
+shared library, libgit2 implements Git plumbing.")
+    ;; GPL2.0 only, with linking exception.
+    (license license:gpl2)))
+
+(define-public python2-pygit2
+  (package-with-python2 python-pygit2))
+
 (define-public python-pyparsing
   (package
     (name "python-pyparsing")
-- 
2.11.0

[PATCH 06/11] gnu: Add python2-openid.

[ng0]

* gnu/packages/python.scm (python2-openid): New variable.
---
 gnu/packages/python.scm | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index cdc8d2b41..2b328becb 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5048,6 +5048,26 @@ features useful for text console applications.")
 (define-public python2-urwid
   (package-with-python2 python-urwid))
 
+(define-public python2-openid
+  (package
+    (name "python2-openid")
+    (version "2.2.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "python-openid" version))
+       (sha256
+        (base32
+         "1vvhxlghjan01snfdc4k7ykd80vkyjgizwgg9bncnin8rqz1ricj"))))
+    (build-system python-build-system)
+    (arguments
+     ;; Python 3 support is in `python3-openid`, a separate package.
+     `(#:python ,python-2))
+    (home-page "https://github.com/openid/python-openid")
+    (synopsis "OpenID support for servers and consumers")
+    (description "OpenID library for Python.")
+    (license license:asl2.0)))
+
 (define-public python-urwidtrees
   (package
     (name "python-urwidtrees")
-- 
2.11.0

[PATCH 07/11] gnu: Add python-openid-cla.

[ng0]

* gnu/packages/python.scm (python-openid-cla): New variable.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 2b328becb..63fc777d3 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5301,6 +5301,28 @@ another XPath engine to find the matching elements in an XML or HTML document.")
 (define-public python2-cssselect
   (package-with-python2 python-cssselect))
 
+(define-public python-openid-cla
+  (package
+    (name "python-openid-cla")
+    (version "1.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "python-openid-cla" version))
+       (sha256
+        (base32
+         "102hy2qisvjxp5s0v9lvwqi4f2dk0dhns40vjgn008yxc7k0h3cr"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/puiterwijk/python-openid-cla/")
+    (synopsis "Implementation of the OpenID cla extension for python-openid")
+    (description
+     "@code{openid-cla} is an implementation of the OpenID cla
+extension for python-openid.")
+    (license license:bsd-3)))
+
+(define-public python2-openid-cla
+  (package-with-python2 python-openid-cla))
+
 (define-public python-netifaces
   (package
     (name "python-netifaces")
-- 
2.11.0

[PATCH 08/11] gnu: Add python-openid-teams.

[ng0]

* gnu/packages/python.scm (python-openid-teams): New variable.
---
 gnu/packages/python.scm | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 63fc777d3..927542cfd 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5323,6 +5323,28 @@ extension for python-openid.")
 (define-public python2-openid-cla
   (package-with-python2 python-openid-cla))
 
+(define-public python-openid-teams
+  (package
+    (name "python-openid-teams")
+    (version "1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "python-openid-teams" version))
+       (sha256
+        (base32
+         "05zrh78alav24rxkbqlpbad6d3x2nljk6z6j7kflxf3vdqa7w969"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/puiterwijk/python-openid-teams/")
+    (synopsis "Implementation of the OpenID teams extension for python-openid")
+    (description
+     "@code{openid-teams} is an implementation of the OpenID
+teams extension for python-openid.")
+    (license license:bsd-3)))
+
+(define-public python2-openid-teams
+  (package-with-python2 python-openid-teams))
+
 (define-public python-netifaces
   (package
     (name "python-netifaces")
-- 
2.11.0

[PATCH 09/11] gnu: Add python-straight-plugin.

[ng0]

* gnu/packages/python.scm (python-straight-plugin): New variable.
---
 gnu/packages/python.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 927542cfd..23788b846 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -6012,6 +6012,30 @@ term.js Javascript terminal emulator library.")
           ,python2-backport-ssl-match-hostname)
           ,@(package-propagated-inputs terminado))))))
 
+(define-public python-straight-plugin
+  (package
+    (name "python-straight-plugin")
+    (version "1.4.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "straight.plugin" version))
+       (sha256
+        (base32
+         "069pjll4383p4kkgvcc40hgyvf79j2wdbpgwz77yigzxksh1gj62"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/ironfroggy/straight.plugin")
+    (synopsis "Simple namespaced plugin facility")
+    (description
+     "Straight Plugin provides a type of plugin you can create
+from almost any existing Python modules, and an easy way for
+outside developers to add functionality and customization to
+your projects with their own plugins.")
+    (license license:expat)))
+
+(define-public python2-straight-plugin
+  (package-with-python2 python-straight-plugin))
+
 (define-public python-fonttools
   (package
     (name "python-fonttools")
-- 
2.11.0

[PATCH 10/11] gnu: Add python-trollius-redis.

[ng0]

* gnu/packages/python.scm (python-trollius-redis): New variable.
---
 gnu/packages/python.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 23788b846..50fae6943 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -8017,6 +8017,29 @@ minimal and fast API targetting the following uses:
 (define-public python2-execnet
   (package-with-python2 python-execnet))
 
+(define-public python-trollius-redis
+(package
+  (name "python-trollius-redis")
+  (version "0.1.4")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (pypi-uri "trollius_redis" version))
+      (sha256
+       (base32
+        "0k3vypszmgmaipgw9xscvgm79h2zd6p6ci8gdp5sxl6g5kbqr9fy"))))
+  (build-system python-build-system)
+  (home-page "https://github.com/benjolitz/trollius-redis")
+  (synopsis "Port of asyncio-redis to trollius")
+  (description
+   "@code{trollius-redis} is a Redis client for Python
+trollius.  It is a PEP 3156 implementation of the redis
+protocol.")
+  (license license:bsd-2)))
+
+(define-public python2-trollius-redis
+  (package-with-python2 python-trollius-redis))
+
 ;;; The software provided by this package was integrated into pytest 2.8.
 (define-public python-pytest-cache
   (package
-- 
2.11.0

Re: [PATCH 11/11] gnu: Add pagure.

[ng0]

ng0 <ng0@libertad.pw> writes:

> Leo Famulari <leo@famulari.name> writes:
>
>> On Wed, Dec 14, 2016 at 12:25:26PM +0000, ng0 wrote:
>>> * gnu/packages/version-control.scm (pagure): New variable.
>>
>> How can I test this? Is there supposed to be 'runserver.py' file to run?
>>
>> https://pagure.io/pagure
>
> It's mostly "read the docs" and as I progressed in reading the
> docs, I realized I forgot to add some more files.
> So... New patch coming in later, sorry. Can everything else
> except pagure be merged already? Or do you want to wait on that?
>
> https://docs.pagure.org/pagure/install.html#installing-pagure-via-setup-py

Appending to my last message, it can take a while until I submit
the next change. Getting this package working is in my own
interest so I will definitely finish this.

-- 
♥Ⓐ  ng0  | ng0.chaosnet.org