Re: [PATCH] gnu: windowmaker: Fix invocation of 'wmsetbg'.

[Leo Famulari <leo@famulari.name>]

[-- Attachment #1: Type: text/plain, Size: 1219 bytes --]

On Wed, Oct 26, 2016 at 12:14:03AM -0400, Kei Kebreau wrote:
> Marius Bakke <mbakke@fastmail.com> writes:
> 
> > Kei Kebreau <kei@openmailbox.org> writes:
> >
> >> This patch allows Window Maker to run wmsetbg properly instead of
> >> showing an error as it has been.
> >> From a113116da6f9f6574e9fde12e69a9d3acdc87769 Mon Sep 17 00:00:00 2001
> >> From: Kei Kebreau <kei@openmailbox.org>
> >> Date: Sun, 23 Oct 2016 13:50:05 -0400
> >> Subject: [PATCH] gnu: windowmaker: Fix invocation of 'wmsetbg'.
> >>
> >> * gnu/packages/gnustep.scm (windowmaker)[arguments]: Add substitution of
> >> 40-character limit with a 107-character limit.
> >> ---
> >>  gnu/packages/gnustep.scm | 8 +++++++-
> >>  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > I haven't tested this, but the diff looks reasonable. Good catch. Any
> > chance you can submit this upstream as well?
> 
> I could bring it up, but I'm not so sure that it would be a change worth
> considering. The Window Maker mailing list is very low volume, and no
> one seems to have complained about this.

I think it's a safe change, but I also think we should always let
upstream know when we are modifying string-handling code in C.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]