From: Leo Famulari <leo@famulari.name>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH 3/3] gnu: python2-notebook: Fix build.
Date: Mon, 5 Dec 2016 16:44:34 -0500 [thread overview]
Message-ID: <20161205214434.GC21176@jasmine> (raw)
In-Reply-To: <1480940465-15430-3-git-send-email-h.goebel@crazy-compilers.com>
On Mon, Dec 05, 2016 at 01:21:05PM +0100, Hartmut Goebel wrote:
> * gnu/packages/python.scm (python2-notebook)[properties]: Add
> python2-variant.
> (python2-notebook)[native-packages] add python2-mock. [arguments] Add
> phase "disable-test-case" for disabling a failing test. immediately
s/ immediately//
> (define-public python2-notebook
> - (package-with-python2 python-notebook))
> + (let ((base (package-with-python2
> + (strip-python2-variant python-notebook))))
> + (package (inherit base)
> + (native-inputs
> + `(("python2-mock" ,python2-mock)
> + ,@(package-native-inputs base)))
> + (arguments
> + (substitute-keyword-arguments (package-arguments base)
> + ((#:phases phases)
> + `(modify-phases ,phases
> + (add-before 'check 'disable-test-case
> + ;; The test requires network access to localhost. Curiously it
> + ;; files with Python 2 only. Simply make the test-case return
s/files/fails
Otherwise LGTM, thanks! I was just noticing this issue :)
next prev parent reply other threads:[~2016-12-05 21:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 12:21 [PATCH 1/3] gnu: python-ipython: Update to 4.0.3 Hartmut Goebel
2016-12-05 12:21 ` [PATCH 2/3] gnu: python-ipython-genutils: Update description Hartmut Goebel
2016-12-05 21:45 ` Leo Famulari
2016-12-05 12:21 ` [PATCH 3/3] gnu: python2-notebook: Fix build Hartmut Goebel
2016-12-05 21:44 ` Leo Famulari [this message]
2016-12-06 10:31 ` Hartmut Goebel
2016-12-05 21:43 ` [PATCH 1/3] gnu: python-ipython: Update to 4.0.3 Leo Famulari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205214434.GC21176@jasmine \
--to=leo@famulari.name \
--cc=guix-devel@gnu.org \
--cc=h.goebel@crazy-compilers.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.