From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 9/9] gnu: Add ocaml-menhir.
Date: Sat, 3 Dec 2016 15:12:30 -0500
Message-ID: <20161203201230.GJ21416@jasmine>
References: <20161203104213.8135-1-david@craven.ch>
	<20161203104213.8135-9-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52258)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cDGfk-0007QP-U7
	for guix-devel@gnu.org; Sat, 03 Dec 2016 15:12:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cDGff-0007sj-UO
	for guix-devel@gnu.org; Sat, 03 Dec 2016 15:12:36 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:38108)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1cDGff-0007sT-QY
	for guix-devel@gnu.org; Sat, 03 Dec 2016 15:12:31 -0500
Content-Disposition: inline
In-Reply-To: <20161203104213.8135-9-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

On Sat, Dec 03, 2016 at 11:42:13AM +0100, David Craven wrote:
> * gnu/packages/ocaml.scm (ocaml-menhir): New variable.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'configure
> +           (lambda* (#:key outputs #:allow-other-keys)
> +             (let ((out (assoc-ref outputs "out")))
> +               (setenv "PREFIX" out))
> +             #t)))))

This is skipping the configure phase and reusing it to set the PREFIX
variable, right?

If so, I think it's better to delete the configure phase and set the
variable in its own set-env phase, or with #:configure-flags or
#:make-flags (if they are respected by this build system).