From mboxrd@z Thu Jan  1 00:00:00 1970
From: Leo Famulari <leo@famulari.name>
Subject: Re: [PATCH 8/9] gnu: coq: Update to 8.5pl2.
Date: Sat, 3 Dec 2016 15:09:23 -0500
Message-ID: <20161203200923.GI21416@jasmine>
References: <20161203104213.8135-1-david@craven.ch>
	<20161203104213.8135-8-david@craven.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Return-path: <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51672)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cDGck-000727-I7
	for guix-devel@gnu.org; Sat, 03 Dec 2016 15:09:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <leo@famulari.name>) id 1cDGcf-0005gH-C5
	for guix-devel@gnu.org; Sat, 03 Dec 2016 15:09:30 -0500
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60208)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <leo@famulari.name>) id 1cDGcf-0005ft-7X
	for guix-devel@gnu.org; Sat, 03 Dec 2016 15:09:25 -0500
Content-Disposition: inline
In-Reply-To: <20161203104213.8135-8-david@craven.ch>
List-Id: "Development of GNU Guix and the GNU System distribution."
	<guix-devel.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-devel/>
List-Post: <mailto:guix-devel@gnu.org>
List-Help: <mailto:guix-devel-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-devel>,
	<mailto:guix-devel-request@gnu.org?subject=subscribe>
Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org
Sender: "Guix-devel" <guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org>
To: David Craven <david@craven.ch>
Cc: guix-devel@gnu.org

On Sat, Dec 03, 2016 at 11:42:12AM +0100, David Craven wrote:
> * gnu/packages/ocaml.scm (coq): Update to 8.5pl2.
>   [arguments]: Configure script takes single hyphen arguments.

>      (source (origin
>                (method url-fetch)
> -              (uri (string-append "https://coq.inria.fr/distrib/V" version
> -                                  "/files/" name "-" version ".tar.gz"))
> +              (uri (string-append
> +                    "https://coq.inria.fr/distrib"
> +                    "/V" version "/files/"
> +                    "coq-" version ".tar.gz"))

The URI is unchanged, right? If so, I'd leave this hunk out of the
commit.

Otherwise LGTM.