From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH v4 3/3] gnu: Add kicad. Date: Fri, 25 Nov 2016 00:40:51 -0500 Message-ID: <20161125054051.GA30271@jasmine> References: <20161105184131.GA11070@jasmine> <20161107181628.23640-1-theodoros.for@openmailbox.org> <20161107181628.23640-3-theodoros.for@openmailbox.org> <20161115192643.GA420@jasmine> <874m2zi9is.fsf@openmailbox.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36058) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cA9Fs-0003JW-99 for guix-devel@gnu.org; Fri, 25 Nov 2016 00:41:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cA9Fn-0002vF-AM for guix-devel@gnu.org; Fri, 25 Nov 2016 00:41:00 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:42593) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cA9Fn-0002ta-2Q for guix-devel@gnu.org; Fri, 25 Nov 2016 00:40:55 -0500 Content-Disposition: inline In-Reply-To: <874m2zi9is.fsf@openmailbox.org> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Theodoros Foradis Cc: Guix-devel On Tue, Nov 22, 2016 at 09:46:17PM +0200, Theodoros Foradis wrote: > > Leo Famulari writes: > > > On Mon, Nov 07, 2016 at 08:16:28PM +0200, Theodoros Foradis wrote: > >> * gnu/packages/engineering.scm (kicad): New variable. > > > > There are some comments about minor issues on this version 3 of the > > patch series. I can address these myself before pushing if there are no > > more comments. I will read the patches one more time, test the build, > > and push tomorrow if there are no more comments. > > > > Thanks to everyone who was worked on this! It's a big group :) > > Hello, > > I have posted a version 5 of the patch series, which I have not > commented on. It (hopefully) includes the fixes, based on the comments > on previous patch series. > > It contains an extra patch, with the kicad-library package, which > includes components, footprints and 3D models for kicad. I fixed some minor cosmetic issues (long lines, indentation, etc) and also made some minor edits to descriptions and comments, and pushed the v5 patch series, ending with 8f528bd4426fdb3e6e571316b185e70d30485c7e. Thanks a lot everyone!