From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] Added package xcalib Date: Sat, 19 Nov 2016 13:36:52 -0500 Message-ID: <20161119183652.GA18749@jasmine> References: <20161115193543.GB420@jasmine> <187506c7022391ac0766a444f73657df@mykolab.ch> <20161118201015.GB16535@jasmine> <17b0d56c8b2baf7fd52212ec829860ff@mykolab.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:37398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c8AVZ-0001JB-3q for guix-devel@gnu.org; Sat, 19 Nov 2016 13:37:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c8AVU-0006p6-5K for guix-devel@gnu.org; Sat, 19 Nov 2016 13:37:01 -0500 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:45622) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c8AVU-0006p2-10 for guix-devel@gnu.org; Sat, 19 Nov 2016 13:36:56 -0500 Content-Disposition: inline In-Reply-To: <17b0d56c8b2baf7fd52212ec829860ff@mykolab.ch> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Petter Cc: guix-devel@gnu.org On Sat, Nov 19, 2016 at 06:14:32PM +0100, Petter wrote: > On 2016-11-18 21:10, Leo Famulari wrote: > > (install-file) does (mkdir-p) itself, so I removed the redundant > > (mkdir-p). It's defined in (guix build utils) if you are interested to > > see. > > Ok. I looked it up in another package, and copied the approach. (I see this > redundancy occurs in several other places.) Feel free to submit patches fixing those redundancies! > Thanks for doing the final touches! And I really appreciate your detailed > explanations! The next patch should hopefully be less of a burden on you > reviewers :) That's my plan :)