From mboxrd@z Thu Jan 1 00:00:00 1970 From: Leo Famulari Subject: Re: [PATCH] gnu: Add openfwwf-firmware. Date: Fri, 18 Nov 2016 23:13:53 -0500 Message-ID: <20161119041353.GA17084@jasmine> References: <20161116212918.5dd43c22@centurylink.net> <20161118210430.GA29593@jasmine> <20161118211431.5abb627e@centurylink.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:42341) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c7x2P-0002jr-0n for guix-devel@gnu.org; Fri, 18 Nov 2016 23:14:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c7x2L-00032k-RJ for guix-devel@gnu.org; Fri, 18 Nov 2016 23:14:00 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:37244) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c7x2L-00032S-Ml for guix-devel@gnu.org; Fri, 18 Nov 2016 23:13:57 -0500 Content-Disposition: inline In-Reply-To: <20161118211431.5abb627e@centurylink.net> List-Id: "Development of GNU Guix and the GNU System distribution." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-devel-bounces+gcggd-guix-devel=m.gmane.org@gnu.org Sender: "Guix-devel" To: Eric Bavier Cc: guix-devel@gnu.org On Fri, Nov 18, 2016 at 09:14:31PM -0600, Eric Bavier wrote: > On Fri, 18 Nov 2016 16:04:30 -0500 > Leo Famulari wrote: > > > + (version (string-append "20140625-" rev "." (string-take commit 7))) > > > > Is the timestamp some kind of upstream version string? If not, and there > > is no upstream version naming, we should use 0.0.0, right? > > This package contains a collections of tools, only one of which > declares any sort of version (fwcutter). I had gathered that the > date-string approach was acceptable for VCS checkouts when versions are > otherwise not available. We have 34 other packages whose version begin > with such a date-string (e.g. guile-minikanren, scmutils, > guile-for-guile-emacs, guile-emacs, woff2, font-google-noto, ...). Okay, no strong opinion here :) Thanks for writing this package!