From: Eric Bavier <ericbavier@centurylink.net>
To: Leo Famulari <leo@famulari.name>
Cc: guix-devel@gnu.org
Subject: Re: [PATCH] gnu: Add openfwwf-firmware.
Date: Fri, 18 Nov 2016 21:14:31 -0600 [thread overview]
Message-ID: <20161118211431.5abb627e@centurylink.net> (raw)
In-Reply-To: <20161118210430.GA29593@jasmine>
On Fri, 18 Nov 2016 16:04:30 -0500
Leo Famulari <leo@famulari.name> wrote:
> On Wed, Nov 16, 2016 at 09:29:18PM -0600, Eric Bavier wrote:
> > Hello Guix,
> >
> > We've had at least one person on IRC confirm that this firmware package
> > worked for them, allowing them to use their wireless hardware.
> >
> > Would it be appropriate to add this to %base-firmware? The output is
> > rather small.
>
> How small?
36K
> Since they seem to work, I'd say they should be added.
>
> > From c397f73d69326db24c211e4e2bda46e647d0e751 Mon Sep 17 00:00:00 2001
> > From: Eric Bavier <bavier@member.fsf.org>
> > Date: Thu, 12 May 2016 13:57:01 -0500
> > Subject: [PATCH] gnu: Add openfwwf-firmware.
> >
> > * gnu/packages/firmware.scm (b43-tools, openfwwf-firmware): New
> > variables.
>
> > +(define-public b43-tools
> > + (let ((commit "8dce53297966b31b6c70a7a03c2433978dd9f288")
> > + (rev "1"))
>
> How do we choose a commit?
This was the latest commit at the time of packaging. There have been
new commits since, but they affect only the debugging tools, which we
do not build here.
> > + (package
> > + (name "b43-tools")
> > + (version (string-append "20140625-" rev "." (string-take commit 7)))
>
> Is the timestamp some kind of upstream version string? If not, and there
> is no upstream version naming, we should use 0.0.0, right?
This package contains a collections of tools, only one of which
declares any sort of version (fwcutter). I had gathered that the
date-string approach was acceptable for VCS checkouts when versions are
otherwise not available. We have 34 other packages whose version begin
with such a date-string (e.g. guile-minikanren, scmutils,
guile-for-guile-emacs, guile-emacs, woff2, font-google-noto, ...).
> > + #:phases
> > + (let ((subdirs '("assembler" "disassembler"))) ;TODO: fwcutter
>
> Can you expand the TODO comment?
I may just remove it. If someone needs the other tools, they should
know what to do.
`~Eric
next prev parent reply other threads:[~2016-11-19 3:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 3:29 [PATCH] gnu: Add openfwwf-firmware Eric Bavier
2016-11-18 21:04 ` Leo Famulari
2016-11-19 3:14 ` Eric Bavier [this message]
2016-11-19 4:13 ` Leo Famulari
2016-11-21 9:05 ` Ludovic Courtès
2016-11-22 15:42 ` Eric Bavier
2016-12-06 19:56 ` Danny Milosavljevic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118211431.5abb627e@centurylink.net \
--to=ericbavier@centurylink.net \
--cc=guix-devel@gnu.org \
--cc=leo@famulari.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/guix.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.